From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE727C433ED for ; Thu, 13 May 2021 11:42:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0A426143D for ; Thu, 13 May 2021 11:42:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232735AbhEMLnh (ORCPT ); Thu, 13 May 2021 07:43:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:29817 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232318AbhEMLna (ORCPT ); Thu, 13 May 2021 07:43:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620906140; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R+xpriwoqMR4hMxYIDQ9tzTIIOzNsv7iGskqwPCMAtI=; b=OI27jo8NIxgomqRr60ykXGsCjDHgwrGm6G0QX0rLYa7GqsbaWTFZBEyG2DSoBKKFUH4mDT fvl90ygMZEZH9fjAwXot8JUE1E6HdyYmdmBLyfdu+kELMjMPqK3XRN965emRnKKApcYXaR wsT+QkA80iJTLKt3zc29VpCMlHUYNCo= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-2-XuMfe5PYPRK-7nq4p_OR_w-1; Thu, 13 May 2021 07:42:18 -0400 X-MC-Unique: XuMfe5PYPRK-7nq4p_OR_w-1 Received: by mail-ej1-f72.google.com with SMTP id z15-20020a170906074fb029038ca4d43d48so8280828ejb.17 for ; Thu, 13 May 2021 04:42:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=R+xpriwoqMR4hMxYIDQ9tzTIIOzNsv7iGskqwPCMAtI=; b=LHIC3HWok0AmxIKMkievst8VDoI8vlH/+lXeLlx7HMTDnKRf5+np1o2KWrcte0T8CR qOuH2ildchPnS9tuwpiqOvTwOd0GVJNZA4u4l2eEz1gS7L1lvwNQgXw/B+e2wVCYZ2SS Coc6mImWvosFeBMYXT6XdzvsqHNgBnEaLyWkwHdOQO/12TMpayKrQi4+JBXX1u8B4Vpf 3vqHGjh8M3zKVtjvfV28I3V/AsxyTcPU+HeT+F3oetRXhD7NdqE1iZ+KB4ZzRdciTPjm prrC9QVukBGemXFubbPzVTtDs6K9nLHaBPBnuFrO7scPJmhu+z8DikJxvdctnX4WcJiN B7vw== X-Gm-Message-State: AOAM530YTqGAlHD3CJRISj+TNrXLaPS2cMF+Re45ka/Fp9IAK8L93U8X nwCGyNrRhGP6WmoOJBc3F0mH6PxA/rIE/Bw0ZBitlOB2HyIGxJORnGBqSs5hzo7nsZ7HNA4xQH3 z/mOdbztJjXb6 X-Received: by 2002:a17:906:11d5:: with SMTP id o21mr39425176eja.176.1620906137650; Thu, 13 May 2021 04:42:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy4evvrqMGAM5r4UR85o5vJGUe4V1rA7BD2JGHOAS51E0jB0311f1ua3YMBd6FJgtBjiTezpQ== X-Received: by 2002:a17:906:11d5:: with SMTP id o21mr39425159eja.176.1620906137418; Thu, 13 May 2021 04:42:17 -0700 (PDT) Received: from steredhat (host-79-18-148-79.retail.telecomitalia.it. [79.18.148.79]) by smtp.gmail.com with ESMTPSA id q25sm1704765ejd.9.2021.05.13.04.42.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 04:42:17 -0700 (PDT) Date: Thu, 13 May 2021 13:42:14 +0200 From: Stefano Garzarella To: Arseny Krasnov Cc: Stefan Hajnoczi , "Michael S. Tsirkin" , Jason Wang , "David S. Miller" , Jakub Kicinski , Jorgen Hansen , Colin Ian King , Andra Paraschiv , Norbert Slusarek , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stsp2@yandex.ru, oxffffaa@gmail.com Subject: Re: [RFC PATCH v9 06/19] af_vsock: rest of SEQPACKET support Message-ID: <20210513114214.66mfm76tp65af5yq@steredhat> References: <20210508163027.3430238-1-arseny.krasnov@kaspersky.com> <20210508163350.3431361-1-arseny.krasnov@kaspersky.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20210508163350.3431361-1-arseny.krasnov@kaspersky.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Sat, May 08, 2021 at 07:33:46PM +0300, Arseny Krasnov wrote: >This does rest of SOCK_SEQPACKET support: >1) Adds socket ops for SEQPACKET type. >2) Allows to create socket with SEQPACKET type. > >Signed-off-by: Arseny Krasnov >Reviewed-by: Stefano Garzarella This patch is changed, so usually you should remove the R-b tags. >--- > include/net/af_vsock.h | 1 + > net/vmw_vsock/af_vsock.c | 36 +++++++++++++++++++++++++++++++++++- > 2 files changed, 36 insertions(+), 1 deletion(-) > >diff --git a/include/net/af_vsock.h b/include/net/af_vsock.h >index 5860027d5173..1747c0b564ef 100644 >--- a/include/net/af_vsock.h >+++ b/include/net/af_vsock.h >@@ -140,6 +140,7 @@ struct vsock_transport { > int flags, bool *msg_ready); > int (*seqpacket_enqueue)(struct vsock_sock *vsk, struct msghdr *msg, > size_t len); >+ bool (*seqpacket_allow)(u32 remote_cid); I'm thinking if it's better to follow .dgram_allow() and .stream_allow(), specifying also the `port` param, but since it's not used, we can add later if needed. So, I think this is fine: Reviewed-by: Stefano Garzarella