From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2596AC43461 for ; Fri, 21 May 2021 13:25:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 106CB613F9 for ; Fri, 21 May 2021 13:25:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235301AbhEUN1D (ORCPT ); Fri, 21 May 2021 09:27:03 -0400 Received: from foss.arm.com ([217.140.110.172]:47306 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235201AbhEUN05 (ORCPT ); Fri, 21 May 2021 09:26:57 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 55B3811B3; Fri, 21 May 2021 06:25:34 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.33.243]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 795FC3F73B; Fri, 21 May 2021 06:25:28 -0700 (PDT) Date: Fri, 21 May 2021 14:25:19 +0100 From: Mark Rutland To: Joe Richey Cc: trivial@kernel.org, Joe Richey , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Paolo Bonzini , Lorenzo Pieralisi , Mauro Carvalho Chehab , Zhangfei Gao , Zhou Wang , Andy Whitcroft , Joe Perches , Dwaipayan Ray , Lukas Bulwahn , Sasha Levin , "Chang S. Bae" , Andi Kleen , Lei Cao , Peter Xu , Daniel Lezcano , Ulf Hansson , "Rafael J. Wysocki" , Jean-Philippe Brucker , Zaibo Xu , Kenneth Lee , Greg Kroah-Hartman , Hans Verkuil , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-accelerators@lists.ozlabs.org Subject: Re: [PATCH v2 3/7] drivers: firmware: psci: Use _BITUL() macro in UAPI headers Message-ID: <20210521132519.GA7325@C02TD0UTHF1T.local> References: <20210520104343.317119-1-joerichey94@gmail.com> <20210521085849.37676-1-joerichey94@gmail.com> <20210521085849.37676-4-joerichey94@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210521085849.37676-4-joerichey94@gmail.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, May 21, 2021 at 01:58:44AM -0700, Joe Richey wrote: > From: Joe Richey > > Replace BIT() in psci's UPAI header with _BITUL(). BIT() is not defined > in the UAPI headers and its usage may cause userspace build errors. > > Fixes: 60dd1ead65e8 ("drivers: firmware: psci: Announce support for OS initiated suspend mode") > Signed-off-by: Joe Richey Acked-by: Mark Rutland Mark. > --- > include/uapi/linux/psci.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/uapi/linux/psci.h b/include/uapi/linux/psci.h > index 2fcad1dd0b0e..87afdeb95096 100644 > --- a/include/uapi/linux/psci.h > +++ b/include/uapi/linux/psci.h > @@ -12,6 +12,8 @@ > #ifndef _UAPI_LINUX_PSCI_H > #define _UAPI_LINUX_PSCI_H > > +#include > + > /* > * PSCI v0.1 interface > * > @@ -100,7 +102,7 @@ > #define PSCI_1_0_FEATURES_CPU_SUSPEND_PF_MASK \ > (0x1 << PSCI_1_0_FEATURES_CPU_SUSPEND_PF_SHIFT) > > -#define PSCI_1_0_OS_INITIATED BIT(0) > +#define PSCI_1_0_OS_INITIATED _BITUL(0) > #define PSCI_1_0_SUSPEND_MODE_PC 0 > #define PSCI_1_0_SUSPEND_MODE_OSI 1 > > -- > 2.31.1 >