From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5B3CC2B9F8 for ; Tue, 25 May 2021 14:52:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C0FD76135F for ; Tue, 25 May 2021 14:52:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234185AbhEYOx6 (ORCPT ); Tue, 25 May 2021 10:53:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:35505 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234030AbhEYOx4 (ORCPT ); Tue, 25 May 2021 10:53:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621954346; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qSC9QpCDqCazF2mZq6d/82qLDoFltpJkJoLoXKJjvvg=; b=Ae/cDFzEdr4Mcv501zWIjTQa9VHrixNO8oXY31ht6RDbmrY1I3KyBOcIp8HLI1kpUHQzzT 68losLhh71RyECvM2pMtY3sl9FDICW46pIP1yPoYMt9VEqoSy4aVWLce4fspgeHbllZLnW fh7sdYs91uJRsa0xHhyBzrKl1aiUUEM= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-275-bOvvmVjsOUelZW7eFdbI_Q-1; Tue, 25 May 2021 10:52:24 -0400 X-MC-Unique: bOvvmVjsOUelZW7eFdbI_Q-1 Received: by mail-ed1-f71.google.com with SMTP id y17-20020a0564023591b02903886c26ada4so17464787edc.5 for ; Tue, 25 May 2021 07:52:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qSC9QpCDqCazF2mZq6d/82qLDoFltpJkJoLoXKJjvvg=; b=pt706ARWXoX6S4UwxQZtIUIGYDBcNhn5u8PGzWOC/ObraDPFhhFSGR5B1j/gwUQDTs 2eDHD+MRQnOzQAEitUNsDPGeF9i3d6zIrdzxd5eSLif/QOg+4y+HdEF3rQYMESsNQ3TR VI7wcAbaRkZAkk/A6QAxuI4hns9AVzkynrqPrFiV83JBIN8s1khOYUUg1ZNv2AdzqQ2s /X9ca+d3716MwoYDC0wYFzTyz8x0Wtm91cvkyPjYJ88hHdTsy5GpsqNFG/ElFHjvNqu3 ZKbLwiRtclm0CrVJ2kjwHdHPW1ZjxNT7PRa3LuYRkl1uBAdZNzTri8R5UKtWPJ/0obW3 +sbQ== X-Gm-Message-State: AOAM531oOHMFBv1Ij4RBT9RqYNOl5ioUcWT6IYSeWdDPG9i3OZcHosXm GIGX52T/TvyDx4IVPxwgbVdBQihryxx3g95tUMgAyMXqcoIe9BqH5OfPGp6B5qRfZeIJAqUPnU/ gEbKiOnbS+/et X-Received: by 2002:aa7:d843:: with SMTP id f3mr32220067eds.270.1621954343100; Tue, 25 May 2021 07:52:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxDlSSMgDZFTIhLb5CNVeQ1FOGcYDV/D4Z+HKGAvXmcW1X5RbFzEx/ev3BuN5v5ARSJGUCLSQ== X-Received: by 2002:aa7:d843:: with SMTP id f3mr32220039eds.270.1621954342913; Tue, 25 May 2021 07:52:22 -0700 (PDT) Received: from steredhat (host-79-18-148-79.retail.telecomitalia.it. [79.18.148.79]) by smtp.gmail.com with ESMTPSA id h9sm10912173edt.18.2021.05.25.07.52.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 07:52:22 -0700 (PDT) Date: Tue, 25 May 2021 16:52:20 +0200 From: Stefano Garzarella To: Arseny Krasnov Cc: Stefan Hajnoczi , "Michael S. Tsirkin" , Jason Wang , "David S. Miller" , Jakub Kicinski , Jorgen Hansen , Colin Ian King , Norbert Slusarek , Andra Paraschiv , "kvm@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "oxffffaa@gmail.com" Subject: Re: [PATCH v10 00/18] virtio/vsock: introduce SOCK_SEQPACKET support Message-ID: <20210525145220.amzme5mqqv4npirt@steredhat> References: <20210520191357.1270473-1-arseny.krasnov@kaspersky.com> <20210521075520.ghg75wpzz42zorxg@steredhat> <108b0bba-5909-cdde-97ee-321b3f5351ca@kaspersky.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, May 25, 2021 at 11:22:09AM +0300, Arseny Krasnov wrote: > >On 23.05.2021 15:14, Arseny Krasnov wrote: >> On 21.05.2021 10:55, Stefano Garzarella wrote: >>> Hi Arseny, >>> >>> On Thu, May 20, 2021 at 10:13:53PM +0300, Arseny Krasnov wrote: >>>> This patchset implements support of SOCK_SEQPACKET for virtio >>>> transport. >>> I'll carefully review and test this series next Monday, in the mean time >>> I think we should have at least an agreement about the changes that >>> regards virtio-spec before merge this series, to avoid any compatibility >>> issues. >>> >>> Do you plan to send a new version of the specification changes? >>> >>> Thanks, >>> Stefano >> Hello, sorry for long answer. I'm on vacation now, but i plan to send >> >> it in next several days, because with current implementation it is short >> >> >> Thank You > >Hello, here is spec patch: > >https://lists.oasis-open.org/archives/virtio-comment/202105/msg00017.html > >Let's discuss it Yep, sure. About this series I think is better to split in two series since it became very long. Patchwork [1] also complains here [2]. You can send a first series with patches from 1 to 7. These patches are reviewed by me and can go regardless of the discussion of the VIRTIO specifications. Maybe you can also add the patch with the test to this first series. Please specify in the cover letter that the implementation for virtio devices is under development and will be sent later. When it will be merged in the net-next tree, you can post the second part with the rest of the series that implements SEQPACKET for virtio devices, possibly after we received an agreement for the specifications. Please use the "net-next" tag and take a look at Documentation/networking/netdev-FAQ.rst about netdev development. Anyway, in the next days (hopefully tomorrow) I'll review the rest of the series related to virtio devices and spec. Thanks, Stefano [1] https://patchwork.kernel.org/project/netdevbpf/list/?series=486011&state=* [2] https://patchwork.kernel.org/project/netdevbpf/patch/20210520191449.1270723-1-arseny.krasnov@kaspersky.com/