kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH kvm-unit-tests] svm: remove bogus MSRPM test
@ 2021-06-11 14:54 Paolo Bonzini
  0 siblings, 0 replies; only message in thread
From: Paolo Bonzini @ 2021-06-11 14:54 UTC (permalink / raw)
  To: kvm; +Cc: Lara Lazier

The MSR permission bitmap is two pages long.  Therefore, the first test
in test_msrpm_iopm_bitmap_addrs should actually pass.  The problem is
that KVM tries to merge the L1 MSR permission bitmap with its own at
VMRUN time, fails to map the address of the L1 MSR permission bitmap,
and fails.

Thus remove the bogus test, which is failing on QEMU.

Reported-by: Lara Lazier <laramglazier@gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 x86/svm_tests.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/x86/svm_tests.c b/x86/svm_tests.c
index 8387bea..3937b80 100644
--- a/x86/svm_tests.c
+++ b/x86/svm_tests.c
@@ -2456,9 +2456,6 @@ static void test_msrpm_iopm_bitmap_addrs(void)
 	u64 addr_beyond_limit = 1ull << cpuid_maxphyaddr();
 	u64 addr = virt_to_phys(msr_bitmap) & (~((1ull << 12) - 1));
 
-	TEST_BITMAP_ADDR(saved_intercept, INTERCEPT_MSR_PROT,
-			addr_beyond_limit - 3 * PAGE_SIZE, SVM_EXIT_ERR,
-			"MSRPM");
 	TEST_BITMAP_ADDR(saved_intercept, INTERCEPT_MSR_PROT,
 			addr_beyond_limit - 2 * PAGE_SIZE, SVM_EXIT_ERR,
 			"MSRPM");
-- 
2.31.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2021-06-11 14:54 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-11 14:54 [PATCH kvm-unit-tests] svm: remove bogus MSRPM test Paolo Bonzini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).