From: Yishai Hadas <yishaih@nvidia.com>
To: <bhelgaas@google.com>, <corbet@lwn.net>,
<alex.williamson@redhat.com>, <diana.craciun@oss.nxp.com>,
<kwankhede@nvidia.com>, <eric.auger@redhat.com>,
<masahiroy@kernel.org>, <michal.lkml@markovi.net>
Cc: <linux-pci@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<kvm@vger.kernel.org>, <linux-s390@vger.kernel.org>,
<linux-kbuild@vger.kernel.org>, <mgurtovoy@nvidia.com>,
<jgg@nvidia.com>, <yishaih@nvidia.com>, <maorg@nvidia.com>,
<leonro@nvidia.com>
Subject: [PATCH 00/12] Introduce vfio_pci_core subsystem
Date: Wed, 21 Jul 2021 19:15:57 +0300 [thread overview]
Message-ID: <20210721161609.68223-1-yishaih@nvidia.com> (raw)
Prologue:
This is the second series of three to send the "mlx5_vfio_pci" driver
that has been discussed on the list for a while now. It comes on top of
the first series (i.e. Reorganize reflck to support splitting vfio_pci)
that was sent already and pending merge [1].
- Split vfio_pci into vfio_pci/vfio_pci_core and provide infrastructure
for non-generic VFIO PCI drivers.
- The new driver mlx5_vfio_pci that is a full implementation of
suspend/resume functionality for mlx5 devices.
A preview of all the patches can be seen here:
https://github.com/jgunthorpe/linux/commits/mlx5_vfio_pci
[1] https://lore.kernel.org/dri-devel/0-v2-b6a5582525c9+ff96-vfio_reflck_jgg@nvidia.com/T/#t
=====================
From Max Gurtovoy:
====================
This series splits the vfio_pci driver into two parts, a PCI driver and
a subsystem driver that will also be library of code. The main PCI
driver, vfio_pci.ko, will remain as before and it will use the library
module vfio_pci_core.ko to help create the vfio_device.
This series is intended to solve the issues that were raised in the
previous attempts for extending vfio-pci for device specific
functionality:
1. https://lore.kernel.org/kvm/20200518024202.13996-1-yan.y.zhao@intel.com
by Yan Zhao
2. https://lore.kernel.org/kvm/20210702095849.1610-1-shameerali.kolothum.thodi@huawei.com
by Longfang Liu
Also to support proposed future changes to virtio and other common
protocols to support migration:
https://lists.oasis-open.org/archives/virtio-comment/202106/msg00044.html
This subsystem framework will also ease adding new device specific
functionality to VFIO devices in the future by allowing another module
to provide the pci_driver that can setup a number of details before
registering to the VFIO subsystem, such as injecting its own operations.
This series also extends the "driver_override" mechanism. A flag is
added for PCI drivers that will declare themselves as "driver_override"
capable which sends their match table to the modules.alias file but
otherwise leaves them outside of the normal driver core auto-binding
world, like vfio_pci.
In order to get the best match for "driver_override" drivers, one can
create a userspace program to inspect the modules.alias, an example can
be found at:
https://github.com/maxgurtovoy/linux_tools/blob/main/vfio/bind_vfio_pci_driver.py
Which finds the 'best match' according to a simple algorithm: "the
driver with the fewest '*' matches wins."
For example, the vfio-pci driver will match to any pci device. So it
will have the maximal '*' matches.
In case we are looking for a match to a mlx5 based device, we'll have a
match to vfio-pci.ko and mlx5-vfio-pci.ko. We'll prefer mlx5-vfio-pci.ko
since it will have less '*' matches (probably vendor and device IDs will
match). This will work in the future for NVMe/Virtio devices that can
match according to a class code or other criteria.
Yishai
Jason Gunthorpe (2):
vfio: Use select for eventfd
vfio: Use kconfig if XX/endif blocks instead of repeating 'depends on'
Max Gurtovoy (9):
vfio/pci: Rename vfio_pci.c to vfio_pci_core.c
vfio/pci: Rename vfio_pci_private.h to vfio_pci_core.h
vfio/pci: Rename vfio_pci_device to vfio_pci_core_device
vfio/pci: Rename ops functions to fit core namings
vfio/pci: Include vfio header in vfio_pci_core.h
vfio/pci: Split the pci_driver code out of vfio_pci_core.c
vfio/pci: Move igd initialization to vfio_pci.c
PCI: Add a PCI_ID_F_VFIO_DRIVER_OVERRIDE flag to struct pci_device_id
vfio/pci: Introduce vfio_pci_core.ko
Yishai Hadas (1):
vfio/pci: Move module parameters to vfio_pci.c
Documentation/PCI/pci.rst | 1 +
drivers/pci/pci-driver.c | 25 +-
drivers/vfio/Kconfig | 29 +-
drivers/vfio/fsl-mc/Kconfig | 3 +-
drivers/vfio/mdev/Kconfig | 1 -
drivers/vfio/pci/Kconfig | 39 +-
drivers/vfio/pci/Makefile | 8 +-
drivers/vfio/pci/vfio_pci.c | 2238 +----------------
drivers/vfio/pci/vfio_pci_config.c | 70 +-
drivers/vfio/pci/vfio_pci_core.c | 2138 ++++++++++++++++
drivers/vfio/pci/vfio_pci_igd.c | 19 +-
drivers/vfio/pci/vfio_pci_intrs.c | 42 +-
drivers/vfio/pci/vfio_pci_rdwr.c | 18 +-
drivers/vfio/pci/vfio_pci_zdev.c | 4 +-
drivers/vfio/platform/Kconfig | 6 +-
drivers/vfio/platform/reset/Kconfig | 4 +-
include/linux/mod_devicetable.h | 7 +
include/linux/pci.h | 27 +
.../linux/vfio_pci_core.h | 89 +-
scripts/mod/devicetable-offsets.c | 1 +
scripts/mod/file2alias.c | 8 +-
21 files changed, 2496 insertions(+), 2281 deletions(-)
create mode 100644 drivers/vfio/pci/vfio_pci_core.c
rename drivers/vfio/pci/vfio_pci_private.h => include/linux/vfio_pci_core.h (56%)
--
2.18.1
next reply other threads:[~2021-07-21 16:17 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 16:15 Yishai Hadas [this message]
2021-07-21 16:15 ` [PATCH 01/12] vfio/pci: Rename vfio_pci.c to vfio_pci_core.c Yishai Hadas
2021-07-21 16:15 ` [PATCH 02/12] vfio/pci: Rename vfio_pci_private.h to vfio_pci_core.h Yishai Hadas
2021-07-21 16:16 ` [PATCH 03/12] vfio/pci: Rename vfio_pci_device to vfio_pci_core_device Yishai Hadas
2021-07-21 16:16 ` [PATCH 04/12] vfio/pci: Rename ops functions to fit core namings Yishai Hadas
2021-07-21 16:16 ` [PATCH 05/12] vfio/pci: Include vfio header in vfio_pci_core.h Yishai Hadas
2021-07-21 16:16 ` [PATCH 06/12] vfio/pci: Split the pci_driver code out of vfio_pci_core.c Yishai Hadas
2021-07-21 16:16 ` [PATCH 07/12] vfio/pci: Move igd initialization to vfio_pci.c Yishai Hadas
2021-07-21 16:16 ` [PATCH 08/12] vfio/pci: Move module parameters " Yishai Hadas
2021-07-21 16:16 ` [PATCH 09/12] PCI: Add a PCI_ID_F_VFIO_DRIVER_OVERRIDE flag to struct pci_device_id Yishai Hadas
2021-07-27 16:34 ` Alex Williamson
2021-07-27 17:14 ` Jason Gunthorpe
2021-07-27 23:02 ` Alex Williamson
2021-07-27 23:42 ` Jason Gunthorpe
2021-08-04 20:34 ` Bjorn Helgaas
2021-08-05 16:47 ` Max Gurtovoy
2021-08-06 0:23 ` Jason Gunthorpe
2021-08-11 12:22 ` Max Gurtovoy
2021-08-11 19:07 ` Bjorn Helgaas
2021-08-12 13:27 ` Jason Gunthorpe
2021-08-12 15:57 ` Bjorn Helgaas
2021-08-12 19:51 ` Jason Gunthorpe
2021-08-12 20:26 ` Bjorn Helgaas
2021-08-12 23:21 ` Max Gurtovoy
2021-08-13 17:44 ` Bjorn Helgaas
2021-08-14 23:27 ` Max Gurtovoy
2021-08-16 17:21 ` Bjorn Helgaas
2021-08-17 13:01 ` Max Gurtovoy
2021-08-17 14:13 ` Bjorn Helgaas
2021-08-17 14:44 ` Max Gurtovoy
2021-08-12 15:42 ` Bjorn Helgaas
2021-07-21 16:16 ` [PATCH 10/12] vfio: Use select for eventfd Yishai Hadas
2021-07-21 16:16 ` [PATCH 11/12] vfio: Use kconfig if XX/endif blocks instead of repeating 'depends on' Yishai Hadas
2021-07-21 16:16 ` [PATCH 12/12] vfio/pci: Introduce vfio_pci_core.ko Yishai Hadas
2021-07-21 17:39 ` Leon Romanovsky
2021-07-22 9:06 ` Yishai Hadas
2021-07-22 9:22 ` Max Gurtovoy
2021-07-23 14:13 ` Leon Romanovsky
2021-07-25 10:45 ` Max Gurtovoy
2021-07-27 21:54 ` Alex Williamson
2021-07-27 23:09 ` Jason Gunthorpe
2021-07-28 4:56 ` Leon Romanovsky
2021-07-28 5:43 ` Christoph Hellwig
2021-07-28 7:04 ` Arnd Bergmann
2021-07-28 7:17 ` Leon Romanovsky
2021-07-28 12:03 ` Jason Gunthorpe
2021-07-28 12:12 ` Arnd Bergmann
2021-07-28 12:29 ` Christoph Hellwig
2021-07-28 12:47 ` Jason Gunthorpe
2021-07-28 12:55 ` Christoph Hellwig
2021-07-28 13:31 ` Jason Gunthorpe
2021-07-28 13:08 ` Arnd Bergmann
2021-07-28 17:26 ` Jason Gunthorpe
2021-08-04 13:41 ` [PATCH 00/12] Introduce vfio_pci_core subsystem Yishai Hadas
2021-08-04 15:27 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210721161609.68223-1-yishaih@nvidia.com \
--to=yishaih@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=diana.craciun@oss.nxp.com \
--cc=eric.auger@redhat.com \
--cc=jgg@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=maorg@nvidia.com \
--cc=masahiroy@kernel.org \
--cc=mgurtovoy@nvidia.com \
--cc=michal.lkml@markovi.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).