From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5C84C432BE for ; Tue, 27 Jul 2021 09:58:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 961F8613B3 for ; Tue, 27 Jul 2021 09:58:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236188AbhG0J6J (ORCPT ); Tue, 27 Jul 2021 05:58:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:33748 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236106AbhG0J6J (ORCPT ); Tue, 27 Jul 2021 05:58:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627379889; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T2rQBG2yVNE7y1+uB+3b6lsmKXViZKQecoiM/1czVBA=; b=Mg426BPKHiEYYUn6qqnuG/nyDQOJYDyb/m0yJ9SCdyQyFrbVZWvK4O6C/8bSJhPF8gZO/G nHTn3GoCk0wG5MwAUysIh/DFJIaZ8gCsE5dqdeDmNjZZCdFR3ji7i6ztzV/5lJqDNCOs8v zS+PIf3+QKLIzPjTx95po+Z97nyJyb8= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-81-yAmY8BCPPreayAGH6owhag-1; Tue, 27 Jul 2021 05:58:07 -0400 X-MC-Unique: yAmY8BCPPreayAGH6owhag-1 Received: by mail-ed1-f70.google.com with SMTP id b13-20020a056402278db029039c013d5b80so6342026ede.7 for ; Tue, 27 Jul 2021 02:58:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=T2rQBG2yVNE7y1+uB+3b6lsmKXViZKQecoiM/1czVBA=; b=igiR8KBjvueDr7tnMeyo0+xYEFut2PrPVNokaOeO6iINYjFLWMDkXN3mSdfeZFgnxp B7+ZnroaEuI9BxED966rGl60/mZc0unkZCoHYSe6NgwmYB2/4S3c0V7hkxJ8DqaQ2jbf 5liC+Q3YhZ/FC+taNtZHwWYdbRz0VQwaMvRaLp3ARizhy1yZNBSkqgZNaLVKTLFwVnAB PHie7+K6yqwzprFLACysdwpuo7fsekJmDRur9fVR9jTX1la2Vwxg+QELzvF6byEpXJV5 O87ZBMWeevIsuTXS29XElEjlaMyCn6p5bSUI8ijj/Ot4ycVNBQkXtcSDMyj1MXG+bpA9 GvYg== X-Gm-Message-State: AOAM533pq1Qm7yb5VRFsbLTHrwP/Xp1i3S9s1oV0FiaNXZUWUpRdB9+/ OEnLFlhxmG2msWLNYhE1fp6Lec071bhgnxqqyfCPTZRs1vy6ZtdYOufllv99oHx23b8cJIDMNkK XH7Uc79CurTQI X-Received: by 2002:a17:906:ce47:: with SMTP id se7mr3742424ejb.240.1627379886418; Tue, 27 Jul 2021 02:58:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx8eyrbNlN1DVbEoRIS2U/HCt0SR/iGRuCNgiSKmvCYAIQaFF1wZB5TRpL7dxgdXFiMYR9Wkg== X-Received: by 2002:a17:906:ce47:: with SMTP id se7mr3742409ejb.240.1627379886242; Tue, 27 Jul 2021 02:58:06 -0700 (PDT) Received: from steredhat (host-79-18-148-79.retail.telecomitalia.it. [79.18.148.79]) by smtp.gmail.com with ESMTPSA id f18sm726664ejx.23.2021.07.27.02.58.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jul 2021 02:58:05 -0700 (PDT) Date: Tue, 27 Jul 2021 11:58:03 +0200 From: Stefano Garzarella To: Arseny Krasnov Cc: Stefan Hajnoczi , "Michael S. Tsirkin" , Jason Wang , "David S. Miller" , Jakub Kicinski , Colin Ian King , Andra Paraschiv , Norbert Slusarek , "kvm@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "oxffffaa@gmail.com" Subject: Re: [MASSMAIL KLMS] Re: [RFC PATCH v1 0/7] virtio/vsock: introduce MSG_EOR flag for SEQPACKET Message-ID: <20210727095803.s26subp3pgclqzvi@steredhat> References: <20210726163137.2589102-1-arseny.krasnov@kaspersky.com> <20210727075948.yl4w3foqa6rp4obg@steredhat> <2df68589-96b9-abd4-ad1c-e25918b908a9@kaspersky.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <2df68589-96b9-abd4-ad1c-e25918b908a9@kaspersky.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Jul 27, 2021 at 12:34:36PM +0300, Arseny Krasnov wrote: > >On 27.07.2021 10:59, Stefano Garzarella wrote: >> Caution: This is an external email. Be cautious while opening links or attachments. >> >> >> >> On Mon, Jul 26, 2021 at 07:31:33PM +0300, Arseny Krasnov wrote: >>> This patchset implements support of MSG_EOR bit for SEQPACKET >>> AF_VSOCK sockets over virtio transport. >>> Idea is to distinguish concepts of 'messages' and 'records'. >>> Message is result of sending calls: 'write()', 'send()', 'sendmsg()' >>> etc. It has fixed maximum length, and it bounds are visible using >>> return from receive calls: 'read()', 'recv()', 'recvmsg()' etc. >>> Current implementation based on message definition above. >>> Record has unlimited length, it consists of multiple message, >>> and bounds of record are visible via MSG_EOR flag returned from >>> 'recvmsg()' call. Sender passes MSG_EOR to sending system call and >>> receiver will see MSG_EOR when corresponding message will be processed. >>> To support MSG_EOR new bit was added along with existing >>> 'VIRTIO_VSOCK_SEQ_EOR': 'VIRTIO_VSOCK_SEQ_EOM'(end-of-message) - now it >>> works in the same way as 'VIRTIO_VSOCK_SEQ_EOR'. But 'VIRTIO_VSOCK_SEQ_EOR' >>> is used to mark 'MSG_EOR' bit passed from userspace. >> At this point it's probably better to rename the old flag, so we stay >> compatible. >> >> What happens if one of the two peers does not support MSG_EOR handling, >> while the other does? >> >> I'll do a closer review in the next few days. >Thank You, also i think MSG_EOR support must be described in spec Yep, sure! What do you think about the concerns above? Stefano