From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D85F6C4320E for ; Wed, 28 Jul 2021 12:55:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BED2660FE7 for ; Wed, 28 Jul 2021 12:55:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235942AbhG1MzQ (ORCPT ); Wed, 28 Jul 2021 08:55:16 -0400 Received: from verein.lst.de ([213.95.11.211]:53593 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235098AbhG1MzP (ORCPT ); Wed, 28 Jul 2021 08:55:15 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 2C6AD68AFE; Wed, 28 Jul 2021 14:55:07 +0200 (CEST) Date: Wed, 28 Jul 2021 14:55:05 +0200 From: Christoph Hellwig To: Jason Gunthorpe Cc: Christoph Hellwig , Alex Williamson , Arnd Bergmann , Yishai Hadas , bhelgaas@google.com, corbet@lwn.net, diana.craciun@oss.nxp.com, kwankhede@nvidia.com, eric.auger@redhat.com, masahiroy@kernel.org, michal.lkml@markovi.net, linux-pci@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kbuild@vger.kernel.org, mgurtovoy@nvidia.com, maorg@nvidia.com, leonro@nvidia.com Subject: Re: [PATCH 12/12] vfio/pci: Introduce vfio_pci_core.ko Message-ID: <20210728125505.GA29082@lst.de> References: <20210721161609.68223-1-yishaih@nvidia.com> <20210721161609.68223-13-yishaih@nvidia.com> <20210727155440.680ee22e.alex.williamson@redhat.com> <20210727230941.GL1721383@nvidia.com> <20210728054306.GA3421@lst.de> <20210728120326.GQ1721383@nvidia.com> <20210728122956.GA27111@lst.de> <20210728124755.GR1721383@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210728124755.GR1721383@nvidia.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Jul 28, 2021 at 09:47:55AM -0300, Jason Gunthorpe wrote: > So then we can write it like below? > +if PCI || MMU The || here should be &&. But otherwise, yes. > Unfortunately it deletes the nice > menu structure that groups all the PCI drivers together like platform > (and mdev in future). Not sure this loss is worth the backwards compat All the ther visible options should depend on VFIO_PCI not VFIO_PCI_CORE. So we can still keep the same menu struture.