From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36A3FC4338F for ; Fri, 6 Aug 2021 07:19:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1664461186 for ; Fri, 6 Aug 2021 07:19:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243567AbhHFHTX (ORCPT ); Fri, 6 Aug 2021 03:19:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:55746 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243584AbhHFHTS (ORCPT ); Fri, 6 Aug 2021 03:19:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628234342; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Y3mKwkaoUVrfQ+lC5tkgN91edlf3gr8pvb0ti7ZT+lk=; b=ea+3BASv/yl5fT0y35R0yF6ZkdXj1lFlyhCSbu7jo2j59UNHG2RdICL61MP0P58UJ8HMEV 5ceNXcJCZvLdhetCkICqU3i7/nJfkFAe8Ij+ecSW3DH/5wYNU6Y6/H+14STvpj+6gRdhaM fMjWfR4I7r7lSbf3QGbD7/qfjRURmh4= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-268-YofFB73aPfmAaxWTzFHjVg-1; Fri, 06 Aug 2021 03:19:01 -0400 X-MC-Unique: YofFB73aPfmAaxWTzFHjVg-1 Received: by mail-ed1-f71.google.com with SMTP id a23-20020a50ff170000b02903b85a16b672so4461766edu.1 for ; Fri, 06 Aug 2021 00:19:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Y3mKwkaoUVrfQ+lC5tkgN91edlf3gr8pvb0ti7ZT+lk=; b=nVDVPj+3xXqaVZRpwQtTry6tfR6wH8TGKBBY5PYfC6tQB5/nx2F+H+BWstTdXNOckv VYQO0n1oRaKghqU2HwrOa0ESpainV3bpQHXGGt8JN/krkY8P66o9w4n8Cf8mURUSHl5s tvwGVU8ImOuhrqaPkORp2/jsnJXn3Jblm7vM7YIyGBwf5DyrXFL5iK5x96JT50KGLg2C Ws4xRc5tV/oBY8IAiZ8JMa2rlO4il7PkHpuYgibf51UcuNIDUk5II2m0uzst0rdfMVgH h1pBvEz019VhW8LIaXFIv10AwC4fjWCQsL18h8SWZhYFNqtwxBWEozleeTIbj0acc4Bw zugQ== X-Gm-Message-State: AOAM533uu/Jd45XZ/lrrW0bdnRr/0VZUBDZ2rrarZJwtv4XDmwOOi99F KiilugvYycehA+VXP8LWukeiJfWXZR+jmNmkQVkbQ4J6NS1rldgL828Jupzkxhec0NxscPec23U XlXvsXicHHH6O X-Received: by 2002:a17:906:1c81:: with SMTP id g1mr8634577ejh.361.1628234339945; Fri, 06 Aug 2021 00:18:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx6JY7p7UFxuDeInSSMYr1fMOjaIuzdqeeTRahm0VW7d3WQBlqeSCHdg1JEhMKVsqgo8q29Yw== X-Received: by 2002:a17:906:1c81:: with SMTP id g1mr8634556ejh.361.1628234339817; Fri, 06 Aug 2021 00:18:59 -0700 (PDT) Received: from steredhat (host-79-18-148-79.retail.telecomitalia.it. [79.18.148.79]) by smtp.gmail.com with ESMTPSA id g9sm3459573edl.52.2021.08.06.00.18.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Aug 2021 00:18:59 -0700 (PDT) Date: Fri, 6 Aug 2021 09:18:57 +0200 From: Stefano Garzarella To: Arseny Krasnov Cc: Stefan Hajnoczi , "Michael S. Tsirkin" , Jason Wang , "David S. Miller" , Jakub Kicinski , Jorgen Hansen , Andra Paraschiv , Norbert Slusarek , Colin Ian King , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, oxffffaa@gmail.com Subject: Re: [RFC PATCH v1 1/7] virtio/vsock: add 'VIRTIO_VSOCK_SEQ_EOM' bit Message-ID: <20210806071857.h4zneiblcf5tathq@steredhat> References: <20210726163137.2589102-1-arseny.krasnov@kaspersky.com> <20210726163307.2589516-1-arseny.krasnov@kaspersky.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20210726163307.2589516-1-arseny.krasnov@kaspersky.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Jul 26, 2021 at 07:33:04PM +0300, Arseny Krasnov wrote: >This bit is used to mark end of messages('EOM' - end of message), while >'VIRIO_VSOCK_SEQ_EOR' is used to pass MSG_EOR. > >Signed-off-by: Arseny Krasnov >--- > include/uapi/linux/virtio_vsock.h | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/include/uapi/linux/virtio_vsock.h b/include/uapi/linux/virtio_vsock.h >index 3dd3555b2740..1de3211a2988 100644 >--- a/include/uapi/linux/virtio_vsock.h >+++ b/include/uapi/linux/virtio_vsock.h >@@ -98,6 +98,7 @@ enum virtio_vsock_shutdown { > /* VIRTIO_VSOCK_OP_RW flags values */ > enum virtio_vsock_rw { > VIRTIO_VSOCK_SEQ_EOR = 1, >+ VIRTIO_VSOCK_SEQ_EOM = 2, > }; Already said, but I'll repeat it for completeness. It's better to rename the flag 1 and use it in the same way we did before, so it's backward compatible. Obviously we have to update the specifications too, explaining the difference between the two :-) Thanks, Stefano