From: Janosch Frank <frankja@linux.ibm.com>
To: pbonzini@redhat.com
Cc: kvm@vger.kernel.org, frankja@linux.ibm.com, david@redhat.com,
borntraeger@de.ibm.com, cohuck@redhat.com,
linux-s390@vger.kernel.org, imbrenda@linux.ibm.com,
thuth@redhat.com
Subject: [kvm-unit-tests GIT PULL 04/11] s390x: sie: Add sie lib validity handling
Date: Mon, 16 Aug 2021 15:20:47 +0200 [thread overview]
Message-ID: <20210816132054.60078-5-frankja@linux.ibm.com> (raw)
In-Reply-To: <20210816132054.60078-1-frankja@linux.ibm.com>
Let's start off the SIE lib with validity handling code since that has
the least amount of dependencies to other files.
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
---
lib/s390x/sie.c | 40 ++++++++++++++++++++++++++++++++++++++++
lib/s390x/sie.h | 3 +++
s390x/Makefile | 1 +
s390x/mvpg-sie.c | 2 +-
s390x/sie.c | 7 +------
5 files changed, 46 insertions(+), 7 deletions(-)
create mode 100644 lib/s390x/sie.c
diff --git a/lib/s390x/sie.c b/lib/s390x/sie.c
new file mode 100644
index 00000000..15ba407c
--- /dev/null
+++ b/lib/s390x/sie.c
@@ -0,0 +1,40 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * Virtualization library that speeds up managing guests.
+ *
+ * Copyright (c) 2021 IBM Corp
+ *
+ * Authors:
+ * Janosch Frank <frankja@linux.ibm.com>
+ */
+
+#include <asm/barrier.h>
+#include <libcflat.h>
+#include <sie.h>
+
+static bool validity_expected;
+static uint16_t vir; /* Validity interception reason */
+
+void sie_expect_validity(void)
+{
+ validity_expected = true;
+ vir = 0;
+}
+
+void sie_check_validity(uint16_t vir_exp)
+{
+ report(vir_exp == vir, "VALIDITY: %x", vir);
+ vir = 0;
+}
+
+void sie_handle_validity(struct vm *vm)
+{
+ if (vm->sblk->icptcode != ICPT_VALIDITY)
+ return;
+
+ vir = vm->sblk->ipb >> 16;
+
+ if (!validity_expected)
+ report_abort("VALIDITY: %x", vir);
+ validity_expected = false;
+}
diff --git a/lib/s390x/sie.h b/lib/s390x/sie.h
index 6ba858a2..7ff98d2d 100644
--- a/lib/s390x/sie.h
+++ b/lib/s390x/sie.h
@@ -197,5 +197,8 @@ struct vm {
extern void sie_entry(void);
extern void sie_exit(void);
extern void sie64a(struct kvm_s390_sie_block *sblk, struct vm_save_area *save_area);
+void sie_expect_validity(void);
+void sie_check_validity(uint16_t vir_exp);
+void sie_handle_validity(struct vm *vm);
#endif /* _S390X_SIE_H_ */
diff --git a/s390x/Makefile b/s390x/Makefile
index 6565561b..ef8041a6 100644
--- a/s390x/Makefile
+++ b/s390x/Makefile
@@ -71,6 +71,7 @@ cflatobjs += lib/s390x/css_dump.o
cflatobjs += lib/s390x/css_lib.o
cflatobjs += lib/s390x/malloc_io.o
cflatobjs += lib/s390x/uv.o
+cflatobjs += lib/s390x/sie.o
OBJDIRS += lib/s390x
diff --git a/s390x/mvpg-sie.c b/s390x/mvpg-sie.c
index 5e70f591..2ac91eec 100644
--- a/s390x/mvpg-sie.c
+++ b/s390x/mvpg-sie.c
@@ -39,7 +39,7 @@ static void sie(struct vm *vm)
while (vm->sblk->icptcode == 0) {
sie64a(vm->sblk, &vm->save_area);
- assert(vm->sblk->icptcode != ICPT_VALIDITY);
+ sie_handle_validity(vm);
}
vm->save_area.guest.grs[14] = vm->sblk->gg14;
vm->save_area.guest.grs[15] = vm->sblk->gg15;
diff --git a/s390x/sie.c b/s390x/sie.c
index 134d3c4f..5c798a9e 100644
--- a/s390x/sie.c
+++ b/s390x/sie.c
@@ -24,17 +24,12 @@ static u8 *guest;
static u8 *guest_instr;
static struct vm vm;
-static void handle_validity(struct vm *vm)
-{
- report(0, "VALIDITY: %x", vm->sblk->ipb >> 16);
-}
static void sie(struct vm *vm)
{
while (vm->sblk->icptcode == 0) {
sie64a(vm->sblk, &vm->save_area);
- if (vm->sblk->icptcode == ICPT_VALIDITY)
- handle_validity(vm);
+ sie_handle_validity(vm);
}
vm->save_area.guest.grs[14] = vm->sblk->gg14;
vm->save_area.guest.grs[15] = vm->sblk->gg15;
--
2.31.1
next prev parent reply other threads:[~2021-08-16 13:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 13:20 [kvm-unit-tests GIT PULL 00/11] s390x update 2021-16-08 Janosch Frank
2021-08-16 13:20 ` [kvm-unit-tests GIT PULL 01/11] s390x: Add SPDX and header comments for s390x/* and lib/s390x/* Janosch Frank
2021-08-16 13:20 ` [kvm-unit-tests GIT PULL 02/11] s390x: Add SPDX and header comments for the snippets folder Janosch Frank
2021-08-16 13:20 ` [kvm-unit-tests GIT PULL 03/11] s390x: Fix my mail address in the headers Janosch Frank
2021-08-16 13:20 ` Janosch Frank [this message]
2021-08-16 13:20 ` [kvm-unit-tests GIT PULL 05/11] s390x: lib: Introduce HPAGE_* constants Janosch Frank
2021-08-16 13:20 ` [kvm-unit-tests GIT PULL 06/11] s390x: lib: sie: Add struct vm (de)initialization functions Janosch Frank
2021-08-16 13:20 ` [kvm-unit-tests GIT PULL 07/11] lib: s390x: sie: Move sie function into library Janosch Frank
2021-08-16 13:20 ` [kvm-unit-tests GIT PULL 08/11] s390x: lib: Simplify stsi_get_fc and move it to library Janosch Frank
2021-08-16 13:20 ` [kvm-unit-tests GIT PULL 09/11] lib: s390x: Add 0x3d, 0x3e and 0x3f PGM constants Janosch Frank
2021-08-16 13:20 ` [kvm-unit-tests GIT PULL 10/11] lib: s390x: uv: Add rc 0x100 query error handling Janosch Frank
2021-08-16 13:20 ` [kvm-unit-tests GIT PULL 11/11] lib: s390x: Add PSW_MASK_64 Janosch Frank
2021-08-16 16:25 ` [kvm-unit-tests GIT PULL 00/11] s390x update 2021-16-08 Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210816132054.60078-5-frankja@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).