From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25A57C432BE for ; Thu, 19 Aug 2021 22:19:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0BB1E60FDA for ; Thu, 19 Aug 2021 22:19:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235679AbhHSWT7 (ORCPT ); Thu, 19 Aug 2021 18:19:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:54144 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235805AbhHSWT5 (ORCPT ); Thu, 19 Aug 2021 18:19:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629411559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EbhZJqeN1nM9qIrKQm6mxxNUIRdgxznhenqwUNNt6uM=; b=IYbl6FGEUZN0CgLVj9Q2tvLRbGaTSkfWW7aWXdzMpbxEjVSn0IICuA7XXu0Bne07oXpzPh VSst/rxjWvyvNTio0TBnQP8yjzEu2mQ5/0i+Szj4QILHcMXVPJywAqvgq84YGJ62L2uYkj FEsX4gUUJSfLC0WbeSUsxhV5JBOYNPs= Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-222-tyvhZXe6NR-ANRcrxTYtKg-1; Thu, 19 Aug 2021 18:19:17 -0400 X-MC-Unique: tyvhZXe6NR-ANRcrxTYtKg-1 Received: by mail-ot1-f69.google.com with SMTP id q5-20020a9d65450000b0290510db97edd8so3504710otl.8 for ; Thu, 19 Aug 2021 15:19:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EbhZJqeN1nM9qIrKQm6mxxNUIRdgxznhenqwUNNt6uM=; b=HwTy3UxNoL4BlJ3XjAFsE1M+yFXslJqIFWBgsrZDfraSDRtZxBwY+t7YwgIfR/lYoY mDP2HjY04LdaWcHFDEAofzp5nsuF8JQR3lmZ31Gmwntx0EE0u1+9DykzvxDokuyS3xvQ e/ifolFO1dRpzr+0IW96j6c2OGs5H7HinqNXD9elRwUSaORmcsjPg21DGKjxq5TG8JtM x/nWfsARP14kqO/KVPKFzZV+gvgoxAWkknAKZIIuvJuf6kTnxvi9fjk7pQNfzqD55iTU LL2ulKPLSvZEifPHxJohhHBza1hAU6bVEz0CYAzOFGxmMEQz99qaimbE8CDDQAMxHc/9 BFxQ== X-Gm-Message-State: AOAM533+tott63a5efnqx5Tq6BZ4u1uOwcLm1mCJJjsLE7hQZTvLP0Hj EbtjmlzgtQgFP3mqlTf+8F7l0NfYXRj+NdHKtkIq1Z4gIu3K3JOCnI2Tk/iyJncLhNdKR5j2OgT neSszQQgxmkKh X-Received: by 2002:a4a:a552:: with SMTP id s18mr13338725oom.1.1629411556752; Thu, 19 Aug 2021 15:19:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzX5rfq5sQLsDwtph+vjRR0C26I9lgF4XK9hL1qrYyyg0cWYI/hPwJPKxCIkfjVts0o9JG5Kg== X-Received: by 2002:a4a:a552:: with SMTP id s18mr13338701oom.1.1629411556534; Thu, 19 Aug 2021 15:19:16 -0700 (PDT) Received: from redhat.com ([198.99.80.109]) by smtp.gmail.com with ESMTPSA id z25sm942600oic.24.2021.08.19.15.19.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Aug 2021 15:19:16 -0700 (PDT) Date: Thu, 19 Aug 2021 16:19:14 -0600 From: Alex Williamson To: Max Gurtovoy Cc: Bjorn Helgaas , Yishai Hadas , , , , , , , , , , , , , , , Subject: Re: [PATCH V2 09/12] PCI: Add 'override_only' bitmap to struct pci_device_id Message-ID: <20210819161914.7ad2e80e.alex.williamson@redhat.com> In-Reply-To: References: <20210819163945.GA3211852@bjorn-Precision-5520> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, 19 Aug 2021 22:57:30 +0300 Max Gurtovoy wrote: > On 8/19/2021 7:39 PM, Bjorn Helgaas wrote: > > On Thu, Aug 19, 2021 at 07:16:20PM +0300, Yishai Hadas wrote: > >> On 8/19/2021 6:15 PM, Bjorn Helgaas wrote: > >>> On Wed, Aug 18, 2021 at 06:16:03PM +0300, Yishai Hadas wrote: > >>>> From: Max Gurtovoy > >>>> /** > >>>> * struct pci_device_id - PCI device ID structure > >>>> * @vendor: Vendor ID to match (or PCI_ANY_ID) > >>>> @@ -34,12 +38,14 @@ typedef unsigned long kernel_ulong_t; > >>>> * Best practice is to use driver_data as an index > >>>> * into a static list of equivalent device types, > >>>> * instead of using it as a pointer. > >>>> + * @override_only: Bitmap for override_only PCI drivers. > >>> "Match only when dev->driver_override is this driver"? > >> Just to be aligned here, > >> > >> This field will stay __u32 and may hold at the most 1 bit value set to > >> represent the actual subsystem/driver. > > The PCI core does not require "at most 1 bit is set." > > > > Actually, I don't think even the file2alias code requires that. If > > you set two bits, you can generate two aliases. > > > >> This is required to later on set the correct prefix in the modules.alias > >> file, and you just suggested to change the comment as of above, right ? > > Yes, __u32 is fine and I'm only suggesting a comment change here. > > great. > > > > > >>> As far as PCI core is concerned there's no need for this to be a > >>> bitmap. > >>> > >>> I think this would make more sense if split into two patches. The > >>> first would add override_only and change pci_match_device(). Then > >>> there's no confusion about whether this is specific to VFIO. > >> Splitting may end-up the first patch with a dead-code on below, as > >> found_id->override_only will be always 0. > >> > >> If you still believe that this is better we can do it. > > I think it's fine to add the functionality in one patch and use it in > > the next if it makes the commit clearer. I wouldn't want to add > > functionality that's not used at all in the series, but it's OK when > > they're both posted together. > > Ok. We can do the separation if all agree that the first commit is have > a dead section. > > Alex, > > we would like to get few more reviewed-by signatures and we'll send the > V3 series in a couple of days to make it to 5.15 merge window as we planned. > > Are you ok with the series after we got the green light for this patch ? > > do you think we need another pair of eyes to review the other patches ? More eyes is always better, but I'm not finding much to complain about in this series. This patch was probably the most pivotal for agreement, the rest is largely mechanical at this point. In addition to Bjorn for the PCI parts of this, I'd also like to see an ack from Yamada-san or Michal for scripts/mod/, who are already cc'd I also notice include/linux/vfio_pci_core.h doesn't get added to MAINTAINERS in the series. Please fix in patch 12/ It seems plausible that this could be ready for v5.15. Thanks, Alex