From: Jason Gunthorpe <jgg@ziepe.ca>
To: Christoph Hellwig <hch@lst.de>
Cc: Alex Williamson <alex.williamson@redhat.com>,
Diana Craciun <diana.craciun@oss.nxp.com>,
Cornelia Huck <cohuck@redhat.com>,
Kirti Wankhede <kwankhede@nvidia.com>,
Eric Auger <eric.auger@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH 13/14] vfio/iommu_type1: remove the "external" domain
Date: Tue, 24 Aug 2021 21:36:29 -0300 [thread overview]
Message-ID: <20210825003629.GT543798@ziepe.ca> (raw)
In-Reply-To: <20210824144649.1488190-14-hch@lst.de>
On Tue, Aug 24, 2021 at 04:46:48PM +0200, Christoph Hellwig wrote:
> The external_domain concept rather misleading and not actually needed.
> Replace it with a list of mediated groups in struct vfio_iommu and
> document the purpose.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/vfio/vfio_iommu_type1.c | 123 +++++++++++++++-----------------
> 1 file changed, 57 insertions(+), 66 deletions(-)
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> + /*
> + * Tracks the fake iommu groups created by vfio to support mediated
> + * devices. These are not backed by an actual IOMMU.
> + */
> + struct list_head mediated_groups;
Though again I'd prefer another name to mediated here.. These are
domainless groups?
Jason
next prev parent reply other threads:[~2021-08-25 0:36 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 14:46 cleanup vfio iommu_group creation v2 Christoph Hellwig
2021-08-24 14:46 ` [PATCH 01/14] vfio: Move vfio_iommu_group_get() to vfio_register_group_dev() Christoph Hellwig
2021-08-24 20:25 ` Alex Williamson
2021-08-24 22:50 ` Jason Gunthorpe
2021-08-25 12:43 ` Christoph Hellwig
2021-08-25 15:48 ` Alex Williamson
2021-08-25 16:08 ` Jason Gunthorpe
2021-08-24 14:46 ` [PATCH 02/14] vfio: factor out a vfio_iommu_driver_allowed helper Christoph Hellwig
2021-08-24 23:24 ` Jason Gunthorpe
2021-08-24 14:46 ` [PATCH 03/14] vfio: remove the iommudata check in vfio_noiommu_attach_group Christoph Hellwig
2021-08-24 23:31 ` Jason Gunthorpe
2021-08-24 14:46 ` [PATCH 04/14] vfio: factor out a vfio_group_find_or_alloc helper Christoph Hellwig
2021-08-24 23:40 ` Jason Gunthorpe
2021-08-25 5:30 ` Christoph Hellwig
2021-08-24 14:46 ` [PATCH 05/14] vfio: refactor noiommu group creation Christoph Hellwig
2021-08-24 23:43 ` Jason Gunthorpe
2021-08-24 14:46 ` [PATCH 06/14] vfio: remove the iommudata hack for noiommu groups Christoph Hellwig
2021-08-24 23:45 ` Jason Gunthorpe
2021-08-24 14:46 ` [PATCH 07/14] vfio: simplify iommu group allocation for mediated devices Christoph Hellwig
2021-08-25 0:19 ` Jason Gunthorpe
2021-08-25 5:32 ` Christoph Hellwig
2021-08-25 12:21 ` Jason Gunthorpe
2021-08-25 12:24 ` Christoph Hellwig
2021-08-25 12:34 ` Jason Gunthorpe
2021-08-25 12:37 ` Christoph Hellwig
2021-08-25 12:45 ` Jason Gunthorpe
2021-08-25 12:50 ` Christoph Hellwig
2021-08-25 12:50 ` Jason Gunthorpe
2021-08-24 14:46 ` [PATCH 08/14] vfio: remove unused method from vfio_iommu_driver_ops Christoph Hellwig
2021-08-25 0:21 ` Jason Gunthorpe
2021-08-24 14:46 ` [PATCH 09/14] vfio: move the vfio_iommu_driver_ops interface out of <linux/vfio.h> Christoph Hellwig
2021-08-25 0:25 ` Jason Gunthorpe
2021-08-24 14:46 ` [PATCH 10/14] vfio: remove the unused mdev iommu hook Christoph Hellwig
2021-08-25 0:25 ` Jason Gunthorpe
2021-08-24 14:46 ` [PATCH 11/14] vfio: clean up the check for mediated device in vfio_iommu_type1 Christoph Hellwig
2021-08-25 0:28 ` Jason Gunthorpe
2021-08-25 5:34 ` Christoph Hellwig
2021-08-25 12:35 ` Jason Gunthorpe
2021-08-24 14:46 ` [PATCH 12/14] vfio/spapr_tce: reject mediated devices Christoph Hellwig
2021-08-25 0:29 ` Jason Gunthorpe
2021-08-24 14:46 ` [PATCH 13/14] vfio/iommu_type1: remove the "external" domain Christoph Hellwig
2021-08-25 0:36 ` Jason Gunthorpe [this message]
2021-08-25 5:35 ` Christoph Hellwig
2021-08-24 14:46 ` [PATCH 14/14] vfio/iommu_type1: remove IS_IOMMU_CAP_DOMAIN_IN_CONTAINER Christoph Hellwig
2021-08-25 0:38 ` Jason Gunthorpe
-- strict thread matches above, loose matches on Subject: below --
2021-09-13 7:15 cleanup vfio iommu_group creation v5 Christoph Hellwig
2021-09-13 7:16 ` [PATCH 13/14] vfio/iommu_type1: remove the "external" domain Christoph Hellwig
2021-09-23 22:59 ` Alex Williamson
2021-09-23 23:06 ` Jason Gunthorpe
2021-08-26 13:34 cleanup vfio iommu_group creation v4 Christoph Hellwig
2021-08-26 13:34 ` [PATCH 13/14] vfio/iommu_type1: remove the "external" domain Christoph Hellwig
2021-08-26 23:08 ` Alex Williamson
2021-08-25 16:19 cleanup vfio iommu_group creation v3 Christoph Hellwig
2021-08-25 16:19 ` [PATCH 13/14] vfio/iommu_type1: remove the "external" domain Christoph Hellwig
2021-08-26 4:31 ` Tian, Kevin
2021-08-11 15:14 cleanup vfio iommu_group creation Christoph Hellwig
2021-08-11 15:14 ` [PATCH 13/14] vfio/iommu_type1: remove the "external" domain Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210825003629.GT543798@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=diana.craciun@oss.nxp.com \
--cc=eric.auger@redhat.com \
--cc=hch@lst.de \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).