* [PATCH] KVM: Drop unused kvm_dirty_gfn_harvested()
@ 2021-09-01 23:05 Peter Xu
2021-09-02 16:33 ` Vitaly Kuznetsov
0 siblings, 1 reply; 6+ messages in thread
From: Peter Xu @ 2021-09-01 23:05 UTC (permalink / raw)
To: linux-kernel, kvm; +Cc: peterx, Paolo Bonzini, kernel test robot
Drop the unused function as reported by test bot.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
virt/kvm/dirty_ring.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/virt/kvm/dirty_ring.c b/virt/kvm/dirty_ring.c
index 7aafefc50aa7..88f4683198ea 100644
--- a/virt/kvm/dirty_ring.c
+++ b/virt/kvm/dirty_ring.c
@@ -91,11 +91,6 @@ static inline void kvm_dirty_gfn_set_dirtied(struct kvm_dirty_gfn *gfn)
gfn->flags = KVM_DIRTY_GFN_F_DIRTY;
}
-static inline bool kvm_dirty_gfn_invalid(struct kvm_dirty_gfn *gfn)
-{
- return gfn->flags == 0;
-}
-
static inline bool kvm_dirty_gfn_harvested(struct kvm_dirty_gfn *gfn)
{
return gfn->flags & KVM_DIRTY_GFN_F_RESET;
--
2.31.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] KVM: Drop unused kvm_dirty_gfn_harvested()
2021-09-01 23:05 [PATCH] KVM: Drop unused kvm_dirty_gfn_harvested() Peter Xu
@ 2021-09-02 16:33 ` Vitaly Kuznetsov
2021-09-02 16:40 ` Sean Christopherson
0 siblings, 1 reply; 6+ messages in thread
From: Vitaly Kuznetsov @ 2021-09-02 16:33 UTC (permalink / raw)
To: Peter Xu, linux-kernel, kvm; +Cc: peterx, Paolo Bonzini, kernel test robot
Peter Xu <peterx@redhat.com> writes:
> Drop the unused function as reported by test bot.
Your subject line says "Drop unused kvm_dirty_gfn_harvested()" while in
reallity you drop "kvm_dirty_gfn_invalid()".
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> virt/kvm/dirty_ring.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/virt/kvm/dirty_ring.c b/virt/kvm/dirty_ring.c
> index 7aafefc50aa7..88f4683198ea 100644
> --- a/virt/kvm/dirty_ring.c
> +++ b/virt/kvm/dirty_ring.c
> @@ -91,11 +91,6 @@ static inline void kvm_dirty_gfn_set_dirtied(struct kvm_dirty_gfn *gfn)
> gfn->flags = KVM_DIRTY_GFN_F_DIRTY;
> }
>
> -static inline bool kvm_dirty_gfn_invalid(struct kvm_dirty_gfn *gfn)
> -{
> - return gfn->flags == 0;
> -}
> -
> static inline bool kvm_dirty_gfn_harvested(struct kvm_dirty_gfn *gfn)
> {
> return gfn->flags & KVM_DIRTY_GFN_F_RESET;
--
Vitaly
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] KVM: Drop unused kvm_dirty_gfn_harvested()
2021-09-02 16:33 ` Vitaly Kuznetsov
@ 2021-09-02 16:40 ` Sean Christopherson
2021-09-02 16:46 ` Vitaly Kuznetsov
0 siblings, 1 reply; 6+ messages in thread
From: Sean Christopherson @ 2021-09-02 16:40 UTC (permalink / raw)
To: Vitaly Kuznetsov
Cc: Peter Xu, linux-kernel, kvm, Paolo Bonzini, kernel test robot
On Thu, Sep 02, 2021, Vitaly Kuznetsov wrote:
> Peter Xu <peterx@redhat.com> writes:
>
> > Drop the unused function as reported by test bot.
>
> Your subject line says "Drop unused kvm_dirty_gfn_harvested()" while in
> reallity you drop "kvm_dirty_gfn_invalid()".
Heh, Peter already sent v2[*]. Though that's a good reminder that it's helpful
to reviewers to respond to your own patch if there's a fatal mistake and you're
going to immediately post a new version. For tiny patches it's not a big deal,
but for larger patches it can avoid wasting reviewers' time.
https://lkml.kernel.org/r/20210901230904.15164-1-peterx@redhat.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] KVM: Drop unused kvm_dirty_gfn_harvested()
2021-09-02 16:40 ` Sean Christopherson
@ 2021-09-02 16:46 ` Vitaly Kuznetsov
2021-09-02 19:53 ` Peter Xu
0 siblings, 1 reply; 6+ messages in thread
From: Vitaly Kuznetsov @ 2021-09-02 16:46 UTC (permalink / raw)
To: Sean Christopherson
Cc: Peter Xu, linux-kernel, kvm, Paolo Bonzini, kernel test robot
Sean Christopherson <seanjc@google.com> writes:
> On Thu, Sep 02, 2021, Vitaly Kuznetsov wrote:
>> Peter Xu <peterx@redhat.com> writes:
>>
>> > Drop the unused function as reported by test bot.
>>
>> Your subject line says "Drop unused kvm_dirty_gfn_harvested()" while in
>> reallity you drop "kvm_dirty_gfn_invalid()".
>
> Heh, Peter already sent v2[*]. Though that's a good reminder that it's helpful
> to reviewers to respond to your own patch if there's a fatal mistake and you're
> going to immediately post a new version. For tiny patches it's not a big deal,
> but for larger patches it can avoid wasting reviewers' time.
>
Indeed. It's also a good reminder for reviewers that inbox is best
treated like a stack and not like a queue :-)
--
Vitaly
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] KVM: Drop unused kvm_dirty_gfn_harvested()
2021-09-02 16:46 ` Vitaly Kuznetsov
@ 2021-09-02 19:53 ` Peter Xu
2021-09-02 20:13 ` Sean Christopherson
0 siblings, 1 reply; 6+ messages in thread
From: Peter Xu @ 2021-09-02 19:53 UTC (permalink / raw)
To: Vitaly Kuznetsov
Cc: Sean Christopherson, linux-kernel, kvm, Paolo Bonzini, kernel test robot
On Thu, Sep 02, 2021 at 06:46:14PM +0200, Vitaly Kuznetsov wrote:
> Sean Christopherson <seanjc@google.com> writes:
>
> > On Thu, Sep 02, 2021, Vitaly Kuznetsov wrote:
> >> Peter Xu <peterx@redhat.com> writes:
> >>
> >> > Drop the unused function as reported by test bot.
> >>
> >> Your subject line says "Drop unused kvm_dirty_gfn_harvested()" while in
> >> reallity you drop "kvm_dirty_gfn_invalid()".
> >
> > Heh, Peter already sent v2[*]. Though that's a good reminder that it's helpful
> > to reviewers to respond to your own patch if there's a fatal mistake and you're
> > going to immediately post a new version. For tiny patches it's not a big deal,
> > but for larger patches it can avoid wasting reviewers' time.
> >
>
> Indeed. It's also a good reminder for reviewers that inbox is best
> treated like a stack and not like a queue :-)
It should really be a queue, to be fair. :)
I normally glance all the emails before looking into the details. But that's
not an excuse for sure, I should have NACKed that one. Sorry about that.
--
Peter Xu
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] KVM: Drop unused kvm_dirty_gfn_harvested()
2021-09-02 19:53 ` Peter Xu
@ 2021-09-02 20:13 ` Sean Christopherson
0 siblings, 0 replies; 6+ messages in thread
From: Sean Christopherson @ 2021-09-02 20:13 UTC (permalink / raw)
To: Peter Xu
Cc: Vitaly Kuznetsov, linux-kernel, kvm, Paolo Bonzini, kernel test robot
On Thu, Sep 02, 2021, Peter Xu wrote:
> On Thu, Sep 02, 2021 at 06:46:14PM +0200, Vitaly Kuznetsov wrote:
> > Sean Christopherson <seanjc@google.com> writes:
> >
> > > On Thu, Sep 02, 2021, Vitaly Kuznetsov wrote:
> > >> Peter Xu <peterx@redhat.com> writes:
> > >>
> > >> > Drop the unused function as reported by test bot.
> > >>
> > >> Your subject line says "Drop unused kvm_dirty_gfn_harvested()" while in
> > >> reallity you drop "kvm_dirty_gfn_invalid()".
> > >
> > > Heh, Peter already sent v2[*]. Though that's a good reminder that it's helpful
> > > to reviewers to respond to your own patch if there's a fatal mistake and you're
> > > going to immediately post a new version. For tiny patches it's not a big deal,
> > > but for larger patches it can avoid wasting reviewers' time.
> > >
> >
> > Indeed. It's also a good reminder for reviewers that inbox is best
> > treated like a stack and not like a queue :-)
>
> It should really be a queue, to be fair. :)
Ya, a queue plus a deferred work queue for things that can't be handled in
interrupt context ;-)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-09-02 20:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01 23:05 [PATCH] KVM: Drop unused kvm_dirty_gfn_harvested() Peter Xu
2021-09-02 16:33 ` Vitaly Kuznetsov
2021-09-02 16:40 ` Sean Christopherson
2021-09-02 16:46 ` Vitaly Kuznetsov
2021-09-02 19:53 ` Peter Xu
2021-09-02 20:13 ` Sean Christopherson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).