From: David Hildenbrand <david@redhat.com>
To: kvm@vger.kernel.org
Cc: Thomas Huth <thuth@redhat.com>,
Janosch Frank <frankja@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cohuck@redhat.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
linux-s390@vger.kernel.org, David Hildenbrand <david@redhat.com>
Subject: [kvm-unit-tests PATCH v1] s390x/skey: Test for ADDRESSING exceptions
Date: Fri, 3 Sep 2021 18:25:37 +0200 [thread overview]
Message-ID: <20210903162537.57178-1-david@redhat.com> (raw)
... used to be broken in TCG, so let's add a very simple test for SSKE
and ISKE. In order to test RRBE as well, introduce a helper to call the
machine instruction.
Signed-off-by: David Hildenbrand <david@redhat.com>
---
lib/s390x/asm/mem.h | 12 ++++++++++++
s390x/skey.c | 28 ++++++++++++++++++++++++++++
2 files changed, 40 insertions(+)
diff --git a/lib/s390x/asm/mem.h b/lib/s390x/asm/mem.h
index 40b22b6..845c00c 100644
--- a/lib/s390x/asm/mem.h
+++ b/lib/s390x/asm/mem.h
@@ -50,6 +50,18 @@ static inline unsigned char get_storage_key(void *addr)
return skey;
}
+static inline unsigned char reset_reference_bit(void *addr)
+{
+ int cc;
+
+ asm volatile(
+ "rrbe 0,%1\n"
+ "ipm %0\n"
+ "srl %0,28\n"
+ : "=d" (cc) : "a" (addr) : "cc");
+ return cc;
+}
+
#define PFMF_FSC_4K 0
#define PFMF_FSC_1M 1
#define PFMF_FSC_2G 2
diff --git a/s390x/skey.c b/s390x/skey.c
index 2539944..58a5543 100644
--- a/s390x/skey.c
+++ b/s390x/skey.c
@@ -120,6 +120,33 @@ static void test_priv(void)
report_prefix_pop();
}
+static void test_invalid_address(void)
+{
+ void *inv_addr = (void *)-1ull;
+
+ report_prefix_push("invalid address");
+
+ report_prefix_push("sske");
+ expect_pgm_int();
+ set_storage_key(inv_addr, 0, 0);
+ check_pgm_int_code(PGM_INT_CODE_ADDRESSING);
+ report_prefix_pop();
+
+ report_prefix_push("iske");
+ expect_pgm_int();
+ get_storage_key(inv_addr);
+ check_pgm_int_code(PGM_INT_CODE_ADDRESSING);
+ report_prefix_pop();
+
+ report_prefix_push("rrbe");
+ expect_pgm_int();
+ reset_reference_bit(inv_addr);
+ check_pgm_int_code(PGM_INT_CODE_ADDRESSING);
+ report_prefix_pop();
+
+ report_prefix_pop();
+}
+
int main(void)
{
report_prefix_push("skey");
@@ -128,6 +155,7 @@ int main(void)
goto done;
}
test_priv();
+ test_invalid_address();
test_set();
test_set_mb();
test_chg();
--
2.31.1
next reply other threads:[~2021-09-03 16:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 16:25 David Hildenbrand [this message]
2021-09-06 11:53 ` [kvm-unit-tests PATCH v1] s390x/skey: Test for ADDRESSING exceptions Janosch Frank
2021-09-06 12:02 ` Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210903162537.57178-1-david@redhat.com \
--to=david@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).