From: Jim Mattson <jmattson@google.com>
To: kvm@vger.kernel.org, pbonzini@redhat.com
Cc: Jim Mattson <jmattson@google.com>
Subject: [kvm-unit-tests PATCH v2 0/3] Regression test for L1 LDTR persistence bug
Date: Fri, 15 Oct 2021 12:55:27 -0700 [thread overview]
Message-ID: <20211015195530.301237-1-jmattson@google.com> (raw)
In Linux commit afc8de0118be ("KVM: nVMX: Set LDTR to its
architecturally defined value on nested VM-Exit"), Sean suggested that
this bug was likely benign, but it turns out that--for us, at
least--it can result in live migration failures. On restore, we call
KVM_SET_SREGS before KVM_SET_NESTED_STATE, so when L2 is active at the
time of save/restore, the target vmcs01 is temporarily populated with
L2 values. Hence, the LDTR visible to L1 after the next emulated
VM-exit is L2's, rather than its own.
This issue is significant enough that it warrants a regression
test. Unfortunately, at the moment, the best we can do is check for
the LDTR persistence bug. I'd like to be able to trigger a
save/restore from within the L2 guest, but AFAICT, there's no way to
do that under qemu. Does anyone want to implement a qemu ISA test
device that triggers a save/restore when its configured I/O port is
written to?
Jim Mattson (3):
x86: Fix operand size for lldt
x86: Make set_gdt_entry usable in 64-bit mode
x86: Add a regression test for L1 LDTR persistence bug
v1 -> v2:
Reworded report messages at Sean's suggestion.
lib/x86/desc.c | 41 +++++++++++++++++++++++++++++++----------
lib/x86/desc.h | 3 ++-
lib/x86/processor.h | 2 +-
x86/cstart64.S | 1 +
x86/vmx_tests.c | 39 +++++++++++++++++++++++++++++++++++++++
5 files changed, 74 insertions(+), 12 deletions(-)
--
2.33.0.1079.g6e70778dc9-goog
next reply other threads:[~2021-10-15 19:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 19:55 Jim Mattson [this message]
2021-10-15 19:55 ` [kvm-unit-tests PATCH v2 1/3] x86: Fix operand size for lldt Jim Mattson
2021-10-15 19:55 ` [kvm-unit-tests PATCH v2 2/3] x86: Make set_gdt_entry usable in 64-bit mode Jim Mattson
2021-10-15 19:55 ` [kvm-unit-tests PATCH v2 3/3] x86: Add a regression test for L1 LDTR persistence bug Jim Mattson
2021-11-10 19:50 ` [kvm-unit-tests PATCH v2 0/3] Regression " Jim Mattson
2021-11-10 21:44 ` Paolo Bonzini
2021-11-29 22:19 ` David Matlack
2021-11-30 8:42 ` Paolo Bonzini
2021-11-11 17:44 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211015195530.301237-1-jmattson@google.com \
--to=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).