From: Pierre Morel <pmorel@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: frankja@linux.ibm.com, david@redhat.com, thuth@redhat.com,
cohuck@redhat.com, imbrenda@linux.ibm.com
Subject: [kvm-unit-tests PATCH v2] s390x: fixing I/O memory allocation
Date: Tue, 16 Nov 2021 13:26:29 +0100 [thread overview]
Message-ID: <20211116122629.257689-1-pmorel@linux.ibm.com> (raw)
The allocator allocate pages it follows the size must be rounded
to pages before the allocation.
Fixes: b0fe3988 "s390x: define UV compatible I/O allocation"
Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
---
lib/s390x/malloc_io.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/s390x/malloc_io.c b/lib/s390x/malloc_io.c
index 78582eac..080fc694 100644
--- a/lib/s390x/malloc_io.c
+++ b/lib/s390x/malloc_io.c
@@ -41,7 +41,7 @@ static void unshare_pages(void *p, int count)
void *alloc_io_mem(int size, int flags)
{
- int order = get_order(size >> PAGE_SHIFT);
+ int order = get_order(PAGE_ALIGN(size) >> PAGE_SHIFT);
void *p;
int n;
@@ -62,7 +62,7 @@ void *alloc_io_mem(int size, int flags)
void free_io_mem(void *p, int size)
{
- int order = get_order(size >> PAGE_SHIFT);
+ int order = get_order(PAGE_ALIGN(size) >> PAGE_SHIFT);
assert(IS_ALIGNED((uintptr_t)p, PAGE_SIZE));
--
2.25.1
next reply other threads:[~2021-11-16 12:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 12:26 Pierre Morel [this message]
2021-11-16 12:27 ` [kvm-unit-tests PATCH v2] s390x: fixing I/O memory allocation Pierre Morel
-- strict thread matches above, loose matches on Subject: below --
2021-11-11 10:01 Pierre Morel
2021-11-11 10:14 ` David Hildenbrand
2021-11-11 10:28 ` Claudio Imbrenda
2021-11-11 10:39 ` David Hildenbrand
2021-11-11 11:55 ` Pierre Morel
2021-11-11 15:10 ` Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211116122629.257689-1-pmorel@linux.ibm.com \
--to=pmorel@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).