From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: Pierre Morel <pmorel@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, frankja@linux.ibm.com,
thuth@redhat.com, kvm@vger.kernel.org, cohuck@redhat.com,
david@redhat.com
Subject: Re: [kvm-unit-tests PATCH v3 3/4] s390x: topology: Check the Perform Topology Function
Date: Tue, 11 Jan 2022 12:25:26 +0100 [thread overview]
Message-ID: <20220111122526.60e31b38@p-imbrenda> (raw)
In-Reply-To: <20220110133755.22238-4-pmorel@linux.ibm.com>
On Mon, 10 Jan 2022 14:37:54 +0100
Pierre Morel <pmorel@linux.ibm.com> wrote:
> We check the PTF instruction.
>
> - We do not expect to support vertical polarization.
>
> - We do not expect the Modified Topology Change Report to be
> pending or not at the moment the first PTF instruction with
> PTF_CHECK function code is done as some code already did run
> a polarization change may have occur.
>
> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> ---
> s390x/Makefile | 1 +
> s390x/topology.c | 115 ++++++++++++++++++++++++++++++++++++++++++++
> s390x/unittests.cfg | 3 ++
> 3 files changed, 119 insertions(+)
> create mode 100644 s390x/topology.c
>
> diff --git a/s390x/Makefile b/s390x/Makefile
> index 1e567c11..fa21a882 100644
> --- a/s390x/Makefile
> +++ b/s390x/Makefile
> @@ -26,6 +26,7 @@ tests += $(TEST_DIR)/edat.elf
> tests += $(TEST_DIR)/mvpg-sie.elf
> tests += $(TEST_DIR)/spec_ex-sie.elf
> tests += $(TEST_DIR)/firq.elf
> +tests += $(TEST_DIR)/topology.elf
>
> tests_binary = $(patsubst %.elf,%.bin,$(tests))
> ifneq ($(HOST_KEY_DOCUMENT),)
> diff --git a/s390x/topology.c b/s390x/topology.c
> new file mode 100644
> index 00000000..a227555e
> --- /dev/null
> +++ b/s390x/topology.c
> @@ -0,0 +1,115 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * CPU Topology
> + *
> + * Copyright (c) 2021 IBM Corp
Copyright IBM Corp. 2021
> + *
> + * Authors:
> + * Pierre Morel <pmorel@linux.ibm.com>
> + */
> +
> +#include <libcflat.h>
> +#include <asm/page.h>
> +#include <asm/asm-offsets.h>
> +#include <asm/interrupt.h>
> +#include <asm/facility.h>
> +#include <smp.h>
> +#include <sclp.h>
> +#include <s390x/vm.h>
> +
> +#define PTF_REQ_HORIZONTAL 0
> +#define PTF_REQ_VERTICAL 1
> +#define PTF_REQ_CHECK 2
> +
> +#define PTF_ERR_NO_REASON 0
> +#define PTF_ERR_ALRDY_POLARIZED 1
> +#define PTF_ERR_IN_PROGRESS 2
> +
> +static int ptf(unsigned long fc, unsigned long *rc)
> +{
> + int cc;
> +
> + asm volatile(
> + " .insn rre,0xb9a20000,%1,0\n"
> + " ipm %0\n"
> + " srl %0,28\n"
> + : "=d" (cc), "+d" (fc)
> + : "d" (fc)
> + : "cc");
> +
> + *rc = fc >> 8;
> + return cc;
> +}
> +
> +static void test_ptf(void)
> +{
> + unsigned long rc;
> + int cc;
> +
> + report_prefix_push("Topology Report pending");
> + /*
> + * At this moment the topology may already have changed
> + * since the VM has been started.
> + * However, we can test if a second PTF instruction
> + * reports that the topology did not change since the
> + * preceding PFT instruction.
> + */
> + ptf(PTF_REQ_CHECK, &rc);
> + cc = ptf(PTF_REQ_CHECK, &rc);
> + report(cc == 0, "PTF check should clear topology report");
> +
> + report_prefix_pop();
> +
> + report_prefix_push("Topology polarisation check");
> + /*
> + * We can not assume the state of the polarization for
> + * any Virtual Machine but KVM.
> + * Let's skip the polarisation tests for other VMs.
> + */
> + if (!vm_is_kvm()) {
> + report_skip("Topology polarisation check is done for KVM only");
> + goto end;
> + }
> +
> + cc = ptf(PTF_REQ_HORIZONTAL, &rc);
> + report(cc == 2 && rc == PTF_ERR_ALRDY_POLARIZED,
> + "KVM always provides horizontal polarization");
> +
> + cc = ptf(PTF_REQ_VERTICAL, &rc);
> + report(cc == 2 && rc == PTF_ERR_NO_REASON,
> + "KVM doesn't support vertical polarization.");
> +
> +end:
> + report_prefix_pop();
> +}
> +
> +static struct {
> + const char *name;
> + void (*func)(void);
> +} tests[] = {
> + { "PTF", test_ptf},
> + { NULL, NULL }
> +};
> +
> +int main(int argc, char *argv[])
> +{
> + int i;
> +
> + report_prefix_push("CPU Topology");
> +
> + if (!test_facility(11)) {
> + report_skip("Topology facility not present");
> + goto end;
> + }
> +
> + report_info("Machine level %ld", stsi_get_fc());
> +
> + for (i = 0; tests[i].name; i++) {
> + report_prefix_push(tests[i].name);
> + tests[i].func();
> + report_prefix_pop();
> + }
> +end:
> + report_prefix_pop();
> + return report_summary();
> +}
> diff --git a/s390x/unittests.cfg b/s390x/unittests.cfg
> index 054560c2..e2d3e6a5 100644
> --- a/s390x/unittests.cfg
> +++ b/s390x/unittests.cfg
> @@ -122,3 +122,6 @@ extra_params = -smp 1,maxcpus=3 -cpu qemu -device qemu-s390x-cpu,core-id=1 -devi
> file = firq.elf
> timeout = 20
> extra_params = -smp 1,maxcpus=3 -cpu qemu -device qemu-s390x-cpu,core-id=2 -device qemu-s390x-cpu,core-id=1
> +
> +[topology]
> +file = topology.elf
next prev parent reply other threads:[~2022-01-11 13:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 13:37 [kvm-unit-tests PATCH v3 0/4] S390x: CPU Topology Information Pierre Morel
2022-01-10 13:37 ` [kvm-unit-tests PATCH v3 1/4] s390x: lib: Add SCLP toplogy nested level Pierre Morel
2022-01-10 13:37 ` [kvm-unit-tests PATCH v3 2/4] s390x: stsi: Define vm_is_kvm to be used in different tests Pierre Morel
2022-01-11 12:27 ` Janosch Frank
2022-01-17 14:57 ` Pierre Morel
2022-01-18 8:35 ` Janosch Frank
2022-01-18 17:07 ` Pierre Morel
2022-01-11 13:08 ` Claudio Imbrenda
2022-01-17 15:05 ` Pierre Morel
2022-01-10 13:37 ` [kvm-unit-tests PATCH v3 3/4] s390x: topology: Check the Perform Topology Function Pierre Morel
2022-01-11 11:25 ` Claudio Imbrenda [this message]
2022-01-17 15:07 ` Pierre Morel
2022-01-10 13:37 ` [kvm-unit-tests PATCH v3 4/4] s390x: topology: Checking Configuration Topology Information Pierre Morel
2022-01-11 13:30 ` Janosch Frank
2022-01-17 15:14 ` Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220111122526.60e31b38@p-imbrenda \
--to=imbrenda@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pmorel@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).