From: Alex Williamson <alex.williamson@redhat.com>
To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
Cc: Jason Gunthorpe <jgg@nvidia.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"mgurtovoy@nvidia.com" <mgurtovoy@nvidia.com>,
Linuxarm <linuxarm@huawei.com>,
liulongfang <liulongfang@huawei.com>,
"Zengtao (B)" <prime.zeng@hisilicon.com>,
yuzenghui <yuzenghui@huawei.com>,
"Jonathan Cameron" <jonathan.cameron@huawei.com>,
"Wangzhou (B)" <wangzhou1@hisilicon.com>
Subject: Re: [RFC v2 0/4] vfio/hisilicon: add acc live migration driver
Date: Wed, 2 Feb 2022 10:30:41 -0700 [thread overview]
Message-ID: <20220202103041.2b404d13.alex.williamson@redhat.com> (raw)
In-Reply-To: <a29ae3ea51344e18b9659424772a4b42@huawei.com>
On Wed, 2 Feb 2022 14:34:52 +0000
Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com> wrote:
> > -----Original Message-----
> > From: Jason Gunthorpe [mailto:jgg@nvidia.com]
>
> >
> > I see pf_qm_state_pre_save() but didn't understand why it wanted to
> > send the first 32 bytes in the PRECOPY mode? It is fine, but it
> > will add some complexity to continue to do this.
>
> That was mainly to do a quick verification between src and dst compatibility
> before we start saving the state. I think probably we can delay that check
> for later.
In the v1 migration scheme, this was considered good practice. It
shouldn't be limited to PRECOPY, as there's no requirement to use
PRECOPY, but the earlier in the migration process that we can trigger a
device or data stream compatibility fault, the better. TBH, even in
the case where a device doesn't support live dirty tracking for a
PRECOPY phase, using it for compatibility testing continues to seem
like good practice. Thanks,
Alex
next prev parent reply other threads:[~2022-02-02 17:30 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 9:58 [RFC v2 0/4] vfio/hisilicon: add acc live migration driver Shameer Kolothum
2021-07-02 9:58 ` [RFC v2 1/4] hisi-acc-vfio-pci: add new vfio_pci driver for HiSilicon ACC devices Shameer Kolothum
2021-07-02 20:29 ` Alex Williamson
2021-07-05 7:20 ` Shameerali Kolothum Thodi
2021-07-04 7:03 ` Leon Romanovsky
2021-07-05 8:47 ` Shameerali Kolothum Thodi
2021-07-05 9:41 ` Max Gurtovoy
2021-07-05 10:18 ` Shameerali Kolothum Thodi
2021-07-05 18:27 ` Leon Romanovsky
2021-07-05 18:32 ` Jason Gunthorpe
2021-07-06 3:59 ` Leon Romanovsky
2021-07-06 4:39 ` Christoph Hellwig
2021-07-06 11:51 ` Jason Gunthorpe
2021-07-02 9:58 ` [RFC v2 2/4] hisi_acc_vfio_pci: Override ioctl method to limit BAR2 region size Shameer Kolothum
2021-07-02 20:29 ` Alex Williamson
2021-07-05 7:22 ` Shameerali Kolothum Thodi
2021-07-02 9:58 ` [RFC v2 3/4] crypto: hisilicon/qm - Export mailbox functions for common use Shameer Kolothum
2021-07-04 9:34 ` Max Gurtovoy
2021-07-05 10:23 ` Shameerali Kolothum Thodi
2021-07-02 9:58 ` [RFC v2 4/4] hisi_acc_vfio_pci: Add support for vfio live migration Shameer Kolothum
2022-02-02 13:14 ` [RFC v2 0/4] vfio/hisilicon: add acc live migration driver Jason Gunthorpe
2022-02-02 14:34 ` Shameerali Kolothum Thodi
2022-02-02 15:39 ` Jason Gunthorpe
2022-02-02 16:10 ` Shameerali Kolothum Thodi
2022-02-02 17:03 ` Jason Gunthorpe
2022-02-02 19:05 ` Joao Martins
2022-02-03 15:18 ` Jason Gunthorpe
2022-02-04 19:53 ` Joao Martins
2022-02-04 23:07 ` Jason Gunthorpe
2022-02-11 17:28 ` Joao Martins
2022-02-11 17:49 ` Jason Gunthorpe
2022-02-11 21:43 ` Joao Martins
2022-02-12 0:01 ` Jason Gunthorpe
2022-02-14 13:34 ` Joao Martins
2022-02-14 14:06 ` Jason Gunthorpe
2022-02-15 16:00 ` Joao Martins
2022-02-15 16:21 ` Jason Gunthorpe
2022-02-22 11:55 ` Joao Martins
2022-02-23 1:03 ` Jason Gunthorpe
2022-02-25 19:18 ` Joao Martins
2022-02-25 20:44 ` Jason Gunthorpe
2022-02-28 13:01 ` Joao Martins
2022-02-28 21:01 ` Jason Gunthorpe
2022-03-01 13:06 ` Joao Martins
2022-03-01 13:54 ` Jason Gunthorpe
2022-03-01 14:27 ` Joao Martins
2022-03-11 13:51 ` iommufd(+vfio-compat) dirty tracking (Was: Re: [RFC v2 0/4] vfio/hisilicon: add acc live migration driver) Joao Martins
2022-03-15 19:29 ` Jason Gunthorpe
2022-03-16 16:36 ` iommufd(+vfio-compat) dirty tracking Joao Martins
2022-03-16 20:37 ` Joao Martins
2022-03-18 17:12 ` Joao Martins
2022-03-18 17:34 ` Jason Gunthorpe
2022-02-02 17:30 ` Alex Williamson [this message]
2022-02-02 18:04 ` [RFC v2 0/4] vfio/hisilicon: add acc live migration driver Jason Gunthorpe
2022-02-18 16:37 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220202103041.2b404d13.alex.williamson@redhat.com \
--to=alex.williamson@redhat.com \
--cc=jgg@nvidia.com \
--cc=jonathan.cameron@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liulongfang@huawei.com \
--cc=mgurtovoy@nvidia.com \
--cc=prime.zeng@hisilicon.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=wangzhou1@hisilicon.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).