From: Alex Williamson <alex.williamson@redhat.com>
To: Matthew Rosato <mjrosato@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, cohuck@redhat.com,
schnelle@linux.ibm.com, farman@linux.ibm.com,
pmorel@linux.ibm.com, borntraeger@linux.ibm.com,
hca@linux.ibm.com, gor@linux.ibm.com,
gerald.schaefer@linux.ibm.com, agordeev@linux.ibm.com,
svens@linux.ibm.com, frankja@linux.ibm.com, david@redhat.com,
imbrenda@linux.ibm.com, vneethv@linux.ibm.com,
oberpar@linux.ibm.com, freude@linux.ibm.com, thuth@redhat.com,
pasic@linux.ibm.com, pbonzini@redhat.com, corbet@lwn.net,
jgg@nvidia.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v9 19/21] vfio-pci/zdev: different maxstbl for interpreted devices
Date: Tue, 28 Jun 2022 09:00:19 -0600 [thread overview]
Message-ID: <20220628090019.2903f766.alex.williamson@redhat.com> (raw)
In-Reply-To: <20220606203325.110625-20-mjrosato@linux.ibm.com>
On Mon, 6 Jun 2022 16:33:23 -0400
Matthew Rosato <mjrosato@linux.ibm.com> wrote:
> When doing load/store interpretation, the maximum store block length is
> determined by the underlying firmware, not the host kernel API. Reflect
> that in the associated Query PCI Function Group clp capability and let
> userspace decide which is appropriate to present to the guest.
>
> Reviewed-by: Pierre Morel <pmorel@linux.ibm.com>
> Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
> ---
> drivers/vfio/pci/vfio_pci_zdev.c | 6 ++++--
> include/uapi/linux/vfio_zdev.h | 4 ++++
> 2 files changed, 8 insertions(+), 2 deletions(-)
Acked-by: Alex Williamson <alex.williamson@redhat.com>
> diff --git a/drivers/vfio/pci/vfio_pci_zdev.c b/drivers/vfio/pci/vfio_pci_zdev.c
> index 4f28cdd7ecd1..e163aa9f6144 100644
> --- a/drivers/vfio/pci/vfio_pci_zdev.c
> +++ b/drivers/vfio/pci/vfio_pci_zdev.c
> @@ -45,14 +45,16 @@ static int zpci_group_cap(struct zpci_dev *zdev, struct vfio_info_cap *caps)
> {
> struct vfio_device_info_cap_zpci_group cap = {
> .header.id = VFIO_DEVICE_INFO_CAP_ZPCI_GROUP,
> - .header.version = 1,
> + .header.version = 2,
> .dasm = zdev->dma_mask,
> .msi_addr = zdev->msi_addr,
> .flags = VFIO_DEVICE_INFO_ZPCI_FLAG_REFRESH,
> .mui = zdev->fmb_update,
> .noi = zdev->max_msi,
> .maxstbl = ZPCI_MAX_WRITE_SIZE,
> - .version = zdev->version
> + .version = zdev->version,
> + .reserved = 0,
> + .imaxstbl = zdev->maxstbl
> };
>
> return vfio_info_add_capability(caps, &cap.header, sizeof(cap));
> diff --git a/include/uapi/linux/vfio_zdev.h b/include/uapi/linux/vfio_zdev.h
> index 78c022af3d29..77f2aff1f27e 100644
> --- a/include/uapi/linux/vfio_zdev.h
> +++ b/include/uapi/linux/vfio_zdev.h
> @@ -50,6 +50,10 @@ struct vfio_device_info_cap_zpci_group {
> __u16 noi; /* Maximum number of MSIs */
> __u16 maxstbl; /* Maximum Store Block Length */
> __u8 version; /* Supported PCI Version */
> + /* End of version 1 */
> + __u8 reserved;
> + __u16 imaxstbl; /* Maximum Interpreted Store Block Length */
> + /* End of version 2 */
> };
>
> /**
next prev parent reply other threads:[~2022-06-28 15:00 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 20:33 [PATCH v9 00/21] KVM: s390: enable zPCI for interpretive execution Matthew Rosato
2022-06-06 20:33 ` [PATCH v9 01/21] s390/sclp: detect the zPCI load/store interpretation facility Matthew Rosato
2022-06-06 20:33 ` [PATCH v9 02/21] s390/sclp: detect the AISII facility Matthew Rosato
2022-06-06 20:33 ` [PATCH v9 03/21] s390/sclp: detect the AENI facility Matthew Rosato
2022-06-06 20:33 ` [PATCH v9 04/21] s390/sclp: detect the AISI facility Matthew Rosato
2022-06-06 20:33 ` [PATCH v9 05/21] s390/airq: pass more TPI info to airq handlers Matthew Rosato
2022-06-06 20:33 ` [PATCH v9 06/21] s390/airq: allow for airq structure that uses an input vector Matthew Rosato
2022-06-06 20:33 ` [PATCH v9 07/21] s390/pci: externalize the SIC operation controls and routine Matthew Rosato
2022-06-06 20:33 ` [PATCH v9 08/21] s390/pci: stash associated GISA designation Matthew Rosato
2022-06-06 20:33 ` [PATCH v9 09/21] s390/pci: stash dtsm and maxstbl Matthew Rosato
2022-06-06 20:33 ` [PATCH v9 10/21] vfio/pci: introduce CONFIG_VFIO_PCI_ZDEV_KVM Matthew Rosato
2022-06-08 6:19 ` Thomas Huth
2022-06-08 13:15 ` Matthew Rosato
2022-06-14 8:56 ` Pierre Morel
2022-06-17 16:15 ` Thomas Huth
2022-06-28 14:58 ` Alex Williamson
2022-06-06 20:33 ` [PATCH v9 11/21] KVM: s390: pci: add basic kvm_zdev structure Matthew Rosato
2022-06-06 20:33 ` [PATCH v9 12/21] KVM: s390: pci: do initial setup for AEN interpretation Matthew Rosato
2022-06-06 20:33 ` [PATCH v9 13/21] KVM: s390: pci: enable host forwarding of Adapter Event Notifications Matthew Rosato
2022-06-06 20:33 ` [PATCH v9 14/21] KVM: s390: mechanism to enable guest zPCI Interpretation Matthew Rosato
2022-06-06 20:33 ` [PATCH v9 15/21] KVM: s390: pci: provide routines for enabling/disabling interrupt forwarding Matthew Rosato
2022-06-06 20:33 ` [PATCH v9 16/21] KVM: s390: pci: add routines to start/stop interpretive execution Matthew Rosato
2022-06-28 10:53 ` Pierre Morel
2022-06-28 13:27 ` Matthew Rosato
2022-06-06 20:33 ` [PATCH v9 17/21] vfio-pci/zdev: add open/close device hooks Matthew Rosato
2022-06-28 11:22 ` Pierre Morel
2022-06-28 14:59 ` Alex Williamson
2022-06-06 20:33 ` [PATCH v9 18/21] vfio-pci/zdev: add function handle to clp base capability Matthew Rosato
2022-06-28 14:59 ` Alex Williamson
2022-06-06 20:33 ` [PATCH v9 19/21] vfio-pci/zdev: different maxstbl for interpreted devices Matthew Rosato
2022-06-28 15:00 ` Alex Williamson [this message]
2022-06-06 20:33 ` [PATCH v9 20/21] KVM: s390: add KVM_S390_ZPCI_OP to manage guest zPCI devices Matthew Rosato
2022-06-08 6:00 ` Thomas Huth
2022-06-14 8:49 ` Pierre Morel
2022-06-06 20:33 ` [PATCH v9 21/21] MAINTAINERS: additional files related kvm s390 pci passthrough Matthew Rosato
2022-06-08 6:02 ` Thomas Huth
2022-06-06 20:42 ` [PATCH v9 00/21] KVM: s390: enable zPCI for interpretive execution Matthew Rosato
2022-06-27 20:57 ` Matthew Rosato
2022-06-28 12:35 ` Christian Borntraeger
2022-06-28 13:40 ` Matthew Rosato
2022-06-28 13:49 ` Jason Gunthorpe
2022-06-28 14:02 ` Christian Borntraeger
2022-07-08 11:33 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220628090019.2903f766.alex.williamson@redhat.com \
--to=alex.williamson@redhat.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=farman@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=jgg@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=oberpar@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=pmorel@linux.ibm.com \
--cc=schnelle@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=thuth@redhat.com \
--cc=vneethv@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).