From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55515C00140 for ; Tue, 2 Aug 2022 10:46:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236508AbiHBKqY (ORCPT ); Tue, 2 Aug 2022 06:46:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236426AbiHBKqX (ORCPT ); Tue, 2 Aug 2022 06:46:23 -0400 Received: from out1.migadu.com (out1.migadu.com [IPv6:2001:41d0:2:863f::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9657E13F2D for ; Tue, 2 Aug 2022 03:46:21 -0700 (PDT) Date: Tue, 2 Aug 2022 12:46:18 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1659437179; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nFYosDrTV+J63hdmfnDR3VulrFnd+3rkg5tEZPz+cKc=; b=noC9FYS9mTpeHyqVTf8GzfH/+zs9OS/9GtVw6v+eBvgOesiCkNfIl9lH65ebg1vCp2KrKh DsTuNVfH00L3aEAK6dr9AmQmw0knsjjr9E8eCJz1OhFitiqQBoTh+2yvhjyfmNT4ZSa4O8 tS1WmjYf2bo7ERWrIjcNkMMPuO9r8dw= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Andrew Jones To: Alexandru Elisei Cc: Nikos Nikoleris , kvm@vger.kernel.org, pbonzini@redhat.com, jade.alglave@arm.com, ricarkol@google.com Subject: Re: [kvm-unit-tests PATCH v3 00/27] EFI and ACPI support for arm64 Message-ID: <20220802104618.giks3ogrdhe2gcvw@kamzik> References: <20220630100324.3153655-1-nikos.nikoleris@arm.com> <86e94983-0c69-88c8-f37f-c772ab6a4847@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Aug 02, 2022 at 11:19:00AM +0100, Alexandru Elisei wrote: > Hi, > > Doubling the number of memory regions worked, thanks. Like you've said, > that's just a band-aid, as there could be platforms out there for which > UEFI reports more regions than the static value that kvm-unit-tests > assumes. > > If you don't mind a suggestion, you could run two passes on the UEFI memory > map: the first pass finds the largest available memory region and uses that > for initializing the memory allocators (could also count the number of > memory regions that it finds, for example), the second pass creates the > mem_regions array by allocating it dynamically (the allocators have been > initialized in the previous pass). The same approach could be used when > booting without UEFI. > > Or you can just set NR_EXTRA_MEM_REGIONS to something very large and call > it a day :) Yeah, let's just bump it to something large. We should also ensure it's easy to debug when we hit the limit though. We have an assert() in mem_region_add() already, but maybe we don't have an assert() in the EFI code paths? Thanks, drew > > Thanks, > Alex > > On Mon, Aug 01, 2022 at 07:23:05PM +0100, Nikos Nikoleris wrote: > > Hi Alex, > > > > On 22/07/2022 15:41, Alexandru Elisei wrote: > > > Hi Nikos, > > > > > > On Fri, Jul 22, 2022 at 11:57:09AM +0100, Nikos Nikoleris wrote: > > > > Hi Alex, > > > > > > > > On 19/07/2022 16:28, Alexandru Elisei wrote: > > > > > Hi, > > > > > > > > > > I've been trying to test the seris and I've come across some issues. > > > [..] > > > > > > > > > > The second error I'm encountering is when I try the selftest-setup test: > > > > > > > > > > [..] > > > > > ProtectUefiImageCommon - 0x4D046040 > > > > > - 0x000000004BEC4000 - 0x000000000001F600 > > > > > SetUefiImageMemoryAttributes - 0x000000004BEC4000 - 0x0000000000001000 (0x0000000000004008) > > > > > SetUefiImageMemoryAttributes - 0x000000004BEC5000 - 0x0000000000010000 (0x0000000000020008) > > > > > SetUefiImageMemoryAttributes - 0x000000004BED5000 - 0x000000000000F000 (0x0000000000004008) > > > > > InstallProtocolInterface: 752F3136-4E16-4FDC-A22A-E5F46812F4CA 4F8014E8 > > > > > SetUefiImageMemoryAttributes - 0x000000004F640000 - 0x0000000000040000 (0x0000000000000008) > > > > > SetUefiImageMemoryAttributes - 0x000000004C2D0000 - 0x0000000000040000 (0x0000000000000008) > > > > > SetUefiImageMemoryAttributes - 0x000000004C280000 - 0x0000000000040000 (0x0000000000000008) > > > > > SetUefiImageMemoryAttributes - 0x000000004C230000 - 0x0000000000040000 (0x0000000000000008) > > > > > SetUefiImageMemoryAttributes - 0x000000004C140000 - 0x0000000000040000 (0x0000000000000008) > > > > > SetUefiImageMemoryAttributes - 0x000000004F600000 - 0x0000000000030000 (0x0000000000000008) > > > > > SetUefiImageMemoryAttributes - 0x000000004C040000 - 0x0000000000030000 (0x0000000000000008) > > > > > SetUefiImageMemoryAttributes - 0x000000004BFC0000 - 0x0000000000030000 (0x0000000000000008) > > > > > Load address: 4bec4000 > > > > > PC: 4beca400 PC offset: 6400 > > > > > Unhandled exception ec=0x25 (DABT_EL1) > > > > > Vector: 4 (el1h_sync) > > > > > ESR_EL1: 96000000, ec=0x25 (DABT_EL1) > > > > > FAR_EL1: 0000fffffffff0f8 (valid) > > > > > Exception frame registers: > > > > > pc : [<000000004beca400>] lr : [<000000004beca42c>] pstate: 400002c5 > > > > > sp : 000000004f7ffe40 > > > > > x29: 000000004f7ffff0 x28: 0000000000000000 > > > > > x27: 000000004d046040 x26: 0000000000000000 > > > > > x25: 0000000000000703 x24: 0000000000000050 > > > > > x23: 0000000009011000 x22: 0000000000000000 > > > > > x21: 000000000000001f x20: 0000fffffffff000 > > > > > x19: 0000000043f92000 x18: 0000000000000000 > > > > > x17: 00000000ffffa6ab x16: 000000004f513ebc > > > > > x15: 0000000000000002 x14: 000000004bed5000 > > > > > x13: 000000004bee4000 x12: 000000004bed4000 > > > > > x11: 000000004bec4000 x10: 000000004c03febc > > > > > x9 : 000000004bee2938 x8 : 0000000000000000 > > > > > x7 : 0000000000000000 x6 : 000000004bee2900 > > > > > x5 : 000000004bee2908 x4 : 0000000048000000 > > > > > x3 : 0000000048000000 x2 : 000000004bee2928 > > > > > x1 : 0000000000000003 x0 : ffffffffffffffff > > > > > > > > > > > > > > > EXIT: STATUS=127 > > > > > > > > > > The preceding lines were omitted for brevity, the entire log can be found > > > > > at [1] (expires in 6 months). > > > > > > > > > > Command used to launch the test: > > > > > > > > > > $ QEMU=/path/to/qemu/build/qemu-system-aarch64 EFI_UEFI=/path/to/QEMU_EFI.fd taskset -c 4-5 arm/efi/run arm/selftest.efi -smp 2 -m 256 -append "setup smp=2 mem=256" > > > > > > > > > > qemu has been built from source, tag v7.0.0, configured with: > > > > > > > > > > $ ./configure --target-list=aarch64-softmmu --disable-vnc --disable-gtk --disable-bpf > > > > > > > > > > EDK2 image has been built from commit e1eef3a8b01a ("NetworkPkg: Add Wi-Fi > > > > > Wpa3 support in WifiConnectManager"): > > > > > > > > > > $ build -a AARCH64 -t GCC5 -p ArmVirtPkg/ArmVirtQemu.dsc -b DEBUG > > > > > > > > > > I tried to disassemble selftest.efi: $ objdump -d selftest.efi, but there > > > > > were no debug symbols in the output and it was impossible to figure what is > > > > > going on. > > > > > > > > > > [1] https://pastebin.com/0mcap1BU > > > > > > > > I haven't been to able to reproduce this. I've build from source qemu and > > > > EDK2 from source (the revisions you provided) and I've used gcc-10 to > > > > compile KUT but selftest-smp passes. > > > > > > That's weird, I've compiled kvm-unit-tests with gcc 10.3.0 [1] and I'm still > > > seeing the error (tried it on my x86 machine), for both selftest-setup > > > selftest-smp. > > > > > > Did you compile qemu and edk2 with gcc 10.3.0? Or did you use some other > > > compiler? > > > > > > [1] https://developer.arm.com/-/media/Files/downloads/gnu-a/10.3-2021.07/binrel/gcc-arm-10.3-2021.07-x86_64-aarch64-none-linux-gnu.tar.xz > > > > > > > Thanks, I managed to reproduce this and found that with this configuration > > there are more mem_regions than the assumed max. To work around it you can > > change NR_EXTRA_MEM_REGIONS in lib/arm/setup.c to > > > > #define NR_EXTRA_MEM_REGIONS 32 > > > > Doubling it would hopefully be enough to run tests for now but I will also > > try to find out a better way to do this. > > > > Thanks, > > > > Nikos