From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94EF5C00140 for ; Fri, 5 Aug 2022 16:39:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240965AbiHEQj2 (ORCPT ); Fri, 5 Aug 2022 12:39:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240734AbiHEQj0 (ORCPT ); Fri, 5 Aug 2022 12:39:26 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 81A88796AB for ; Fri, 5 Aug 2022 09:39:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659717564; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+I5ZsPCfkVwG6t4JFqhJUTwZPW/syrVcX8A+brzC9fY=; b=VZE+5IP+FEme0hsfve+oKjxu5bCnwdgg3PLNiHAImiRWdzXJ8LOoDI3WJmW2dh6vuL5n7s ByBmJY2B3HYWAQJhkeaA6BLLfOR0ASO0hF22dUx2eNtOEYCXXSoZsPeoEeHRZZHQLpIcfp JLXjWufz2aClAdN/2NpcEXJcstPYIA4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-218-4L34OVOONJGJy8y7MqChBA-1; Fri, 05 Aug 2022 12:39:21 -0400 X-MC-Unique: 4L34OVOONJGJy8y7MqChBA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EA7568032FB; Fri, 5 Aug 2022 16:39:20 +0000 (UTC) Received: from eperezma.remote.csb (unknown [10.39.193.29]) by smtp.corp.redhat.com (Postfix) with ESMTP id 467452166B26; Fri, 5 Aug 2022 16:39:18 +0000 (UTC) From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= To: qemu-devel@nongnu.org Cc: Stefan Hajnoczi , Eli Cohen , Zhu Lingshan , "Michael S. Tsirkin" , Gautam Dawar , Stefano Garzarella , Parav Pandit , Cindy Lu , "Gonglei (Arei)" , Jason Wang , Cornelia Huck , kvm@vger.kernel.org, Paolo Bonzini , Liuxiangdong , Laurent Vivier , Harpreet Singh Anand Subject: [PATCH v4 2/6] vdpa: Use v->shadow_vqs_enabled in vhost_vdpa_svqs_start & stop Date: Fri, 5 Aug 2022 18:39:05 +0200 Message-Id: <20220805163909.872646-3-eperezma@redhat.com> In-Reply-To: <20220805163909.872646-1-eperezma@redhat.com> References: <20220805163909.872646-1-eperezma@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org This function used to trust in v->shadow_vqs != NULL to know if it must start svq or not. This is not going to be valid anymore, as qemu is going to allocate svq unconditionally (but it will only start them conditionally). Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-vdpa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c index 4b0cfc0f56..cc71ea750e 100644 --- a/hw/virtio/vhost-vdpa.c +++ b/hw/virtio/vhost-vdpa.c @@ -1029,7 +1029,7 @@ static bool vhost_vdpa_svqs_start(struct vhost_dev *dev) Error *err = NULL; unsigned i; - if (!v->shadow_vqs) { + if (!v->shadow_vqs_enabled) { return true; } @@ -1082,7 +1082,7 @@ static bool vhost_vdpa_svqs_stop(struct vhost_dev *dev) { struct vhost_vdpa *v = dev->opaque; - if (!v->shadow_vqs) { + if (!v->shadow_vqs_enabled) { return true; } -- 2.31.1