From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, Sean Christopherson <seanjc@google.com>,
Michal Luczaj <mhal@rbox.co>
Subject: [kvm-unit-tests PATCH v3 4/7] x86: Add helper to detect if forced emulation prefix is available
Date: Mon, 8 Aug 2022 16:47:04 +0000 [thread overview]
Message-ID: <20220808164707.537067-5-seanjc@google.com> (raw)
In-Reply-To: <20220808164707.537067-1-seanjc@google.com>
Add a helper to detect whether or not KVM's forced emulation prefix is
available. Use the helper to replace equivalent functionality in the
emulator test.
Signed-off-by: Sean Christopherson <seanjc@google.com>
---
lib/x86/desc.h | 14 ++++++++++++++
x86/emulator.c | 15 +--------------
2 files changed, 15 insertions(+), 14 deletions(-)
diff --git a/lib/x86/desc.h b/lib/x86/desc.h
index 8f708fd..c023b93 100644
--- a/lib/x86/desc.h
+++ b/lib/x86/desc.h
@@ -106,6 +106,20 @@ typedef struct __attribute__((packed)) {
#define KVM_FEP "ud2; .byte 'k', 'v', 'm';"
#define ASM_TRY_FEP(catch) __ASM_TRY(KVM_FEP, catch)
+static inline bool is_fep_available(void)
+{
+ /*
+ * Use the non-FEP ASM_TRY() as KVM will inject a #UD on the prefix
+ * itself if forced emulation is not available.
+ */
+ asm goto(ASM_TRY("%l[fep_unavailable]")
+ KVM_FEP "nop\n\t"
+ ::: "memory" : fep_unavailable);
+ return true;
+fep_unavailable:
+ return false;
+}
+
/*
* selector 32-bit 64-bit
* 0x00 NULL descriptor NULL descriptor
diff --git a/x86/emulator.c b/x86/emulator.c
index 6dc88f1..e1272a6 100644
--- a/x86/emulator.c
+++ b/x86/emulator.c
@@ -17,10 +17,6 @@
static int exceptions;
-/* Forced emulation prefix, used to invoke the emulator unconditionally. */
-#define KVM_FEP_LENGTH 5
-static int fep_available = 1;
-
struct regs {
u64 rax, rbx, rcx, rdx;
u64 rsi, rdi, rsp, rbp;
@@ -1121,12 +1117,6 @@ static void test_illegal_movbe(void)
handle_exception(UD_VECTOR, 0);
}
-static void record_no_fep(struct ex_regs *regs)
-{
- fep_available = 0;
- regs->rip += KVM_FEP_LENGTH;
-}
-
int main(void)
{
void *mem;
@@ -1136,9 +1126,6 @@ int main(void)
unsigned long t1, t2;
setup_vm();
- handle_exception(UD_VECTOR, record_no_fep);
- asm(KVM_FEP "nop");
- handle_exception(UD_VECTOR, 0);
mem = alloc_vpages(2);
install_page((void *)read_cr3(), IORAM_BASE_PHYS, mem);
@@ -1190,7 +1177,7 @@ int main(void)
test_ltr(mem);
test_cmov(mem);
- if (fep_available) {
+ if (is_fep_available()) {
test_mmx_movq_mf(mem);
test_movabs(mem);
test_smsw_reg(mem);
--
2.37.1.559.g78731f0fdb-goog
next prev parent reply other threads:[~2022-08-08 16:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-08 16:47 [kvm-unit-tests PATCH v3 0/7] x86: Illegal LEA test and FEP cleanups Sean Christopherson
2022-08-08 16:47 ` [kvm-unit-tests PATCH v3 1/7] x86: emulator.c: Save and restore exception handlers Sean Christopherson
2022-08-08 16:47 ` [kvm-unit-tests PATCH v3 2/7] x86: Dedup 32-bit vs. 64-bit ASM_TRY() by stealing kernel's __ASM_SEL() Sean Christopherson
2022-08-08 16:47 ` [kvm-unit-tests PATCH v3 3/7] x86: Introduce ASM_TRY_FEP() to handle exceptions on forced emulation Sean Christopherson
2022-08-08 16:47 ` Sean Christopherson [this message]
2022-08-08 16:47 ` [kvm-unit-tests PATCH v3 5/7] x86: emulator.c: Use ASM_TRY() for the UD_VECTOR cases Sean Christopherson
2022-08-08 16:47 ` [kvm-unit-tests PATCH v3 6/7] x86: Test emulator's handling of LEA with /reg Sean Christopherson
2022-08-08 16:47 ` [kvm-unit-tests PATCH v3 7/7] x86/pmu: Run the "emulation" test iff forced emulation is available Sean Christopherson
2022-08-10 19:06 ` [kvm-unit-tests PATCH v3 0/7] x86: Illegal LEA test and FEP cleanups Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220808164707.537067-5-seanjc@google.com \
--to=seanjc@google.com \
--cc=kvm@vger.kernel.org \
--cc=mhal@rbox.co \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).