From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFC28ECAAA1 for ; Sat, 3 Sep 2022 00:23:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231443AbiICAX0 (ORCPT ); Fri, 2 Sep 2022 20:23:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231274AbiICAXO (ORCPT ); Fri, 2 Sep 2022 20:23:14 -0400 Received: from mail-pf1-x44a.google.com (mail-pf1-x44a.google.com [IPv6:2607:f8b0:4864:20::44a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AB89F63D8 for ; Fri, 2 Sep 2022 17:23:13 -0700 (PDT) Received: by mail-pf1-x44a.google.com with SMTP id x25-20020aa79199000000b005358eeebf49so1733742pfa.17 for ; Fri, 02 Sep 2022 17:23:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date; bh=Jc8tRpF99XNZU8n/zffImYz5blGtS9807hd1TKthgTk=; b=d+xh8WQ/+GTZy4U7G4pl3sLVfJ2oq6oyYhl7nGeBkTD6wNGtYwT5zuAushnn3gMO/w aB3GGtJsTSOnvcLV3HyzranfOaWf4ChYJx2OQxbJHlPNBN4K5Syw9PJ+Mm2V0+SnIxMN u2XVaQUxZc/03nQ9bVjDJuGQvW++RG06IY71UXJ9n93kVuQWe/y6Bwq72lKNhS4gMeeH R2B6yW2Lcwo6o1NhzPnBA6HqCPQo/En06xiUG1US56mKmWEgH0SRHjf5PnIVeYxFMdF3 9fnLFi47dEh/cXENyqaFaGyVYbd+7Z9scAmi5t1Mxtpk6RNFMv8TZp5bpBzWXF70iExn pGJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date; bh=Jc8tRpF99XNZU8n/zffImYz5blGtS9807hd1TKthgTk=; b=o1m6c5s8SgMn6184J2j4L2NZgxpw6ZOmc/Mz/ax3dNGhoYfqP3kIyOL9GRt5YljBI2 3tJZcnt6wwr5hRrwNN6axxBtlm4g61ksqk+blQqiiaVdLWFCy9NikucfbmkOMTXYdvZw oPqesEvqIhQfV8S2myCQifBgfLsLcGsHUMrrmmqQRcT32kqOlLpcOd/TaLaRYbLF1uOA 86LMs5Sf4E3WL/gFjdPMzgZNoy79v/x52KqvrnSVgziqHgibiek2jvxWGYPjIgSY9jFl oQWcqixyoyucWe+UFPM2CgKOVDd0L3xkS3lT2rtM5FN72iMNSbYuW5WxwoIw55ufMiXB DCXQ== X-Gm-Message-State: ACgBeo3L5y5CrgbuXBuMFGgtOHL+USE+Gj1j6kBDfh++Jsb+SMPU5ZE3 Y5GeY9ifGqpjXCTxJHCBhULifhiKoYM= X-Google-Smtp-Source: AA6agR71SBaZCeDyyRaHmxa0LZCa3oA0kjUUtNmD6qTohE8KIzS0YM497vbBYfyrfgAWMl0Fnezg669BY1A= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6a00:1308:b0:53a:9663:1c19 with SMTP id j8-20020a056a00130800b0053a96631c19mr18133933pfu.60.1662164592882; Fri, 02 Sep 2022 17:23:12 -0700 (PDT) Reply-To: Sean Christopherson Date: Sat, 3 Sep 2022 00:22:39 +0000 In-Reply-To: <20220903002254.2411750-1-seanjc@google.com> Mime-Version: 1.0 References: <20220903002254.2411750-1-seanjc@google.com> X-Mailer: git-send-email 2.37.2.789.g6183377224-goog Message-ID: <20220903002254.2411750-9-seanjc@google.com> Subject: [PATCH v2 08/23] KVM: SVM: Fix x2APIC Logical ID calculation for avic_kick_target_vcpus_fast From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Suravee Suthikulpanit , Maxim Levitsky , Li RongQing Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org From: Suravee Suthikulpanit For X2APIC ID in cluster mode, the logical ID is bit [15:0]. Fixes: 603ccef42ce9 ("KVM: x86: SVM: fix avic_kick_target_vcpus_fast") Cc: Maxim Levitsky Signed-off-by: Suravee Suthikulpanit Reviewed-by: Maxim Levitsky Signed-off-by: Sean Christopherson --- arch/x86/kvm/svm/avic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/svm/avic.c b/arch/x86/kvm/svm/avic.c index 50721c9167c4..163edc42f979 100644 --- a/arch/x86/kvm/svm/avic.c +++ b/arch/x86/kvm/svm/avic.c @@ -383,7 +383,7 @@ static int avic_kick_target_vcpus_fast(struct kvm *kvm, struct kvm_lapic *source if (apic_x2apic_mode(source)) { /* 16 bit dest mask, 16 bit cluster id */ - bitmap = dest & 0xFFFF0000; + bitmap = dest & 0xFFFF; cluster = (dest >> 16) << 4; } else if (kvm_lapic_get_reg(source, APIC_DFR) == APIC_DFR_FLAT) { /* 8 bit dest mask*/ -- 2.37.2.789.g6183377224-goog