From: Reiji Watanabe <reijiw@google.com>
To: Marc Zyngier <maz@kernel.org>, kvmarm@lists.cs.columbia.edu
Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Ricardo Koller <ricarkol@google.com>,
Oliver Upton <oliver.upton@linux.dev>,
Jing Zhang <jingzhangos@google.com>,
Raghavendra Rao Anata <rananta@google.com>,
Reiji Watanabe <reijiw@google.com>
Subject: [PATCH v2 0/4] KVM: arm64: Fix bugs of single-step execution enabled by userspace
Date: Fri, 16 Sep 2022 18:05:56 -0700 [thread overview]
Message-ID: <20220917010600.532642-1-reijiw@google.com> (raw)
This series fixes two bugs of single-step execution enabled by
userspace, and add a test case for KVM_GUESTDBG_SINGLESTEP to
the debug-exception test to verify the single-step behavior.
Patch 1 fixes a bug that KVM might unintentionally change PSTATE.SS
for the guest when single-step execution is enabled for the vCPU by
userspace.
Patch 2 fixes a bug that KVM could erroneously perform an extra
single step (without returning to userspace) due to setting PSTATE.SS
to 1 on every guest entry, when single-step execution is enabled for
the vCPU by userspace.
Patch 3-4 adds a test for KVM_GUESTDBG_SINGLESTEP to the
debug-exception test to verify the single-step behavior.
The series is based on 6.0-rc5.
v2:
- Change kvm_handle_guest_debug() to use switch/case statement [Marc]
- Clear PSTATE.SS on guest entry if the Software step state at the
last guest exit was "Active-pending" to make DBG_SS_ACTIVE_PENDING
and PSTATE.SS consistent [Marc]
- Add a fix to preserve PSTATE.SS for the guest.
v1: https://lore.kernel.org/all/20220909044636.1997755-1-reijiw@google.com/
Reiji Watanabe (4):
KVM: arm64: Preserve PSTATE.SS for the guest while single-step is
enabled
KVM: arm64: Clear PSTATE.SS when the Software Step state was
Active-pending
KVM: arm64: selftests: Refactor debug-exceptions to make it amenable
to new test cases
KVM: arm64: selftests: Add a test case for KVM_GUESTDBG_SINGLESTEP
arch/arm64/include/asm/kvm_host.h | 4 +
arch/arm64/kvm/debug.c | 34 +++-
arch/arm64/kvm/guest.c | 1 +
arch/arm64/kvm/handle_exit.c | 8 +-
.../selftests/kvm/aarch64/debug-exceptions.c | 149 +++++++++++++++++-
5 files changed, 190 insertions(+), 6 deletions(-)
base-commit: 80e78fcce86de0288793a0ef0f6acf37656ee4cf
--
2.37.3.968.ga6b4b080e4-goog
next reply other threads:[~2022-09-17 1:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 1:05 Reiji Watanabe [this message]
2022-09-17 1:05 ` [PATCH v2 1/4] KVM: arm64: Preserve PSTATE.SS for the guest while single-step is enabled Reiji Watanabe
2022-09-17 1:05 ` [PATCH v2 2/4] KVM: arm64: Clear PSTATE.SS when the Software Step state was Active-pending Reiji Watanabe
2022-09-17 1:05 ` [PATCH v2 3/4] KVM: arm64: selftests: Refactor debug-exceptions to make it amenable to new test cases Reiji Watanabe
2022-09-17 1:06 ` [PATCH v2 4/4] KVM: arm64: selftests: Add a test case for KVM_GUESTDBG_SINGLESTEP Reiji Watanabe
2022-09-19 9:36 ` Marc Zyngier
2022-09-20 2:13 ` Reiji Watanabe
2022-09-19 10:04 ` [PATCH v2 0/4] KVM: arm64: Fix bugs of single-step execution enabled by userspace Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220917010600.532642-1-reijiw@google.com \
--to=reijiw@google.com \
--cc=alexandru.elisei@arm.com \
--cc=james.morse@arm.com \
--cc=jingzhangos@google.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=pbonzini@redhat.com \
--cc=rananta@google.com \
--cc=ricarkol@google.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).