kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, Sean Christopherson <seanjc@google.com>,
	Manali Shukla <manali.shukla@amd.com>
Subject: [kvm-unit-tests PATCH v3 4/9] nVMX: Drop one-off INT3=>#BP test
Date: Wed,  5 Oct 2022 23:52:07 +0000	[thread overview]
Message-ID: <20221005235212.57836-5-seanjc@google.com> (raw)
In-Reply-To: <20221005235212.57836-1-seanjc@google.com>

Drop the dedicated INT3=>#BP test, it's a subset of what is covered by
the INT3=>#BP case in the generic exceptions test.

Signed-off-by: Sean Christopherson <seanjc@google.com>
---
 x86/vmx_tests.c | 26 --------------------------
 1 file changed, 26 deletions(-)

diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c
index edb8062..368ad43 100644
--- a/x86/vmx_tests.c
+++ b/x86/vmx_tests.c
@@ -2136,31 +2136,6 @@ static int disable_rdtscp_exit_handler(union exit_reason exit_reason)
 	return VMX_TEST_VMEXIT;
 }
 
-static int int3_init(struct vmcs *vmcs)
-{
-	vmcs_write(EXC_BITMAP, ~0u);
-	return VMX_TEST_START;
-}
-
-static void int3_guest_main(void)
-{
-	asm volatile ("int3");
-}
-
-static int int3_exit_handler(union exit_reason exit_reason)
-{
-	u32 intr_info = vmcs_read(EXI_INTR_INFO);
-
-	report(exit_reason.basic == VMX_EXC_NMI &&
-	       (intr_info & INTR_INFO_VALID_MASK) &&
-	       (intr_info & INTR_INFO_VECTOR_MASK) == BP_VECTOR &&
-	       ((intr_info & INTR_INFO_INTR_TYPE_MASK) >>
-	        INTR_INFO_INTR_TYPE_SHIFT) == VMX_INTR_TYPE_SOFT_EXCEPTION,
-	       "L1 intercepts #BP");
-
-	return VMX_TEST_VMEXIT;
-}
-
 static void exit_monitor_from_l2_main(void)
 {
 	printf("Calling exit(0) from l2...\n");
@@ -10795,7 +10770,6 @@ struct vmx_test vmx_tests[] = {
 	{ "vmmcall", vmmcall_init, vmmcall_main, vmmcall_exit_handler, NULL, {0} },
 	{ "disable RDTSCP", disable_rdtscp_init, disable_rdtscp_main,
 		disable_rdtscp_exit_handler, NULL, {0} },
-	{ "int3", int3_init, int3_guest_main, int3_exit_handler, NULL, {0} },
 	{ "exit_monitor_from_l2_test", NULL, exit_monitor_from_l2_main,
 		exit_monitor_from_l2_handler, NULL, {0} },
 	{ "invalid_msr", invalid_msr_init, invalid_msr_main,
-- 
2.38.0.rc1.362.ged0d419d3c-goog


  parent reply	other threads:[~2022-10-05 23:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-05 23:52 [kvm-unit-tests PATCH v3 0/9] x86: n{VMX,SVM} exception tests Sean Christopherson
2022-10-05 23:52 ` [kvm-unit-tests PATCH v3 1/9] nVMX: Add "nop" after setting EFLAGS.TF to guarantee single-step #DB Sean Christopherson
2022-10-05 23:52 ` [kvm-unit-tests PATCH v3 2/9] x86: Move helpers to generate misc exceptions to processor.h Sean Christopherson
2022-10-05 23:52 ` [kvm-unit-tests PATCH v3 3/9] nVMX: Move #OF test to generic exceptions test Sean Christopherson
2022-10-05 23:52 ` Sean Christopherson [this message]
2022-10-05 23:52 ` [kvm-unit-tests PATCH v3 5/9] x86: nSVM: Add an exception test framework and tests Sean Christopherson
2022-10-05 23:52 ` [kvm-unit-tests PATCH v3 6/9] x86: nSVM: Move #BP test to exception test framework Sean Christopherson
2022-10-05 23:52 ` [kvm-unit-tests PATCH v3 7/9] x86: nSVM: Move #OF " Sean Christopherson
2022-10-05 23:52 ` [kvm-unit-tests PATCH v3 8/9] x86: nSVM: Move part of #NM " Sean Christopherson
2022-10-05 23:52 ` [kvm-unit-tests PATCH v3 9/9] nVMX: Move #NM test to generic " Sean Christopherson
2022-10-12  4:17 ` [kvm-unit-tests PATCH v3 0/9] x86: n{VMX,SVM} exception tests Manali Shukla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221005235212.57836-5-seanjc@google.com \
    --to=seanjc@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=manali.shukla@amd.com \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).