From: Shaoqin Huang <shahuang@redhat.com>
To: kvmarm@lists.linux.dev
Cc: Shaoqin Huang <shahuang@redhat.com>,
Eric Auger <eric.auger@redhat.com>,
Andrew Jones <andrew.jones@linux.dev>,
kvm@vger.kernel.org (open list:ARM)
Subject: [kvm-unit-tests PATCH v3 1/3] arm: gic: Write one bit per time in gic_irq_set_clr_enable()
Date: Thu, 2 Mar 2023 22:11:45 -0500 [thread overview]
Message-ID: <20230303031148.162816-2-shahuang@redhat.com> (raw)
In-Reply-To: <20230303031148.162816-1-shahuang@redhat.com>
When use gic_irq_set_clr_enable() to disable an interrupt, it will
disable all interrupt since it first read from Interrupt Clear-Enable
Registers where '1' indicates that forwarding of the corresponding
interrupt is enabled and then write this value with a mask into
Interrupt Clear-Enable Registers where '1' indicates disable the
forwarding of the corresponding interrupt.
So directly write one bit per time to enable or disable interrupt.
Fixes: cb573c2 ("arm: gic: Introduce gic_irq_set_clr_enable() helper")
Signed-off-by: Shaoqin Huang <shahuang@redhat.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
---
lib/arm/gic.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/lib/arm/gic.c b/lib/arm/gic.c
index 1bfcfcf..89a15fe 100644
--- a/lib/arm/gic.c
+++ b/lib/arm/gic.c
@@ -176,7 +176,6 @@ void gic_ipi_send_mask(int irq, const cpumask_t *dest)
void gic_irq_set_clr_enable(int irq, bool enable)
{
u32 offset, split = 32, shift = (irq % 32);
- u32 reg, mask = BIT(shift);
void *base;
assert(irq < 1020);
@@ -199,8 +198,7 @@ void gic_irq_set_clr_enable(int irq, bool enable)
assert(0);
}
base += offset + (irq / split) * 4;
- reg = readl(base);
- writel(reg | mask, base);
+ writel(BIT(shift), base);
}
enum gic_irq_state gic_irq_state(int irq)
--
2.39.1
next prev parent reply other threads:[~2023-03-03 3:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 3:11 [kvm-unit-tests PATCH v3 0/3] arm: Use gic_enable/disable_irq() macro to clean up code Shaoqin Huang
2023-03-03 3:11 ` Shaoqin Huang [this message]
2023-03-03 3:11 ` [kvm-unit-tests PATCH v3 2/3] arm64: timer: Use gic_enable/disable_irq() macro in timer test Shaoqin Huang
2023-03-03 3:11 ` [kvm-unit-tests PATCH v3 3/3] arm64: microbench: Use gic_enable_irq() macro in microbench test Shaoqin Huang
2023-03-07 13:44 ` [kvm-unit-tests PATCH v3 0/3] arm: Use gic_enable/disable_irq() macro to clean up code Zenghui Yu
2023-03-21 15:41 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230303031148.162816-2-shahuang@redhat.com \
--to=shahuang@redhat.com \
--cc=andrew.jones@linux.dev \
--cc=eric.auger@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).