From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Huacai Chen <chenhuacai@kernel.org>
Cc: Yu Zhao <yuzhao@google.com>,
aleksandar.qemu.devel@gmail.com, jiaxun.yang@flygoat.com,
kvm@vger.kernel.org, linux-mips@vger.kernel.org,
pbonzini@redhat.com, robh+dt@kernel.org, zhangfx@lemote.com
Subject: Re: [PATCH 5/5] MAINTAINERS: Update KVM/MIPS maintainers
Date: Sun, 18 Jun 2023 09:55:54 +0200 [thread overview]
Message-ID: <20230618075554.GA2858@alpha.franken.de> (raw)
In-Reply-To: <CAAhV-H54aipF6jXAiGpcjzpDy06Q28hmx-p4msvxgASHU5Z+cw@mail.gmail.com>
On Fri, Jun 16, 2023 at 04:31:13PM +0800, Huacai Chen wrote:
> On Fri, Jun 16, 2023 at 4:23 PM Thomas Bogendoerfer
> <tsbogend@alpha.franken.de> wrote:
> >
> > index 957121a495f0..04cedf9f8811 100644
> > --- a/arch/mips/include/asm/kvm_host.h
> > +++ b/arch/mips/include/asm/kvm_host.h
> > @@ -317,7 +317,7 @@ struct kvm_vcpu_arch {
> > unsigned int aux_inuse;
> >
> > /* COP0 State */
> > - struct mips_coproc *cop0;
> > + struct mips_coproc cop0;
> Maybe keeping it as a pointer and allocate in kvm_arch_vcpu_create()
> is better? (smaller modification)
I thought about it, but then we have another dynmic object, which we
need to care about lifetime. And I don't think we need *cop any longer,
so this cleanes up the code and makes it even slightly faster.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2023-06-18 7:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 6:58 [PATCH 1/5] PCI: Move PCI_VENDOR_ID_REDHAT definition to pci_ids.h Huacai Chen
2020-07-29 6:58 ` [PATCH 2/5] dt-bindings: mips: Document Loongson kvm guest board Huacai Chen
2020-07-29 9:52 ` Thomas Bogendoerfer
2020-07-29 10:08 ` Huacai Chen
2020-07-31 3:01 ` Huacai Chen
2020-07-31 8:32 ` Thomas Bogendoerfer
2020-07-31 11:56 ` Jiaxun Yang
2020-08-03 6:05 ` Huacai Chen
2020-08-03 9:13 ` Jiaxun Yang
2020-08-04 7:47 ` Thomas Bogendoerfer
2020-07-29 6:58 ` [PATCH 3/5] MIPS: KVM: Add kvm guest support for Loongson-3 Huacai Chen
2020-07-29 6:58 ` [PATCH 4/5] MIPS: Update default config file " Huacai Chen
2020-07-29 6:58 ` [PATCH 5/5] MAINTAINERS: Update KVM/MIPS maintainers Huacai Chen
2023-06-16 7:18 ` Yu Zhao
2023-06-16 7:55 ` Huacai Chen
2023-06-16 8:23 ` Thomas Bogendoerfer
2023-06-16 8:31 ` Huacai Chen
2023-06-18 7:55 ` Thomas Bogendoerfer [this message]
2023-06-17 1:52 ` Yu Zhao
2023-06-18 2:13 ` Huacai Chen
2023-06-18 2:51 ` Yu Zhao
2023-06-26 8:00 ` Huacai Chen
2023-06-27 18:58 ` Yu Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230618075554.GA2858@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=chenhuacai@kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=robh+dt@kernel.org \
--cc=yuzhao@google.com \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).