From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00BA4C678D5 for ; Tue, 7 Mar 2023 23:04:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229483AbjCGXES (ORCPT ); Tue, 7 Mar 2023 18:04:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229486AbjCGXEQ (ORCPT ); Tue, 7 Mar 2023 18:04:16 -0500 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17C84170E for ; Tue, 7 Mar 2023 15:04:10 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 44D1037E2EEB25; Tue, 7 Mar 2023 17:04:09 -0600 (CST) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id IlPjxeNIrp4J; Tue, 7 Mar 2023 17:04:08 -0600 (CST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 915FC37E2EEB22; Tue, 7 Mar 2023 17:04:08 -0600 (CST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com 915FC37E2EEB22 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1678230248; bh=iMYGSf2afoxLHQ3zrDyYQkr9xwmllgL4UkjuYFF5aHE=; h=Date:From:To:Message-ID:MIME-Version; b=jd8aTUGQGabGJlDJwbDhloBY950yxY0mwlqcYOcVw/JMLWTI3pTINfQVLdA8Hl3qa Rdp8BktaIlAjX19jrvVA1QzJt3V6nY5HOWwBb+4/m3tNWjxwcIyoq9TGIUGhWdTNvH Oj/U6BKUEJWdTPKSF9OvW3l282FRDwoFSoIc6yZM= X-Virus-Scanned: amavisd-new at rptsys.com Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id qWk48AVCWoEv; Tue, 7 Mar 2023 17:04:08 -0600 (CST) Received: from vali.starlink.edu (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 71EBD37E2EEB1F; Tue, 7 Mar 2023 17:04:08 -0600 (CST) Date: Tue, 7 Mar 2023 17:04:08 -0600 (CST) From: Timothy Pearson To: Alex Williamson Cc: kvm , linuxppc-dev Message-ID: <2041059418.17313605.1678230248429.JavaMail.zimbra@raptorengineeringinc.com> In-Reply-To: <20230306175941.1b69bb14.alex.williamson@redhat.com> References: <8398361.16996856.1678123793664.JavaMail.zimbra@raptorengineeringinc.com> <20230306164607.1455ee81.alex.williamson@redhat.com> <1817332573.17073558.1678149322645.JavaMail.zimbra@raptorengineeringinc.com> <20230306175941.1b69bb14.alex.williamson@redhat.com> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Mailer: Zimbra 8.5.0_GA_3042 (ZimbraWebClient - GC111 (Linux)/8.5.0_GA_3042) Thread-Topic: Reenable VFIO support on POWER systems Thread-Index: AqxVp3QA/h1l1cNNA2UA4xRRSqM9KQ== Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org ----- Original Message ----- > From: "Alex Williamson" > To: "Timothy Pearson" > Cc: "kvm" , "linuxppc-dev" > Sent: Monday, March 6, 2023 6:59:41 PM > Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems > On Mon, 6 Mar 2023 18:35:22 -0600 (CST) > Timothy Pearson wrote: > >> ----- Original Message ----- >> > From: "Alex Williamson" >> > To: "Timothy Pearson" >> > Cc: "kvm" , "linuxppc-dev" >> > Sent: Monday, March 6, 2023 5:46:07 PM >> > Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems >> >> > On Mon, 6 Mar 2023 11:29:53 -0600 (CST) >> > Timothy Pearson wrote: >> > >> >> This patch series reenables VFIO support on POWER systems. It >> >> is based on Alexey Kardashevskiys's patch series, rebased and >> >> successfully tested under QEMU with a Marvell PCIe SATA controller >> >> on a POWER9 Blackbird host. >> >> >> >> Alexey Kardashevskiy (3): >> >> powerpc/iommu: Add "borrowing" iommu_table_group_ops >> >> powerpc/pci_64: Init pcibios subsys a bit later >> >> powerpc/iommu: Add iommu_ops to report capabilities and allow blocking >> >> domains >> >> >> >> Timothy Pearson (1): >> >> Add myself to MAINTAINERS for Power VFIO support >> >> >> >> MAINTAINERS | 5 + >> >> arch/powerpc/include/asm/iommu.h | 6 +- >> >> arch/powerpc/include/asm/pci-bridge.h | 7 + >> >> arch/powerpc/kernel/iommu.c | 246 +++++++++++++++++++++- >> >> arch/powerpc/kernel/pci_64.c | 2 +- >> >> arch/powerpc/platforms/powernv/pci-ioda.c | 36 +++- >> >> arch/powerpc/platforms/pseries/iommu.c | 27 +++ >> >> arch/powerpc/platforms/pseries/pseries.h | 4 + >> >> arch/powerpc/platforms/pseries/setup.c | 3 + >> >> drivers/vfio/vfio_iommu_spapr_tce.c | 96 ++------- >> >> 10 files changed, 338 insertions(+), 94 deletions(-) >> >> >> > >> > For vfio and MAINTAINERS portions, >> > >> > Acked-by: Alex Williamson >> > >> > I'll note though that spapr_tce_take_ownership() looks like it copied a >> > bug from the old tce_iommu_take_ownership() where tbl and tbl->it_map >> > are tested before calling iommu_take_ownership() but not in the unwind >> > loop, ie. tables we might have skipped on setup are unconditionally >> > released on unwind. Thanks, >> > >> > Alex >> >> Thanks for that. I'll put together a patch to get rid of that >> potential bug that can be applied after this series is merged, unless >> you'd rather I resubmit a v3 with the issue fixed? > > Follow-up fix is fine by me. Thanks, > > Alex Just sent that patch in. Thanks!