From: Paolo Bonzini <pbonzini@redhat.com>
To: Maxim Levitsky <mlevitsk@redhat.com>,
Sean Christopherson <seanjc@google.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: disable on 32-bit unless CONFIG_BROKEN
Date: Thu, 29 Sep 2022 17:07:06 +0200 [thread overview]
Message-ID: <205b4d01-db86-6662-7906-24a8ca765e4f@redhat.com> (raw)
In-Reply-To: <b8fa9561295bb6af2b7fcaa8125c6a3b89b305c7.camel@redhat.com>
On 9/29/22 15:52, Maxim Levitsky wrote:
> On Thu, 2022-09-29 at 15:26 +0200, Paolo Bonzini wrote:
>> On 9/28/22 19:55, Sean Christopherson wrote:
>>>> As far as my opinion goes I do volunteer to test this code more often,
>>>> and I do not want to see the 32 bit KVM support be removed*yet*.
>>>
>>> Yeah, I 100% agree that it shouldn't be removed until we have equivalent test
>>> coverage. But I do think it should an "off-by-default" sort of thing. Maybe
>>> BROKEN is the wrong dependency though? E.g. would EXPERT be a better option?
>>
>> Yeah, maybe EXPERT is better but I'm not sure of the equivalent test
>> coverage. 32-bit VMX/SVM kvm-unit-tests are surely a good idea, but
>> what's wrong with booting an older guest?
>
> From my point of view, using the same kernel source for host and the guest
> is easier because you know that both kernels behave the same.
It is certainly easier, but it is less correct. You don't cover
anything that KVM doesn't use.
> About EXPERT, IMHO these days most distros already dropped 32 bit suport thus anyway
> one needs to compile a recent 32 bit kernel manually - thus IMHO whoever
> these days compiles a 32 bit kernel, knows what they are doing.
>
> I personally would wait few more releases when there is a pressing reason to remove
> this support.
>
> AFAIK, it is not really possible to remove most of the legacy direct mmu
> because shadowing mmu still can use it (I think Sean told me that once).
Yeah, it won't let us remove a lot of code but there are several logic
cleanups that become possible if the TDP case can just assume the TDP
MMU is there. For example, there is no reason to have a cpu_role (as
opposed to an mmu_page_role for the root) if you are building HPA->GPA
page tables.
(Which reminds me that toggling CR0.WP is still a hog with the TDP MMU).
Paolo
next prev parent reply other threads:[~2022-09-29 15:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 16:51 [PATCH] KVM: x86: disable on 32-bit unless CONFIG_BROKEN Paolo Bonzini
2022-09-27 17:07 ` Sean Christopherson
2022-09-28 7:10 ` Maxim Levitsky
2022-09-28 9:55 ` Paolo Bonzini
2022-09-28 16:12 ` Sean Christopherson
2022-09-28 17:43 ` Maxim Levitsky
2022-09-28 17:44 ` Maxim Levitsky
2022-09-28 17:55 ` Sean Christopherson
2022-09-29 13:26 ` Paolo Bonzini
2022-09-29 13:52 ` Maxim Levitsky
2022-09-29 15:07 ` Paolo Bonzini [this message]
2023-02-17 19:36 ` Thomas Huth
2023-02-22 22:27 ` Sean Christopherson
2023-02-23 7:01 ` Thomas Huth
2023-02-23 8:33 ` Maxim Levitsky
2023-02-23 22:10 ` Sean Christopherson
2023-02-24 6:28 ` Thomas Huth
2022-09-28 10:04 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=205b4d01-db86-6662-7906-24a8ca765e4f@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlevitsk@redhat.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).