From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Zupka Subject: Re: [KVM-AUTOTEST PATCH 1/2] Add KSM test Date: Tue, 15 Sep 2009 14:58:56 -0400 (EDT) Message-ID: <214789605.186631253041136557.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> References: <1785968988.186531253041095308.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Lukas Doktor , dlaor@redhat.com To: kvm@vger.kernel.org, autotest@test.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:12370 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757953AbZIOS6y (ORCPT ); Tue, 15 Sep 2009 14:58:54 -0400 In-Reply-To: <1785968988.186531253041095308.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: > After a quick review I have the following questions: > 1. Why did you implement the guest tool in 'c' and not in python? > Python is much simpler and you can share some code with the server. > This 'test protocol' would also be easier to understand this way. We need speed and the precise control of allocate memory in pages. > 2. IMHO there is no need to use select, you can do blocking read. We replace socket communication by interactive program communication via ssh/telnet > 3. Also you can use plain malloc without the more complex ( a bit) mmap. We need address exactly the memory pages. We can't allow shift of the data in memory.