From: "Bae, Chang Seok" <email@example.com>
To: Borislav Petkov <firstname.lastname@example.org>
Cc: Andy Lutomirski <email@example.com>,
Thomas Gleixner <firstname.lastname@example.org>,
"Brown, Len" <email@example.com>,
"Hansen, Dave" <firstname.lastname@example.org>,
"Liu, Jing2" <email@example.com>,
"Shankar, Ravi V" <firstname.lastname@example.org>,
Subject: Re: [PATCH v3 06/21] x86/fpu/xstate: Calculate and remember dynamic xstate buffer sizes
Date: Wed, 3 Feb 2021 02:54:03 +0000 [thread overview]
Message-ID: <215C3E0E-EFBC-4842-92C8-C715F6A1B3B0@intel.com> (raw)
On Jan 27, 2021, at 01:38, Borislav Petkov <email@example.com> wrote:
> On Wed, Jan 27, 2021 at 01:23:35AM +0000, Bae, Chang Seok wrote:
>> Okay. I will prepare a separate cleanup patch that can be applied at the end
>> of the series. Will post the change in this thread at first.
> No, this is not how this works. Imagine you pile up a patch at the end
> for each review feedback you've gotten. No, this will be an insane churn
> and an unreviewable mess.
> What you do is you rework your patches like everyone else.
Yeah, it makes sense. I will post v4.
> Also, thinking about this more, I'm wondering if all those
> xstate-related attributes shouldn't be part of struct fpu instead of
> being scattered around like that.
> That thing - struct fpu * - gets passed in everywhere anyway so all that
> min_size, max_size, ->xstate_ptr and whatever, looks like it wants to be
> part of struct fpu. Then maybe you won't need the accessors...
Well, min_size and max_size are not task-specific. So, it will be wasteful to
include in struct fpu.
I will follow your suggestion to add new helpers to access the size values,
instead of exporting them.
>>>> @@ -627,13 +627,18 @@ static void check_xstate_against_struct(int nr)
>>> <-- There's a comment over this function that might need adjustment.
>> Do you mean an empty line? (Just want to clarify.)
> No, I mean this comment:
> * Dynamic XSAVE features allocate their own buffers and are not
> * covered by these checks. Only the size of the buffer for task->fpu
> * is checked here.
> That probably needs adjusting as you do set min and max size here now
> for the dynamic buffer.
Oh, I see. Thank you.
>> Agreed. I will prepare a patch. At least will post the diff here.
> You can send it separately from this patchset, ontop of current
> tip/master, so that I can take it now.
Posted, . After all, the proposal is to remove the helper.
next prev parent reply other threads:[~2021-02-03 2:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <firstname.lastname@example.org>
2020-12-23 15:56 ` [PATCH v3 01/21] x86/fpu/xstate: Modify initialization helper to handle both static and dynamic buffers Chang S. Bae
2021-01-15 12:40 ` Borislav Petkov
2020-12-23 15:56 ` [PATCH v3 03/21] x86/fpu/xstate: Modify address finders " Chang S. Bae
2021-01-15 13:06 ` Borislav Petkov
2020-12-23 15:57 ` [PATCH v3 04/21] x86/fpu/xstate: Modify context switch helpers " Chang S. Bae
2021-01-15 13:18 ` Borislav Petkov
2021-01-19 18:49 ` Bae, Chang Seok
2020-12-23 15:57 ` [PATCH v3 06/21] x86/fpu/xstate: Calculate and remember dynamic xstate buffer sizes Chang S. Bae
2021-01-22 11:44 ` Borislav Petkov
2021-01-27 1:23 ` Bae, Chang Seok
2021-01-27 9:38 ` Borislav Petkov
2021-02-03 2:54 ` Bae, Chang Seok [this message]
2020-12-23 15:57 ` [PATCH v3 10/21] x86/fpu/xstate: Update xstate save function to support dynamic xstate Chang S. Bae
2021-01-07 8:41 ` Liu, Jing2
2021-01-07 18:40 ` Bae, Chang Seok
2021-01-12 2:52 ` Liu, Jing2
2021-01-15 4:59 ` Bae, Chang Seok
2021-01-15 5:45 ` Liu, Jing2
2021-02-08 12:33 ` Borislav Petkov
2021-02-09 15:48 ` Bae, Chang Seok
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).