From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B58AC433E1 for ; Fri, 26 Mar 2021 17:18:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE95E61A33 for ; Fri, 26 Mar 2021 17:18:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230195AbhCZRRv (ORCPT ); Fri, 26 Mar 2021 13:17:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:60423 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230238AbhCZRRi (ORCPT ); Fri, 26 Mar 2021 13:17:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616779057; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mEEFXRI0haCPgEoj51KZ0TTntyj6AagoVCMBBQHaCvk=; b=OpjyHQLQj7m0xS3k+YPEF7S10z4r4sHSIbAsr46IJOM9gIZ4zrcn7wZCbThHGgOXf8Hagb iGX7RJ52uL7om2fgHq1iNeCsGSht4iZdGQ+GGiEeDvGdTobSWN+NAFthlrS1o766AGPbvO iprY7V5Ub1F945uWMeLXIRI8w3z8JwY= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-105-89gzbXFHOveBGuxoMLwvKQ-1; Fri, 26 Mar 2021 13:17:33 -0400 X-MC-Unique: 89gzbXFHOveBGuxoMLwvKQ-1 Received: by mail-wm1-f72.google.com with SMTP id n22so857883wmo.7 for ; Fri, 26 Mar 2021 10:17:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mEEFXRI0haCPgEoj51KZ0TTntyj6AagoVCMBBQHaCvk=; b=qQ8WenHtVIgpXxFB01RdcMEeHDZT8QuzOhg7kPgmcJAzDDxbZRN3KpFo2JPkwek/+9 F1OizcoTB1N2U7k9PGsJvdvonkNURP2EZHV6bRgScF0+CBay+FdHcBVmMZLrfStAO6T4 6LdSHEmAfhcbxJwkUTCuwxAeiyBqAOyK//8qd+pZpy26xgAayNzITquRKTKiCKZhxTER w059NSE9MoSVsEpnc8k5zthJWxkhXOgB14gLjQilePOBFOPyPVqL3MSqL9LHcaBMY0PV dZfXhtjdRQhn/we2Z3MZ3GC6NtZBIWRzHGJ3reGDnqPfKSO1MwR9rTqeiC59cYlHQvPX Hrdg== X-Gm-Message-State: AOAM5308HCItUGuFFRNDd3mEDuJyFmHThYiGcClc/idZPArdKyqES3ik vE/Hp9fxjMfKTxAFV/Z3TmpUGRnVTjfjTvLqQWzzPDbNpDKCJkXBjHHhiHJArPGYrT3idiXhnVH hoCuqQWoL4wYW X-Received: by 2002:a5d:4e48:: with SMTP id r8mr15116719wrt.276.1616779052557; Fri, 26 Mar 2021 10:17:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJygIbw9AH1Dl8SfS3n9BfFo/8Npev5hJgg5emJQHMJVFvsusaS1yx+C4E0KLz3Gy7niIFkspw== X-Received: by 2002:a5d:4e48:: with SMTP id r8mr15116698wrt.276.1616779052312; Fri, 26 Mar 2021 10:17:32 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id s3sm11722803wmd.21.2021.03.26.10.17.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Mar 2021 10:17:31 -0700 (PDT) Subject: Re: [PATCH v2] selftests: kvm: make hardware_disable_test less verbose To: Vitaly Kuznetsov , kvm@vger.kernel.org Cc: Sean Christopherson , Wanpeng Li , Jim Mattson , Andrew Jones , linux-kernel@vger.kernel.org References: <20210323104331.1354800-1-vkuznets@redhat.com> From: Paolo Bonzini Message-ID: <222fc568-399e-b3c4-5354-09169edcb78f@redhat.com> Date: Fri, 26 Mar 2021 18:17:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210323104331.1354800-1-vkuznets@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 23/03/21 11:43, Vitaly Kuznetsov wrote: > hardware_disable_test produces 512 snippets like > ... > main: [511] waiting semaphore > run_test: [511] start vcpus > run_test: [511] all threads launched > main: [511] waiting 368us > main: [511] killing child > > and this doesn't have much value, let's print this info with pr_debug(). > > Signed-off-by: Vitaly Kuznetsov > --- > tools/testing/selftests/kvm/hardware_disable_test.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tools/testing/selftests/kvm/hardware_disable_test.c b/tools/testing/selftests/kvm/hardware_disable_test.c > index 2f2eeb8a1d86..5aadf84c91c0 100644 > --- a/tools/testing/selftests/kvm/hardware_disable_test.c > +++ b/tools/testing/selftests/kvm/hardware_disable_test.c > @@ -108,7 +108,7 @@ static void run_test(uint32_t run) > kvm_vm_elf_load(vm, program_invocation_name, 0, 0); > vm_create_irqchip(vm); > > - fprintf(stderr, "%s: [%d] start vcpus\n", __func__, run); > + pr_debug("%s: [%d] start vcpus\n", __func__, run); > for (i = 0; i < VCPU_NUM; ++i) { > vm_vcpu_add_default(vm, i, guest_code); > payloads[i].vm = vm; > @@ -124,7 +124,7 @@ static void run_test(uint32_t run) > check_set_affinity(throw_away, &cpu_set); > } > } > - fprintf(stderr, "%s: [%d] all threads launched\n", __func__, run); > + pr_debug("%s: [%d] all threads launched\n", __func__, run); > sem_post(sem); > for (i = 0; i < VCPU_NUM; ++i) > check_join(threads[i], &b); > @@ -147,16 +147,16 @@ int main(int argc, char **argv) > if (pid == 0) > run_test(i); /* This function always exits */ > > - fprintf(stderr, "%s: [%d] waiting semaphore\n", __func__, i); > + pr_debug("%s: [%d] waiting semaphore\n", __func__, i); > sem_wait(sem); > r = (rand() % DELAY_US_MAX) + 1; > - fprintf(stderr, "%s: [%d] waiting %dus\n", __func__, i, r); > + pr_debug("%s: [%d] waiting %dus\n", __func__, i, r); > usleep(r); > r = waitpid(pid, &s, WNOHANG); > TEST_ASSERT(r != pid, > "%s: [%d] child exited unexpectedly status: [%d]", > __func__, i, s); > - fprintf(stderr, "%s: [%d] killing child\n", __func__, i); > + pr_debug("%s: [%d] killing child\n", __func__, i); > kill(pid, SIGKILL); > } > > Queued, thanks. Paolo