From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDFF5C433E9 for ; Wed, 10 Mar 2021 10:14:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7DFE964FF6 for ; Wed, 10 Mar 2021 10:14:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231696AbhCJKN4 (ORCPT ); Wed, 10 Mar 2021 05:13:56 -0500 Received: from mx12.kaspersky-labs.com ([91.103.66.155]:44502 "EHLO mx12.kaspersky-labs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229948AbhCJKNw (ORCPT ); Wed, 10 Mar 2021 05:13:52 -0500 Received: from relay12.kaspersky-labs.com (unknown [127.0.0.10]) by relay12.kaspersky-labs.com (Postfix) with ESMTP id 68F2675F27; Wed, 10 Mar 2021 13:13:45 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kaspersky.com; s=mail202102; t=1615371225; bh=y98Bi0qAbz9deRs+wlsKu+q5eUchiSDI3Y/IVgT6utQ=; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type; b=lCQO2+sOqBUXm0Ttryc5cVhM9FNGqS+OH+BofVXldaz5YvyPrIej8op0Wyrmia4WR CJrYpGps4ve3A2UNCxxZstb03o4rrcn8eqoXn2NDdYL9bGU5HHPnjAgVbS5c+WJgWP cjt9HHOxndMFWJx/0U5d9CIbXuLMKLe7gwDd6uLXhKo+P3K8B9c/5E91rd2dClqRoQ Yv9gvaL0EUduePHLZNL3Yak5OeyuciUvfzVG+gU/QbyoryqQ9GRayAqu4n+r8tuwzz oUApVg9alNOvK64XavLgvpLQOlXDD3GoVkqR7TqA1c9ldUFDsxbMlRFx1j2+SPFRUQ xZQp2+iTf8RZg== Received: from mail-hq2.kaspersky.com (unknown [91.103.66.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client CN "mail-hq2.kaspersky.com", Issuer "Kaspersky MailRelays CA G3" (verified OK)) by mailhub12.kaspersky-labs.com (Postfix) with ESMTPS id 761AA75F47; Wed, 10 Mar 2021 13:13:44 +0300 (MSK) Received: from [10.16.171.77] (10.64.68.129) by hqmailmbx3.avp.ru (10.64.67.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 10 Mar 2021 13:13:43 +0300 Subject: Re: [RFC PATCH v6 00/22] virtio/vsock: introduce SOCK_SEQPACKET support To: Stefano Garzarella CC: Stefan Hajnoczi , "Michael S. Tsirkin" , Jason Wang , "David S. Miller" , Jakub Kicinski , Jorgen Hansen , Norbert Slusarek , Andra Paraschiv , Colin Ian King , "kvm@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stsp2@yandex.ru" , "oxffffaa@gmail.com" References: <20210307175722.3464068-1-arseny.krasnov@kaspersky.com> <20210310100603.rfhpy4uglkb6oxez@steredhat> From: Arseny Krasnov Message-ID: <2239aa8d-34b6-1dc5-400b-68d447032bbb@kaspersky.com> Date: Wed, 10 Mar 2021 13:13:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210310100603.rfhpy4uglkb6oxez@steredhat> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.64.68.129] X-ClientProxiedBy: hqmailmbx1.avp.ru (10.64.67.241) To hqmailmbx3.avp.ru (10.64.67.243) X-KSE-ServerInfo: hqmailmbx3.avp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 5.9.20, Database issued on: 03/10/2021 09:59:26 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 0 X-KSE-AntiSpam-Info: Lua profiles 162301 [Mar 10 2021] X-KSE-AntiSpam-Info: LuaCore: 433 433 d32eb971e08589ce94716a9bf8a0ef265b4c8d7c X-KSE-AntiSpam-Info: Version: 5.9.20.0 X-KSE-AntiSpam-Info: Envelope from: arseny.krasnov@kaspersky.com X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {Macro_CONTENT_PLAIN} X-KSE-AntiSpam-Info: {Macro_CONTENT_TEXT_PLAIN_OR_HTML} X-KSE-AntiSpam-Info: {Macro_CONTENT_TYPE_8_BIT_WITH_7_BIT_C_TRANSFER_ENCODING} X-KSE-AntiSpam-Info: {Macro_CONTENT_TYPE_ENCODING_NOT_JAPANESE} X-KSE-AntiSpam-Info: {Macro_CONTENT_TYPE_ENCODING_NOT_RUS} X-KSE-AntiSpam-Info: {Macro_CONTENT_TYPE_INCORRECT_BIT_FOR_C_TRANSFER_ENCODING} X-KSE-AntiSpam-Info: {Macro_DATE_MOSCOW} X-KSE-AntiSpam-Info: {Macro_FROM_DOUBLE_ENG_NAME} X-KSE-AntiSpam-Info: {Macro_FROM_LOWCAPS_DOUBLE_ENG_NAME_IN_EMAIL} X-KSE-AntiSpam-Info: {Macro_FROM_NOT_RU} X-KSE-AntiSpam-Info: {Macro_FROM_NOT_RUS_CHARSET} X-KSE-AntiSpam-Info: {Macro_FROM_REAL_NAME_MATCHES_ALL_USERNAME_PROB} X-KSE-AntiSpam-Info: {Macro_HEADERS_NOT_LIST} X-KSE-AntiSpam-Info: {Macro_MAILER_THUNDERBIRD} X-KSE-AntiSpam-Info: {Macro_MISC_X_PRIORITY_MISSED} X-KSE-AntiSpam-Info: {Macro_MSGID_LOWHEX_8_4_4_4_12} X-KSE-AntiSpam-Info: {Macro_NO_DKIM} X-KSE-AntiSpam-Info: {Macro_REPLY_TO_MISSED} X-KSE-AntiSpam-Info: {Macro_SUBJECT_AT_LEAST_2_WORDS} X-KSE-AntiSpam-Info: {Macro_SUBJECT_ENG_UPPERCASE_BEGINNING} X-KSE-AntiSpam-Info: {Macro_SUBJECT_LONG_TEXT} X-KSE-AntiSpam-Info: {Macro_SUBJECT_WITH_FWD_OR_RE} X-KSE-AntiSpam-Info: {Macro_TEXT_GREETINGS_AT_BEGINNING} X-KSE-AntiSpam-Info: 127.0.0.199:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;kaspersky.com:7.1.1 X-KSE-AntiSpam-Info: Rate: 0 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Deterministic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 03/10/2021 10:02:00 X-KSE-AttachmentFiltering-Interceptor-Info: no applicable attachment filtering rules found X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 10.03.2021 5:44:00 X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit X-KSE-AttachmentFiltering-Interceptor-Info: no applicable attachment filtering rules found X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit X-KLMS-Rule-ID: 52 X-KLMS-Message-Action: clean X-KLMS-AntiSpam-Status: not scanned, disabled by settings X-KLMS-AntiSpam-Interceptor-Info: not scanned X-KLMS-AntiPhishing: Clean, bases: 2021/03/10 09:12:00 X-KLMS-AntiVirus: Kaspersky Security for Linux Mail Server, version 8.0.3.30, bases: 2021/03/10 05:44:00 #16384964 X-KLMS-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hello, great, no problem! Thanks On 10.03.2021 13:06, Stefano Garzarella wrote: > Hi Arseny, > thanks for this new version. > > It's a busy week for me, but I hope to review this series by the end of > this week :-) > > Thanks, > Stefano > > On Sun, Mar 07, 2021 at 08:57:19PM +0300, Arseny Krasnov wrote: >> This patchset implements support of SOCK_SEQPACKET for virtio >> transport. >> As SOCK_SEQPACKET guarantees to save record boundaries, so to >> do it, two new packet operations were added: first for start of record >> and second to mark end of record(SEQ_BEGIN and SEQ_END later). Also, >> both operations carries metadata - to maintain boundaries and payload >> integrity. Metadata is introduced by adding special header with two >> fields - message id and message length: >> >> struct virtio_vsock_seq_hdr { >> __le32 msg_id; >> __le32 msg_len; >> } __attribute__((packed)); >> >> This header is transmitted as payload of SEQ_BEGIN and SEQ_END >> packets(buffer of second virtio descriptor in chain) in the same way as >> data transmitted in RW packets. Payload was chosen as buffer for this >> header to avoid touching first virtio buffer which carries header of >> packet, because someone could check that size of this buffer is equal >> to size of packet header. To send record, packet with start marker is >> sent first(it's header carries length of record and id),then all data >> is sent as usual 'RW' packets and finally SEQ_END is sent(it carries >> id of message, which is equal to id of SEQ_BEGIN), also after sending >> SEQ_END id is incremented. On receiver's side,size of record is known > >from packet with start record marker. To check that no packets were >> dropped by transport, 'msg_id's of two sequential SEQ_BEGIN and SEQ_END >> are checked to be equal and length of data between two markers is >> compared to then length in SEQ_BEGIN header. >> Now as packets of one socket are not reordered neither on >> vsock nor on vhost transport layers, such markers allows to restore >> original record on receiver's side. If user's buffer is smaller that >> record length, when all out of size data is dropped. >> Maximum length of datagram is not limited as in stream socket, >> because same credit logic is used. Difference with stream socket is >> that user is not woken up until whole record is received or error >> occurred. Implementation also supports 'MSG_EOR' and 'MSG_TRUNC' flags. >> Tests also implemented. >> >> Thanks to stsp2@yandex.ru for encouragements and initial design >> recommendations. >> >> Arseny Krasnov (22): >> af_vsock: update functions for connectible socket >> af_vsock: separate wait data loop >> af_vsock: separate receive data loop >> af_vsock: implement SEQPACKET receive loop >> af_vsock: separate wait space loop >> af_vsock: implement send logic for SEQPACKET >> af_vsock: rest of SEQPACKET support >> af_vsock: update comments for stream sockets >> virtio/vsock: set packet's type in virtio_transport_send_pkt_info() >> virtio/vsock: simplify credit update function API >> virtio/vsock: dequeue callback for SOCK_SEQPACKET >> virtio/vsock: fetch length for SEQPACKET record >> virtio/vsock: add SEQPACKET receive logic >> virtio/vsock: rest of SOCK_SEQPACKET support >> virtio/vsock: SEQPACKET feature bit >> vhost/vsock: SEQPACKET feature bit support >> virtio/vsock: SEQPACKET feature bit support >> virtio/vsock: setup SEQPACKET ops for transport >> vhost/vsock: setup SEQPACKET ops for transport >> vsock/loopback: setup SEQPACKET ops for transport >> vsock_test: add SOCK_SEQPACKET tests >> virtio/vsock: update trace event for SEQPACKET >> >> drivers/vhost/vsock.c | 22 +- >> include/linux/virtio_vsock.h | 22 + >> include/net/af_vsock.h | 10 + >> .../events/vsock_virtio_transport_common.h | 48 +- >> include/uapi/linux/virtio_vsock.h | 19 + >> net/vmw_vsock/af_vsock.c | 589 +++++++++++------ >> net/vmw_vsock/virtio_transport.c | 18 + >> net/vmw_vsock/virtio_transport_common.c | 364 ++++++++-- >> net/vmw_vsock/vsock_loopback.c | 13 + >> tools/testing/vsock/util.c | 32 +- >> tools/testing/vsock/util.h | 3 + >> tools/testing/vsock/vsock_test.c | 126 ++++ >> 12 files changed, 1013 insertions(+), 253 deletions(-) >> >> v5 -> v6: >> General changelog: >> - virtio transport specific callbacks which send SEQ_BEGIN or >> SEQ_END now hidden inside virtio transport. Only enqueue, >> dequeue and record length callbacks are provided by transport. >> >> - virtio feature bit for SEQPACKET socket support introduced: >> VIRTIO_VSOCK_F_SEQPACKET. >> >> - 'msg_cnt' field in 'struct virtio_vsock_seq_hdr' renamed to >> 'msg_id' and used as id. >> >> Per patch changelog: >> - 'af_vsock: separate wait data loop': >> 1) Commit message updated. >> 2) 'prepare_to_wait()' moved inside while loop(thanks to >> Jorgen Hansen). >> Marked 'Reviewed-by' with 1), but as 2) I removed R-b. >> >> - 'af_vsock: separate receive data loop': commit message >> updated. >> Marked 'Reviewed-by' with that fix. >> >> - 'af_vsock: implement SEQPACKET receive loop': style fixes. >> >> - 'af_vsock: rest of SEQPACKET support': >> 1) 'module_put()' added when transport callback check failed. >> 2) Now only 'seqpacket_allow()' callback called to check >> support of SEQPACKET by transport. >> >> - 'af_vsock: update comments for stream sockets': commit message >> updated. >> Marked 'Reviewed-by' with that fix. >> >> - 'virtio/vsock: set packet's type in send': >> 1) Commit message updated. >> 2) Parameter 'type' from 'virtio_transport_send_credit_update()' >> also removed in this patch instead of in next. >> >> - 'virtio/vsock: dequeue callback for SOCK_SEQPACKET': SEQPACKET >> related state wrapped to special struct. >> >> - 'virtio/vsock: update trace event for SEQPACKET': format strings >> now not broken by new lines. >> >> v4 -> v5: >> - patches reorganized: >> 1) Setting of packet's type in 'virtio_transport_send_pkt_info()' >> is moved to separate patch. >> 2) Simplifying of 'virtio_transport_send_credit_update()' is >> moved to separate patch and before main virtio/vsock patches. >> - style problem fixed >> - in 'af_vsock: separate receive data loop' extra 'release_sock()' >> removed >> - added trace event fields for SEQPACKET >> - in 'af_vsock: separate wait data loop': >> 1) 'vsock_wait_data()' removed 'goto out;' >> 2) Comment for invalid data amount is changed. >> - in 'af_vsock: rest of SEQPACKET support', 'new_transport' pointer >> check is moved after 'try_module_get()' >> - in 'af_vsock: update comments for stream sockets', 'connect-oriented' >> replaced with 'connection-oriented' >> - in 'loopback/vsock: setup SEQPACKET ops for transport', >> 'loopback/vsock' replaced with 'vsock/loopback' >> >> v3 -> v4: >> - SEQPACKET specific metadata moved from packet header to payload >> and called 'virtio_vsock_seq_hdr' >> - record integrity check: >> 1) SEQ_END operation was added, which marks end of record. >> 2) Both SEQ_BEGIN and SEQ_END carries counter which is incremented >> on every marker send. >> - af_vsock.c: socket operations for STREAM and SEQPACKET call same >> functions instead of having own "gates" differs only by names: >> 'vsock_seqpacket/stream_getsockopt()' now replaced with >> 'vsock_connectible_getsockopt()'. >> - af_vsock.c: 'seqpacket_dequeue' callback returns error and flag that >> record ready. There is no need to return number of copied bytes, >> because case when record received successfully is checked at virtio >> transport layer, when SEQ_END is processed. Also user doesn't need >> number of copied bytes, because 'recv()' from SEQPACKET could return >> error, length of users's buffer or length of whole record(both are >> known in af_vsock.c). >> - af_vsock.c: both wait loops in af_vsock.c(for data and space) moved >> to separate functions because now both called from several places. >> - af_vsock.c: 'vsock_assign_transport()' checks that 'new_transport' >> pointer is not NULL and returns 'ESOCKTNOSUPPORT' instead of 'ENODEV' >> if failed to use transport. >> - tools/testing/vsock/vsock_test.c: rename tests >> >> v2 -> v3: >> - patches reorganized: split for prepare and implementation patches >> - local variables are declared in "Reverse Christmas tree" manner >> - virtio_transport_common.c: valid leXX_to_cpu() for vsock header >> fields access >> - af_vsock.c: 'vsock_connectible_*sockopt()' added as shared code >> between stream and seqpacket sockets. >> - af_vsock.c: loops in '__vsock_*_recvmsg()' refactored. >> - af_vsock.c: 'vsock_wait_data()' refactored. >> >> v1 -> v2: >> - patches reordered: af_vsock.c related changes now before virtio vsock >> - patches reorganized: more small patches, where +/- are not mixed >> - tests for SOCK_SEQPACKET added >> - all commit messages updated >> - af_vsock.c: 'vsock_pre_recv_check()' inlined to >> 'vsock_connectible_recvmsg()' >> - af_vsock.c: 'vsock_assign_transport()' returns ENODEV if transport >> was not found >> - virtio_transport_common.c: transport callback for seqpacket dequeue >> - virtio_transport_common.c: simplified >> 'virtio_transport_recv_connected()' >> - virtio_transport_common.c: send reset on socket and packet type >> mismatch. >> >> Signed-off-by: Arseny Krasnov >> >> -- >> 2.25.1 >> >