KVM Archive on lore.kernel.org
 help / color / Atom feed
From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Alexander Graf' <agraf@suse.de>, linux-samsung-soc@vger.kernel.org
Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu,
	"THOMAS P ABRAHAM/SRI-Bangalore-SLG/./삼성전자"
	<thomas.ab@samsung.com>,
	"\'Giridhar BM\'" <giridhar.m@samsung.com>
Subject: RE: [PATCH 3/3] ARM: EXYNOS5250: Register architected timers
Date: Tue, 02 Apr 2013 19:44:22 +0900
Message-ID: <239701ce2f8f$093a2f40$1bae8dc0$%kim@samsung.com> (raw)
In-Reply-To: <1363222742-15220-4-git-send-email-agraf@suse.de>

Alexander Graf wrote:
> 
> When running on an exynos 5250 SoC, we don't initialize the architected
> timers. The chip however supports architected timers.
> 
Yes, exynos5250 can support, mct(multi core timer) is used though.

> When we don't initialize them, KVM will try to access them and run into
> NULL pointer dereferences attempting to do so.
> 
Yes, right.

> This patch is really more of a hack than a real fix, but does get me
> working with KVM on Arndale.
> 
Hmm, if you think, this is _really_ a hack, you need to add some comments
about that for clearance, and since the mct.c file has been moved into
drivers/clocksource/, this should be re-worked.

BTW, I discussed about this with Thomas and Giridhar just now, we reached
this 3rd patch could be dropped because the correct way is to add a dts
node for arch timer which patch 2nd is already doing after 3.9-rc1 because
of CLOCKSOURCE_OF_DECLARE macro.

So if you' OK above, let me know so that I can take only 1st and 2nd
patches to support KVM on exynos5250.

Thanks.

- Kukjin

> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
>  arch/arm/mach-exynos/mct.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/mach-exynos/mct.c b/arch/arm/mach-exynos/mct.c
> index c9d6650..eefb8af 100644
> --- a/arch/arm/mach-exynos/mct.c
> +++ b/arch/arm/mach-exynos/mct.c
> @@ -482,4 +482,8 @@ void __init exynos4_timer_init(void)
>  	exynos4_timer_resources();
>  	exynos4_clocksource_init();
>  	exynos4_clockevent_init();
> +
> +	if (soc_is_exynos5250()) {
> +		arch_timer_of_register();
> +	}
>  }
> --
> 1.7.10.4


  parent reply index

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-14  0:58 [PATCH 0/3] ARM: EXYNOS5250: Enable KVM support Alexander Graf
2013-03-14  0:59 ` [PATCH 1/3] ARM: EXYNOS5250: dts: Declare the gic as a15 compatible Alexander Graf
2013-03-14  0:59 ` [PATCH 2/3] ARM: EXYNOS5250: dts: Add architected timer nodes Alexander Graf
2013-03-14  0:59 ` [PATCH 3/3] ARM: EXYNOS5250: Register architected timers Alexander Graf
2013-03-14  3:26   ` [kvmarm] " Christoffer Dall
2013-03-14 19:07   ` Sergei Shtylyov
2013-03-21 15:40     ` Alexander Graf
2013-04-02 10:44   ` Kukjin Kim [this message]
2013-04-02 11:45     ` Alexander Graf
2013-04-03  4:56       ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='239701ce2f8f$093a2f40$1bae8dc0$%kim@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=agraf@suse.de \
    --cc=giridhar.m@samsung.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=thomas.ab@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

KVM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/kvm/0 kvm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 kvm kvm/ https://lore.kernel.org/kvm \
		kvm@vger.kernel.org
	public-inbox-index kvm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.kvm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git