From: Paolo Bonzini <pbonzini@redhat.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>, Cun Li <cun.jia.li@gmail.com>
Cc: seanjc@google.com, wanpengli@tencent.com, jmattson@google.com,
joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, x86@kernel.org, hpa@zytor.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: update depracated jump label API
Date: Tue, 26 Jan 2021 18:57:46 +0100 [thread overview]
Message-ID: <24e29c32-f6cb-cf7b-9376-1281b9545e69@redhat.com> (raw)
In-Reply-To: <87h7nn8ke8.fsf@vitty.brq.redhat.com>
On 11/01/21 18:15, Vitaly Kuznetsov wrote:
> kvm_no_apic_vcpu is different, we actually need to increase it with
> every vCPU which doesn't have LAPIC but maybe we can at least switch to
> static_branch_inc()/static_branch_dec(). It is still weird we initialize
> it to 'false'
"kvm_no_apic_vcpu" is badly named. It reads as "true if no vCPU has
APIC" but it means "true if some vCPU has no APIC". The latter is
obviously false in the beginning, because there is no vCPUs at all.
Perhaps a better name would be "kvm_has_noapic_vcpu" (for once,
smashingwordstogether is more readable than the alternative).
Paolo
but it seems to be a documented behavior. From
> include/linux/jump_label.h:
>
> "... Thus, static_branch_inc() can be thought of as a 'make more true'
> and static_branch_dec() as a 'make more false'"
next prev parent reply other threads:[~2021-01-26 22:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 15:24 [PATCH] KVM: update depracated jump label API Cun Li
2021-01-11 17:15 ` Vitaly Kuznetsov
2021-01-16 5:41 ` Cun Li
2021-01-16 5:50 ` [PATCH] KVM: update depracated and inappropriate " Cun Li
2021-01-19 20:46 ` Sean Christopherson
2021-01-26 17:57 ` Paolo Bonzini [this message]
2021-01-26 18:51 ` [PATCH] KVM: update depracated " Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24e29c32-f6cb-cf7b-9376-1281b9545e69@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=cun.jia.li@gmail.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).