From: "Wang, Wei W" <wei.w.wang@intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
Alexander Duyck <alexander.duyck@gmail.com>
Cc: Nitesh Narayan Lal <nitesh@redhat.com>,
kvm list <kvm@vger.kernel.org>,
David Hildenbrand <david@redhat.com>,
"Hansen, Dave" <dave.hansen@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
Yang Zhang <yang.zhang.wz@gmail.com>,
"pagupta@redhat.com" <pagupta@redhat.com>,
Rik van Riel <riel@surriel.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
"lcapitulino@redhat.com" <lcapitulino@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Williams, Dan J" <dan.j.williams@intel.com>,
Alexander Duyck <alexander.h.duyck@linux.intel.com>
Subject: RE: use of shrinker in virtio balloon free page hinting
Date: Wed, 17 Jul 2019 15:46:57 +0000 [thread overview]
Message-ID: <286AC319A985734F985F78AFA26841F73E16D4B2@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20190717071332-mutt-send-email-mst@kernel.org>
On Wednesday, July 17, 2019 7:21 PM, Michael S. Tsirkin wrote:
>
> Wei, others,
>
> ATM virtio_balloon_shrinker_scan will only get registered when deflate on
> oom feature bit is set.
>
> Not sure whether that's intentional.
Yes, we wanted to follow the old oom behavior, which allows the oom notifier
to deflate pages only when this feature bit has been negotiated.
> Assuming it is:
>
> virtio_balloon_shrinker_scan will try to locate and free pages that are
> processed by host.
> The above seems broken in several ways:
> - count ignores the free page list completely
Do you mean virtio_balloon_shrinker_count()? It just reports to
do_shrink_slab the amount of freeable memory that balloon has.
(vb->num_pages and vb->num_free_page_blocks are all included )
> - if free pages are being reported, pages freed
> by shrinker will just get re-allocated again
fill_balloon will re-try the allocation after sleeping 200ms once allocation fails.
> I was unable to make this part of code behave in any reasonable way - was
> shrinker usage tested? What's a good way to test that?
Please see the example that I tested before : https://lkml.org/lkml/2018/8/6/29
(just the first one: *1. V3 patches)
What problem did you see?
I just tried the latest code, and find ballooning reports a #GP (seems caused by
418a3ab1e).
I'll take a look at the details in the office tomorrow.
Best,
Wei
next prev parent reply other threads:[~2019-07-17 15:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 11:20 use of shrinker in virtio balloon free page hinting Michael S. Tsirkin
2019-07-17 11:32 ` David Hildenbrand
2019-07-17 14:10 ` David Hildenbrand
2019-07-17 14:34 ` Michael S. Tsirkin
2019-07-17 14:38 ` David Hildenbrand
2019-07-17 15:46 ` Wang, Wei W [this message]
2019-07-18 4:13 ` Michael S. Tsirkin
2019-07-18 5:57 ` Wei Wang
2019-07-18 5:58 ` Michael S. Tsirkin
2019-07-18 6:30 ` Wei Wang
2019-07-18 6:47 ` Michael S. Tsirkin
2019-07-18 9:08 ` Wei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=286AC319A985734F985F78AFA26841F73E16D4B2@shsmsx102.ccr.corp.intel.com \
--to=wei.w.wang@intel.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.duyck@gmail.com \
--cc=alexander.h.duyck@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=david@redhat.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mst@redhat.com \
--cc=nitesh@redhat.com \
--cc=pagupta@redhat.com \
--cc=pbonzini@redhat.com \
--cc=riel@surriel.com \
--cc=yang.zhang.wz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).