From: Krish Sadhukhan <krish.sadhukhan@oracle.com> To: Sean Christopherson <sean.j.christopherson@intel.com> Cc: kvm@vger.kernel.org, pbonzini@redhat.com, rkrcmar@redhat.com, jmattson@google.com Subject: Re: [PATCH 1/8][KVMnVMX]: Enable "load IA32_PERF_GLOBAL_CTRL" VM-exit control for nested guests Date: Mon, 13 May 2019 15:08:49 -0700 Message-ID: <29d30b7d-5cd0-65f3-283e-05b78df2bf3e@oracle.com> (raw) In-Reply-To: <20190513184930.GF28561@linux.intel.com> On 05/13/2019 11:49 AM, Sean Christopherson wrote: > On Wed, Apr 24, 2019 at 07:17:17PM -0400, Krish Sadhukhan wrote: >> Signed-off-by: Krish Sadhukhan <krish.sadhukhan@oracle.com> >> Reviewed-by: Karl Heubaum <karl.heubaum@oracle.com> >> --- >> arch/x86/kvm/vmx/nested.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c >> index 3170e291215d..42a4deb662c6 100644 >> --- a/arch/x86/kvm/vmx/nested.c >> +++ b/arch/x86/kvm/vmx/nested.c >> @@ -5493,7 +5493,8 @@ void nested_vmx_setup_ctls_msrs(struct nested_vmx_msrs *msrs, u32 ept_caps, >> msrs->exit_ctls_high |= >> VM_EXIT_ALWAYSON_WITHOUT_TRUE_MSR | >> VM_EXIT_LOAD_IA32_EFER | VM_EXIT_SAVE_IA32_EFER | >> - VM_EXIT_SAVE_VMX_PREEMPTION_TIMER | VM_EXIT_ACK_INTR_ON_EXIT; >> + VM_EXIT_SAVE_VMX_PREEMPTION_TIMER | VM_EXIT_ACK_INTR_ON_EXIT | >> + VM_EXIT_LOAD_IA32_PERF_GLOBAL_CTRL; > This exposes the control to L1 but doesn't implement the backing > functionality. The backing functionality, consistency checks and exposure > to L1 should be a single patch. The consistency checks could be added > earlier, but I don't see much value in doing so given that the checks are > (currently) a few lines. I will combine the exposure of the control and its backing functionality into a single patch. But I would prefer to keep the consistency checks in separate patches just to make it a gradual progression i.e., first enabling the controls in a patch and then checking their consistency in the successive patch. > >> >> /* We support free control of debug control saving. */ >> msrs->exit_ctls_low &= ~VM_EXIT_SAVE_DEBUG_CONTROLS; >> -- >> 2.17.2 >>
next prev parent reply index Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-24 23:17 [KVM nVMX]: Check "load IA32_PERF_GLOBAL_CTRL" on vmentry of " Krish Sadhukhan 2019-04-24 23:17 ` [PATCH 1/8][KVMnVMX]: Enable "load IA32_PERF_GLOBAL_CTRL" VM-exit control for " Krish Sadhukhan 2019-05-13 18:49 ` Sean Christopherson 2019-05-13 22:08 ` Krish Sadhukhan [this message] 2019-04-24 23:17 ` [PATCH 2/8][KVM nVMX]: Enable "load IA32_PERF_GLOBAL_CTRL" VM-entry " Krish Sadhukhan 2019-05-13 18:49 ` Sean Christopherson 2019-04-24 23:17 ` [PATCH 3/8][KVM VMX]: Add a function to check reserved bits in MSR_CORE_PERF_GLOBAL_CTRL Krish Sadhukhan 2019-05-13 18:57 ` Sean Christopherson 2019-08-15 22:29 ` Jim Mattson 2019-04-24 23:17 ` [PATCH 4/8][KVM nVMX]: Check "load IA32_PERF_GLOBAL_CTRL" VM-exit control on vmentry of nested guests Krish Sadhukhan 2019-05-13 19:00 ` Sean Christopherson 2019-05-16 22:07 ` Krish Sadhukhan 2019-05-17 20:34 ` Sean Christopherson 2019-08-15 22:54 ` Jim Mattson 2019-04-24 23:17 ` [PATCH 5/8][KVM nVMX]: Check "load IA32_PERF_GLOBAL_CTRL" VM-entry " Krish Sadhukhan 2019-08-15 22:36 ` Jim Mattson 2019-04-24 23:17 ` [PATCH 6/8][KVM nVMX]: Load IA32_PERF_GLOBAL_CTRL MSR " Krish Sadhukhan 2019-08-15 22:44 ` Jim Mattson 2019-08-21 23:05 ` Krish Sadhukhan 2019-08-21 23:10 ` Jim Mattson 2019-08-23 5:29 ` Krish Sadhukhan 2019-08-23 15:57 ` Jim Mattson 2019-04-24 23:17 ` [PATCH 7/8][KVM nVMX]: Enable "load IA32_PERF_GLOBAL_CTRL VM-{entry,exit} controls Krish Sadhukhan 2019-05-13 19:12 ` Sean Christopherson 2019-08-15 23:02 ` Jim Mattson 2019-04-24 23:17 ` [PATCH 8/8][KVM nVMX]: Test "load IA32_PERF_GLOBAL_CTRL" controls on vmentry of nested guests Krish Sadhukhan 2019-05-13 18:46 ` [KVM nVMX]: Check "load IA32_PERF_GLOBAL_CTRL" " Sean Christopherson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=29d30b7d-5cd0-65f3-283e-05b78df2bf3e@oracle.com \ --to=krish.sadhukhan@oracle.com \ --cc=jmattson@google.com \ --cc=kvm@vger.kernel.org \ --cc=pbonzini@redhat.com \ --cc=rkrcmar@redhat.com \ --cc=sean.j.christopherson@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
KVM Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/kvm/0 kvm/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 kvm kvm/ https://lore.kernel.org/kvm \ kvm@vger.kernel.org public-inbox-index kvm Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.kvm AGPL code for this site: git clone https://public-inbox.org/public-inbox.git