From: Alexander Graf <graf@amazon.com> To: "Suthikulpanit, Suravee" <Suravee.Suthikulpanit@amd.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "kvm@vger.kernel.org" <kvm@vger.kernel.org> Cc: "pbonzini@redhat.com" <pbonzini@redhat.com>, "rkrcmar@redhat.com" <rkrcmar@redhat.com>, "joro@8bytes.org" <joro@8bytes.org>, "jschoenh@amazon.de" <jschoenh@amazon.de>, "karahmed@amazon.de" <karahmed@amazon.de>, "rimasluk@amazon.com" <rimasluk@amazon.com>, "Grimm, Jon" <Jon.Grimm@amd.com> Subject: Re: [PATCH v2 10/15] kvm: x86: hyperv: Use APICv deactivate request interface Date: Mon, 19 Aug 2019 12:31:24 +0200 Message-ID: <2b26daff-6970-cca4-8553-962a6d829bdd@amazon.com> (raw) In-Reply-To: <1565886293-115836-11-git-send-email-suravee.suthikulpanit@amd.com> On 15.08.19 18:25, Suthikulpanit, Suravee wrote: > Since disabling APICv has to be done for all vcpus on AMD-based system, > adopt the newly introduced kvm_make_apicv_deactivate_request() intereface. typo > > Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com> > --- > arch/x86/kvm/hyperv.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kvm/hyperv.c b/arch/x86/kvm/hyperv.c > index a39e38f..4f71a39 100644 > --- a/arch/x86/kvm/hyperv.c > +++ b/arch/x86/kvm/hyperv.c > @@ -772,9 +772,17 @@ int kvm_hv_activate_synic(struct kvm_vcpu *vcpu, bool dont_zero_synic_pages) > > /* > * Hyper-V SynIC auto EOI SINT's are > - * not compatible with APICV, so deactivate APICV > + * not compatible with APICV, so request double space > + * to deactivate APICV permanently. > + * > + * Since this requires updating > + * APIC_ACCESS_PAGE_PRIVATE_MEMSLOT, > + * also take srcu lock. > */ > - kvm_vcpu_deactivate_apicv(vcpu); > + vcpu->srcu_idx = srcu_read_lock(&vcpu->kvm->srcu); > + kvm_make_apicv_deactivate_request(vcpu, true); > + srcu_read_unlock(&vcpu->kvm->srcu, vcpu->srcu_idx); Overall, I'm not terribly happy with the srcu locks. Can't we handle the memslot changes outside of the lock region, inside the respective request handlers somehow? Alex > + > synic->active = true; > synic->dont_zero_synic_pages = dont_zero_synic_pages; > return 0; >
next prev parent reply index Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-15 16:25 [PATCH v2 00/15] kvm: x86: Support AMD SVM AVIC w/ in-kernel irqchip mode Suthikulpanit, Suravee 2019-08-15 16:25 ` [PATCH v2 01/15] kvm: x86: Modify kvm_x86_ops.get_enable_apicv() to use struct kvm parameter Suthikulpanit, Suravee 2019-08-27 7:15 ` Vitaly Kuznetsov 2019-08-15 16:25 ` [PATCH v2 02/15] kvm: x86: Introduce KVM APICv state Suthikulpanit, Suravee 2019-08-19 9:49 ` Alexander Graf 2019-08-26 19:06 ` Suthikulpanit, Suravee 2019-08-15 16:25 ` [PATCH v2 03/15] kvm: Add arch-specific per-VM debugfs support Suthikulpanit, Suravee 2019-08-15 16:25 ` [PATCH v2 04/15] kvm: x86: Add per-VM APICv state debugfs Suthikulpanit, Suravee 2019-08-19 9:57 ` Alexander Graf 2019-08-26 19:41 ` Suthikulpanit, Suravee 2019-08-27 8:20 ` Alexander Graf 2019-08-28 18:39 ` Suthikulpanit, Suravee 2019-08-28 19:36 ` Graf (AWS), Alexander 2019-08-15 16:25 ` [PATCH v2 05/15] kvm: lapic: Introduce APICv update helper function Suthikulpanit, Suravee 2019-08-27 7:22 ` Vitaly Kuznetsov 2019-08-15 16:25 ` [PATCH v2 06/15] kvm: x86: Add support for activate/de-activate APICv at runtime Suthikulpanit, Suravee 2019-08-27 7:29 ` Vitaly Kuznetsov 2019-08-27 8:05 ` Alexander Graf 2019-08-15 16:25 ` [PATCH v2 07/15] kvm: x86: svm: Add support to activate/deactivate posted interrupts Suthikulpanit, Suravee 2019-08-15 16:25 ` [PATCH v2 08/15] svm: Add support for setup/destroy virutal APIC backing page for AVIC Suthikulpanit, Suravee 2019-08-15 16:25 ` [PATCH v2 09/15] svm: Add support for activate/deactivate AVIC at runtime Suthikulpanit, Suravee 2019-08-19 10:28 ` Alexander Graf 2019-08-15 16:25 ` [PATCH v2 10/15] kvm: x86: hyperv: Use APICv deactivate request interface Suthikulpanit, Suravee 2019-08-19 10:31 ` Alexander Graf [this message] 2019-08-15 16:25 ` [PATCH v2 11/15] svm: Temporary deactivate AVIC during ExtINT handling Suthikulpanit, Suravee 2019-08-19 10:35 ` Alexander Graf 2019-08-28 15:17 ` Suthikulpanit, Suravee 2019-08-28 19:37 ` Graf (AWS), Alexander 2019-09-10 15:46 ` Suthikulpanit, Suravee 2019-08-15 16:25 ` [PATCH v2 12/15] kvm: i8254: Check LAPIC EOI pending when injecting irq on SVM AVIC Suthikulpanit, Suravee 2019-08-19 10:42 ` Alexander Graf 2019-08-26 20:46 ` Suthikulpanit, Suravee 2019-08-27 9:10 ` Alexander Graf 2019-09-13 14:50 ` Suthikulpanit, Suravee 2019-08-15 16:25 ` [PATCH v2 13/15] kvm: lapic: Clean up APIC predefined macros Suthikulpanit, Suravee 2019-08-15 16:25 ` [PATCH v2 14/15] kvm: ioapic: Delay update IOAPIC EOI for RTC Suthikulpanit, Suravee 2019-08-19 11:00 ` Alexander Graf 2019-09-04 2:06 ` Suthikulpanit, Suravee 2019-08-15 16:25 ` [PATCH v2 15/15] svm: Allow AVIC with in-kernel irqchip mode Suthikulpanit, Suravee
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2b26daff-6970-cca4-8553-962a6d829bdd@amazon.com \ --to=graf@amazon.com \ --cc=Jon.Grimm@amd.com \ --cc=Suravee.Suthikulpanit@amd.com \ --cc=joro@8bytes.org \ --cc=jschoenh@amazon.de \ --cc=karahmed@amazon.de \ --cc=kvm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=pbonzini@redhat.com \ --cc=rimasluk@amazon.com \ --cc=rkrcmar@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
KVM Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/kvm/0 kvm/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 kvm kvm/ https://lore.kernel.org/kvm \ kvm@vger.kernel.org public-inbox-index kvm Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.kvm AGPL code for this site: git clone https://public-inbox.org/public-inbox.git