From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19C96C4320E for ; Sat, 14 Aug 2021 07:22:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF6CC60F51 for ; Sat, 14 Aug 2021 07:22:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237346AbhHNHW4 (ORCPT ); Sat, 14 Aug 2021 03:22:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:48676 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237305AbhHNHWw (ORCPT ); Sat, 14 Aug 2021 03:22:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628925743; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1TtSUDMLTyWrnaOTR2UJPOGTDs88Lu3pvS9ZFwMmYSo=; b=TilLfnbfO2E8teztUgiImqAcatUyZhH4r7XMaV178qFUTksIu2ciBmORtOAgaf0bU8JsAy tjf70L3SCieZSpa9oADo4/XYDR5vVZSrNHNAmDlKVhy8PMTCBEBU85GQgAogdlfUGCsH/7 onHJ/vYN7A+laLM0vJ23fFEIER7kC/E= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-348-ueS89jUZP221hY4fDyjmhA-1; Sat, 14 Aug 2021 03:22:21 -0400 X-MC-Unique: ueS89jUZP221hY4fDyjmhA-1 Received: by mail-ed1-f72.google.com with SMTP id v11-20020a056402348bb02903be68e116adso5970032edc.14 for ; Sat, 14 Aug 2021 00:22:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1TtSUDMLTyWrnaOTR2UJPOGTDs88Lu3pvS9ZFwMmYSo=; b=g3KZL6DGCcX/lVwDprQ4jMRILzDj67v36gEdRknrh0Kv42uqeWFnrkCodehR1Ibo+9 z92s3aRwitni9+uHX8x2N7ORugzpW6Ick8UAVzUoZVDiPqhRq9v0TOPGByA/74V+qe/T tMos98BOhtFcenq6NR7H4RSKUXOdKE8fWic4n1RWsl53Tk/pBXC9zkeGrU8Ct58yq/E+ kp+B6wdd52roaIQJRo8bgnFvnix66z2fQqMBWUr/4z5XHoDLtfUt0xBmz4b1Oji+LH7j li154SNtZ8aZY1yGAYPQQl8IA9CjEtAeR+HipBX/ofA+I/+WnMIJNElrz15r/HJrWq0j 3mXQ== X-Gm-Message-State: AOAM530Xn2dKVzAfAFQRJxxxKPmIB82YWkouXA5zLxu0p4NyyWDEXXpw Z2fKRrwxveVMnJYLREnC9TbtlJbJLpzZwMD8+GzAb2hqFols62anJo0zzZ+iKNm+0W/chJHSF1z PEuqbeIwdD2m0 X-Received: by 2002:a05:6402:1d33:: with SMTP id dh19mr7880358edb.10.1628925740600; Sat, 14 Aug 2021 00:22:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzlMdYxdPuv4hxHiu5mdrKEcsJmNgUQPIOBIw33CfjXaNdkfdzNZcQUx/8sGWC1f+auRLo1Gw== X-Received: by 2002:a05:6402:1d33:: with SMTP id dh19mr7880346edb.10.1628925740441; Sat, 14 Aug 2021 00:22:20 -0700 (PDT) Received: from [192.168.10.118] ([93.56.169.140]) by smtp.gmail.com with ESMTPSA id z4sm1412515edc.33.2021.08.14.00.22.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Aug 2021 00:22:19 -0700 (PDT) To: Hikaru Nishida , linux-kernel@vger.kernel.org, dme@dme.org, tglx@linutronix.de, mlevitsk@redhat.com Cc: suleiman@google.com, Borislav Petkov , "H. Peter Anvin" , Ingo Molnar , Jim Mattson , Joerg Roedel , John Stultz , Sean Christopherson , Stephen Boyd , Vitaly Kuznetsov , Wanpeng Li , kvm@vger.kernel.org, x86@kernel.org References: <20210806100710.2425336-1-hikalium@chromium.org> <20210806190607.v2.3.Ib0cb8ecae99f0ccd0e2814b310adba00b9e81d94@changeid> From: Paolo Bonzini Subject: Re: [v2 PATCH 3/4] x86/kvm: Add host side support for virtual suspend time injection Message-ID: <2ec642dd-dde6-bee6-3de3-0fa78d288995@redhat.com> Date: Sat, 14 Aug 2021 09:22:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210806190607.v2.3.Ib0cb8ecae99f0ccd0e2814b310adba00b9e81d94@changeid> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 06/08/21 12:07, Hikaru Nishida wrote: > +#if defined(CONFIG_KVM_VIRT_SUSPEND_TIMING) || \ > + defined(CONFIG_KVM_VIRT_SUSPEND_TIMING_GUEST) > +#define VIRT_SUSPEND_TIMING_VECTOR 0xec > +#endif No need to use a new vector. You can rename the existing MSR_KVM_ASYNC_PF_INT to MSR_KVM_HYPERVISOR_CALLBACK_INT or something like that, and add the code to sysvec_kvm_asyncpf_interrupt. > +static void kvm_make_suspend_time_interrupt(struct kvm_vcpu *vcpu) > +{ > + kvm_queue_interrupt(vcpu, VIRT_SUSPEND_TIMING_VECTOR, false); > + kvm_make_request(KVM_REQ_EVENT, vcpu); > +} Use kvm_apic_set_irq which will inject the interrupt as soon as possible, so you do not even need to check kvm_vcpu_ready_for_interrupt_injection. > +#ifdef CONFIG_KVM_VIRT_SUSPEND_TIMING > + if (kvm->suspend_injection_requested && > + kvm_vcpu_ready_for_interrupt_injection(vcpu)) { > + kvm_write_suspend_time(kvm); > + kvm_make_suspend_time_interrupt(vcpu); > + kvm->suspend_injection_requested = false; > + } > +#endif Do not read variables in vcpu_run; There is KVM_REQ_* if you need to do work in the vCPU run loop. > + mutex_lock(&kvm_lock); > + list_for_each_entry(kvm, &vm_list, vm_list) { > + if (!(kvm->arch.msr_suspend_time & KVM_MSR_ENABLED)) > + continue; > + > + kvm_for_each_vcpu(i, vcpu, kvm) > + vcpu->arch.tsc_offset_adjustment -= adj; > + > + /* > + * Move the offset of kvm_clock here as if it is stopped > + * during the suspension. > + */ > + kvm->arch.kvmclock_offset -= suspend_time_ns; > + > + /* suspend_time is accumulated per VM. */ > + kvm->suspend_time_ns += suspend_time_ns; > + kvm->suspend_injection_requested = true; > + /* > + * This adjustment will be reflected to the struct provided > + * from the guest via MSR_KVM_HOST_SUSPEND_TIME before > + * the notification interrupt is injected. > + */ > + } > + mutex_unlock(&kvm_lock); > +} As pointed out by Thomas, this should be a work item. Paolo