From: David Hildenbrand <david@redhat.com>
To: Pierre Morel <pmorel@linux.ibm.com>
Cc: David Hildenbrand <david@redhat.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org,
frankja@linux.ibm.com, thuth@redhat.com, cohuck@redhat.com
Subject: Re: [kvm-unit-tests PATCH v2 2/9] s390x: Define the PSW bits
Date: Thu, 28 Nov 2019 20:48:00 +0100 [thread overview]
Message-ID: <30DD27E7-BE6E-4986-AD69-7718E6B9A730@redhat.com> (raw)
In-Reply-To: <7abb4725-b814-8b43-8a4f-e0e2cf7a44f8@linux.ibm.com>
> Am 28.11.2019 um 20:16 schrieb Pierre Morel <pmorel@linux.ibm.com>:
>
>
>> On 2019-11-28 15:36, David Hildenbrand wrote:
>>> On 28.11.19 13:46, Pierre Morel wrote:
>>> Let's define the PSW bits explicitly, it will clarify their
>>> usage.
>>>
>>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>>> ---
>>> lib/s390x/asm/arch_bits.h | 20 ++++++++++++++++++++
>>> lib/s390x/asm/arch_def.h | 6 ++----
>> I'm sorry, but I don't really see a reason to move these 4/5 defines to
>> a separate header. Can you just keep them in arch_def.h and extend?
>
> no because arch_def.h contains C structures and inline.
(resend because the iOS Mail app does crazy html thingies)
You‘re looking for
#ifndef __ASSEMBLER__
...
See lib/s390x/asm/sigp.h
next prev parent reply other threads:[~2019-11-28 19:48 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 12:45 [kvm-unit-tests PATCH v2 0/9] s390x: Testing the Channel Subsystem I/O Pierre Morel
2019-11-28 12:45 ` [kvm-unit-tests PATCH v2 1/9] s390x: saving regs for interrupts Pierre Morel
2019-11-28 12:46 ` [kvm-unit-tests PATCH v2 2/9] s390x: Define the PSW bits Pierre Morel
2019-11-28 14:36 ` David Hildenbrand
2019-11-28 19:16 ` Pierre Morel
2019-11-28 19:48 ` David Hildenbrand [this message]
2019-11-29 13:04 ` Pierre Morel
2019-12-02 11:11 ` Janosch Frank
2019-12-02 11:17 ` David Hildenbrand
2019-12-02 16:52 ` Pierre Morel
2019-11-28 12:46 ` [kvm-unit-tests PATCH v2 3/9] s390x: irq: make IRQ handler weak Pierre Morel
2019-11-29 12:01 ` David Hildenbrand
2019-12-02 10:41 ` Thomas Huth
2019-12-02 16:55 ` Pierre Morel
2019-11-28 12:46 ` [kvm-unit-tests PATCH v2 4/9] s390x: export the clock get_clock_ms() utility Pierre Morel
2019-11-29 12:03 ` David Hildenbrand
2019-11-29 13:04 ` Pierre Morel
2019-12-02 11:13 ` Janosch Frank
2019-12-02 17:03 ` Pierre Morel
2019-11-28 12:46 ` [kvm-unit-tests PATCH v2 5/9] s390x: Library resources for CSS tests Pierre Morel
2019-12-02 14:06 ` Cornelia Huck
2019-12-02 17:33 ` Pierre Morel
2019-11-28 12:46 ` [kvm-unit-tests PATCH v2 6/9] s390x: css: stsch, enumeration test Pierre Morel
2019-12-02 14:22 ` Cornelia Huck
2019-12-02 17:53 ` Pierre Morel
2019-12-02 18:15 ` Cornelia Huck
2019-12-02 18:33 ` Pierre Morel
2019-12-02 19:49 ` Cornelia Huck
2019-12-03 8:43 ` Pierre Morel
2019-11-28 12:46 ` [kvm-unit-tests PATCH v2 7/9] s390x: css: msch, enable test Pierre Morel
2019-12-02 14:30 ` Cornelia Huck
2019-12-02 17:55 ` Pierre Morel
2019-11-28 12:46 ` [kvm-unit-tests PATCH v2 8/9] s390x: css: ssch/tsch with sense and interrupt Pierre Morel
2019-12-02 14:55 ` Cornelia Huck
2019-12-02 18:18 ` Pierre Morel
2019-12-02 19:54 ` Cornelia Huck
2019-12-03 8:58 ` Pierre Morel
2019-11-28 12:46 ` [kvm-unit-tests PATCH v2 9/9] s390x: css: ping pong Pierre Morel
2019-12-02 15:03 ` Cornelia Huck
2019-12-02 18:25 ` Pierre Morel
2019-12-06 14:18 ` Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30DD27E7-BE6E-4986-AD69-7718E6B9A730@redhat.com \
--to=david@redhat.com \
--cc=cohuck@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pmorel@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).