From: Paolo Bonzini <pbonzini@redhat.com>
To: Jing Zhang <jingzhangos@google.com>, KVM <kvm@vger.kernel.org>,
KVMARM <kvmarm@lists.cs.columbia.edu>,
LinuxMIPS <linux-mips@vger.kernel.org>,
KVMPPC <kvm-ppc@vger.kernel.org>,
LinuxS390 <linux-s390@vger.kernel.org>,
Linuxkselftest <linux-kselftest@vger.kernel.org>,
Marc Zyngier <maz@kernel.org>, James Morse <james.morse@arm.com>,
Julien Thierry <julien.thierry.kdev@gmail.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Will Deacon <will@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Paul Mackerras <paulus@ozlabs.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Jim Mattson <jmattson@google.com>,
Peter Shier <pshier@google.com>, Oliver Upton <oupton@google.com>,
David Rientjes <rientjes@google.com>,
Emanuele Giuseppe Esposito <eesposit@redhat.com>,
David Matlack <dmatlack@google.com>,
Ricardo Koller <ricarkol@google.com>,
Krish Sadhukhan <krish.sadhukhan@oracle.com>
Subject: Re: [PATCH v7 2/4] KVM: stats: Add fd-based API to read binary stats data
Date: Thu, 10 Jun 2021 18:42:06 +0200 [thread overview]
Message-ID: <345170fd-636c-f1be-7dc3-69467e51d872@redhat.com> (raw)
In-Reply-To: <20210603211426.790093-3-jingzhangos@google.com>
On 03/06/21 23:14, Jing Zhang wrote:
> +struct _kvm_stats_header {
> + __u32 name_size;
> + __u32 count;
> + __u32 desc_offset;
> + __u32 data_offset;
> +};
> +
Keeping this struct in sync with kvm_stats_header is a bit messy. If
you move the id at the end of the header, however, you can use the same
trick with the zero-sized array that you used for _kvm_stats_desc.
> +struct kvm_vm_stats_data {
> + unsigned long value[0];
> +};
> +
I posted the patch to switch the VM statistics to 64-bit; you can rebase
on top of it.
> +#define KVM_GET_STATS_FD _IOR(KVMIO, 0xcc, struct kvm_stats_header)
This should be _IO(KVMIO, 0xcc) since it does not have an argument.
> +#define STATS_DESC(stat, type, unit, scale, exp) \
> + { \
> + { \
> + .flags = type | unit | scale, \
> + .exponent = exp, \
> + .size = 1 \
> + }, \
> + .name = stat, \
Here you can use
type | BUILD_BUG_ON_ZERO(type & ~KVM_STATS_TYPE_MASK) |
unit | BUILD_BUG_ON_ZERO(unit & ~KVM_STATS_UNIT_MASK) |
scale | BUILD_BUG_ON_ZERO(scale & ~KVM_STATS_SCALE_MASK) |
to get a little bit of type checking.
Paolo
next prev parent reply other threads:[~2021-06-10 16:43 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 21:14 [PATCH v7 0/4] KVM statistics data fd-based binary interface Jing Zhang
2021-06-03 21:14 ` [PATCH v7 1/4] KVM: stats: Separate generic stats from architecture specific ones Jing Zhang
2021-06-07 19:22 ` Krish Sadhukhan
2021-06-11 6:57 ` Christian Borntraeger
2021-06-11 10:51 ` Paolo Bonzini
2021-06-11 12:00 ` Christian Borntraeger
2021-06-11 12:03 ` Paolo Bonzini
2021-06-11 12:08 ` Christian Borntraeger
2021-06-11 12:14 ` Paolo Bonzini
2021-06-03 21:14 ` [PATCH v7 2/4] KVM: stats: Add fd-based API to read binary stats data Jing Zhang
2021-06-07 19:22 ` Krish Sadhukhan
2021-06-07 22:10 ` Jing Zhang
2021-06-10 16:23 ` Paolo Bonzini
2021-06-10 17:26 ` Jing Zhang
2021-06-10 22:47 ` Jing Zhang
2021-06-11 10:32 ` Paolo Bonzini
2021-06-10 16:42 ` Paolo Bonzini [this message]
2021-06-10 17:27 ` Jing Zhang
2021-06-13 15:19 ` Fuad Tabba
2021-06-13 16:42 ` Jing Zhang
2021-06-03 21:14 ` [PATCH v7 3/4] KVM: stats: Add documentation for statistics data binary interface Jing Zhang
2021-06-07 19:22 ` Krish Sadhukhan
2021-06-07 22:09 ` Jing Zhang
2021-06-14 7:56 ` Fuad Tabba
2021-06-14 13:19 ` Jing Zhang
2021-06-03 21:14 ` [PATCH v7 4/4] KVM: selftests: Add selftest for KVM " Jing Zhang
2021-06-07 19:23 ` Krish Sadhukhan
2021-06-07 22:12 ` Jing Zhang
2021-06-10 16:46 ` [PATCH v7 0/4] KVM statistics data fd-based " Paolo Bonzini
2021-06-10 17:30 ` Jing Zhang
2021-06-11 6:57 ` Christian Borntraeger
2021-06-11 11:02 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=345170fd-636c-f1be-7dc3-69467e51d872@redhat.com \
--to=pbonzini@redhat.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=chenhuacai@kernel.org \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=dmatlack@google.com \
--cc=eesposit@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=james.morse@arm.com \
--cc=jingzhangos@google.com \
--cc=jmattson@google.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=krish.sadhukhan@oracle.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=maz@kernel.org \
--cc=oupton@google.com \
--cc=paulus@ozlabs.org \
--cc=pshier@google.com \
--cc=ricarkol@google.com \
--cc=rientjes@google.com \
--cc=seanjc@google.com \
--cc=suzuki.poulose@arm.com \
--cc=tsbogend@alpha.franken.de \
--cc=vkuznets@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).