From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1671C433ED for ; Mon, 3 May 2021 14:03:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A8C466105A for ; Mon, 3 May 2021 14:03:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234013AbhECOEI (ORCPT ); Mon, 3 May 2021 10:04:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:47937 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233968AbhECOEA (ORCPT ); Mon, 3 May 2021 10:04:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620050587; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dli2hA9V91jNU1uVhC91EUBTOsr+YjBKusIKdCkZYKU=; b=LaRLqU0OSk4SlldWk/OnwZE3UcdZVAFGpmwCIkquqK/QB7BYZoMP2IvTCpN1AmZjWetK3w OpCY9RcRbw+g5yw/rzG9E7tw0teHJSsONkj/Mz+nnrvdT2kMC+kNFIUstx++07e8bNrRoV 1vmIRrLa0zOrYeNuu4XxeoPn5zSYLHg= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-420-IvcXQ3xINCm8_kCM89nQag-1; Mon, 03 May 2021 10:03:06 -0400 X-MC-Unique: IvcXQ3xINCm8_kCM89nQag-1 Received: by mail-ej1-f69.google.com with SMTP id w23-20020a1709061857b029039ea04b02fdso2080145eje.22 for ; Mon, 03 May 2021 07:03:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dli2hA9V91jNU1uVhC91EUBTOsr+YjBKusIKdCkZYKU=; b=VhOhg9g2lMXJ9fzbTQYA3d45/XPMMV2cBxlX1QoIWYzBWyISv8T+6M+1pgL7hyhV7N 7bcactSVR+4sSGGmLa8ulT+G5+vm7O27YuzELgueM18HXy6pDnopkA+1lP3beHIcpuYN AMOJ9J/fRlabpfo/wHD6jGEw5tct5z3pTWlHRX8/2Vov+kXqhlVMNkgpPfDhVBzVcuRg Ovc9X7MBwO318hKY2Vfmd0NdvFQHzL+MOfTdnOgaemLGKAk77mE4yimIQI/i/Nc95ffr dDzeZS+h1jBA5HaEo6mRDuGiRPYoondJq8fdAPw03LEkC9vPdBuA2ynLxICEoTbbHqT5 gRlA== X-Gm-Message-State: AOAM530lBMR3OJ/S7weVcuhVC6P90apCU8gZBWtl3mNjAAQRBlSv2u8U ymCm3y8QLVwZd6W+FpPuoFVOm0sNQVhI/zMbvIORGcJkV3pLep+3CzHFDjnCDJgqrzX6R2UYtl2 WBSaXtkR70t8E X-Received: by 2002:aa7:d146:: with SMTP id r6mr16489328edo.344.1620050584890; Mon, 03 May 2021 07:03:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzO8d/PrGuqhERyc2VXANVbuEyQKlzvZTSxdVnqElH4sgaEFlDH0GbNy9lWT3MgxmBLjEt7mA== X-Received: by 2002:aa7:d146:: with SMTP id r6mr16489292edo.344.1620050584671; Mon, 03 May 2021 07:03:04 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id j16sm12717416edr.9.2021.05.03.07.03.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 May 2021 07:03:04 -0700 (PDT) Subject: Re: [PATCH 0/5] KVM: nSVM: few fixes for the nested migration To: Maxim Levitsky , kvm@vger.kernel.org Cc: Wanpeng Li , Thomas Gleixner , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Jim Mattson , Vitaly Kuznetsov , "H. Peter Anvin" , Borislav Petkov , Joerg Roedel , Ingo Molnar , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Sean Christopherson , Cathy Avery References: <20210503125446.1353307-1-mlevitsk@redhat.com> From: Paolo Bonzini Message-ID: <358f9624-eb77-5449-845c-c92676fed8ed@redhat.com> Date: Mon, 3 May 2021 16:03:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210503125446.1353307-1-mlevitsk@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 03/05/21 14:54, Maxim Levitsky wrote: > Those are few fixes for issues I uncovered by doing variants of a > synthetic migration test I just created: > > I modified the qemu, such that on each vm pause/resume cycle, > just prior to resuming a vCPU, qemu reads its KVM state, > then (optionaly) resets this state by uploading a > dummy reset state to KVM, and then it uploads back to KVM, > the state that this vCPU had before. > > I'll try to make this test upstreamable soon, pending few details > I need to figure out. > > Last patch in this series is for false positive warning > that I have seen lately when setting the nested state, > in nested_svm_vmexit, where it expects the vmcb01 to have > VMRUN vmexit, which is not true after nested migration, > as it is not fully initialized. > If you prefer the warning can be removed instead. > > Best regards, > Maxim Levitsky > > Maxim Levitsky (5): > KVM: nSVM: fix a typo in svm_leave_nested > KVM: nSVM: fix few bugs in the vmcb02 caching logic > KVM: nSVM: leave the guest mode prior to loading a nested state > KVM: nSVM: force L1's GIF to 1 when setting the nested state > KVM: nSVM: set a dummy exit reason in L1 vmcb when loading the nested > state > > arch/x86/include/asm/kvm_host.h | 1 + > arch/x86/kvm/svm/nested.c | 29 ++++++++++++++++++++++++++--- > arch/x86/kvm/svm/svm.c | 4 ++-- > 3 files changed, 29 insertions(+), 5 deletions(-) > Queued patches 1-3. Paolo