From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D623AC433DF for ; Mon, 3 Aug 2020 10:27:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B082A20738 for ; Mon, 3 Aug 2020 10:27:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Dafx2E5E" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726370AbgHCK11 (ORCPT ); Mon, 3 Aug 2020 06:27:27 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:35034 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725933AbgHCK10 (ORCPT ); Mon, 3 Aug 2020 06:27:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596450445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FgweyaoU1uHNy0URH0Fh2hsAsdHBpTAtSbV2WfKVsyM=; b=Dafx2E5E5EKqRE8yyAJuOkjNe92Egx3mPTJBj6jkl/re+uPjeT90UsMnWqrAcorfmKwaBd MZNActxvasDW5L/NdQpPVfaWF6TxMpeRrFVl/j9UrcsTMzpEC1He4dV1q5eCZhOqkGgh1b vtsuEW/rMLJoG6RvpD04/bKi8pXCyA0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-250-FYoUmX3PPRqakdPi3RyQgw-1; Mon, 03 Aug 2020 06:27:23 -0400 X-MC-Unique: FYoUmX3PPRqakdPi3RyQgw-1 Received: by mail-wm1-f71.google.com with SMTP id p23so4683738wmc.2 for ; Mon, 03 Aug 2020 03:27:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FgweyaoU1uHNy0URH0Fh2hsAsdHBpTAtSbV2WfKVsyM=; b=etkgSq6qIYwO4vpW9sbW+6rsDr0sBkz3wZh5GVj4sHIbwJChpYpRYnmeYIbm+5COsC hnQ5M+f93bdgCBhDuZTqV7rSJUkI61iutU7Ack1mw2isTOy2bVk7vbYC7T7ILGJGyeh7 5vRiOLsclVZ+OSWyRZot/1MR4Zjg/DTR7U4lyuprCmR2xvww3DLLooWKlR74S0gJBpWS DkWS51Zh+hKWJ6u2UdHVdj7yoGn+C5TWMa6Yt3lETcWEvTnw/QAU/lkYF1mGIgs+zkXS NQXhQF6f9p1EETix7qt0UQ8OreKSsPJ7c3Z814AMrvRCIZ62F4BKO3YSIV13sQM5qQ/0 LqfQ== X-Gm-Message-State: AOAM530FBjF98CFturizwWBpKtI5wdFHhBtI2vUcJY4xiLS57q+UHcZT yDuZi/V+tc0XyzaToRsgmTjepXCkpC9m56pDsFInWjBPHmVkGxdr9UYbmxaejto4vwtNiL5bEv3 jUAoFJkUeDp2y X-Received: by 2002:adf:81c5:: with SMTP id 63mr15131683wra.185.1596450442407; Mon, 03 Aug 2020 03:27:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwrg0aV3Z3PdF/J4QoXV3umcZ/Nc56wepMXP/rpTQH7mPwywtlK1jfx+z3A+Kqq/eCtJNOZGw== X-Received: by 2002:adf:81c5:: with SMTP id 63mr15131666wra.185.1596450442181; Mon, 03 Aug 2020 03:27:22 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:310b:68e5:c01a:3778? ([2001:b07:6468:f312:310b:68e5:c01a:3778]) by smtp.gmail.com with ESMTPSA id z207sm25102477wmc.2.2020.08.03.03.27.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2020 03:27:21 -0700 (PDT) Subject: Re: [PATCH] KVM: SVM: Fix sev_pin_memory() error handling To: Sean Christopherson , Dan Carpenter Cc: Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , kvm@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20200714142351.GA315374@mwanda> <20200731201859.GF31451@linux.intel.com> From: Paolo Bonzini Message-ID: <37d241e2-6d21-c923-b9be-991fe42ebd4a@redhat.com> Date: Mon, 3 Aug 2020 12:27:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200731201859.GF31451@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 31/07/20 22:18, Sean Christopherson wrote: > On Tue, Jul 14, 2020 at 05:23:51PM +0300, Dan Carpenter wrote: >> The sev_pin_memory() function was modified to return error pointers >> instead of NULL but there are two problems. The first problem is that >> if "npages" is zero then it still returns NULL. Secondly, several of >> the callers were not updated to check for error pointers instead of >> NULL. >> >> Either one of these issues will lead to an Oops. >> >> Fixes: a8d908b5873c ("KVM: x86: report sev_pin_memory errors with PTR_ERR") > > Explicit Cc: to stable needed for KVM patches. > >> Signed-off-by: Dan Carpenter > > Reviewed-by: Sean Christopherson > Fortunately it's only broken in 5.9. Queued, thanks. Paolo