From: Auger Eric <eric.auger@redhat.com> To: Marc Zyngier <maz@kernel.org> Cc: eric.auger.pro@gmail.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, drjones@redhat.com, alexandru.elisei@arm.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, shuah@kernel.org, pbonzini@redhat.com Subject: Re: [PATCH 3/9] KVM: arm64: vgic-v3: Fix error handling in vgic_v3_set_redist_base() Date: Wed, 13 Jan 2021 18:18:42 +0100 [thread overview] Message-ID: <3b073d69-dd4a-3f82-3a96-5361dabbce80@redhat.com> (raw) In-Reply-To: <87a6tyoseo.wl-maz@kernel.org> Hi Marc, On 12/28/20 4:35 PM, Marc Zyngier wrote: > Hi Eric, > > On Sat, 12 Dec 2020 18:50:04 +0000, > Eric Auger <eric.auger@redhat.com> wrote: >> >> vgic_register_all_redist_iodevs may succeed while >> vgic_register_all_redist_iodevs fails. For example this can happen > > The same function cannot both fail and succeed ;-) Can you shed some > light on what you had in mind? Damn, I meant vgic_v3_insert_redist_region() can be successful and then vgic_register_all_redist_iodevs() fails due to detection of overlap. > >> while adding a redistributor region overlapping a dist region. The >> failure only is detected on vgic_register_all_redist_iodevs when >> vgic_v3_check_base() gets called. >> >> In such a case, remove the newly added redistributor region and free >> it. >> >> Signed-off-by: Eric Auger <eric.auger@redhat.com> >> --- >> arch/arm64/kvm/vgic/vgic-mmio-v3.c | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/kvm/vgic/vgic-mmio-v3.c b/arch/arm64/kvm/vgic/vgic-mmio-v3.c >> index 8e8a862def76..581f0f490000 100644 >> --- a/arch/arm64/kvm/vgic/vgic-mmio-v3.c >> +++ b/arch/arm64/kvm/vgic/vgic-mmio-v3.c >> @@ -866,8 +866,14 @@ int vgic_v3_set_redist_base(struct kvm *kvm, u32 index, u64 addr, u32 count) >> * afterwards will register the iodevs when needed. >> */ >> ret = vgic_register_all_redist_iodevs(kvm); >> - if (ret) >> + if (ret) { >> + struct vgic_redist_region *rdreg = >> + vgic_v3_rdist_region_from_index(kvm, index); >> + > > nit: consider splitting declaration and assignment so that we avoid > the line split if you insist on the 80 character limit. Sure Thanks Eric > >> + list_del(&rdreg->list); >> + kfree(rdreg); >> return ret; >> + } >> >> return 0; >> } >> -- >> 2.21.3 >> >> > > Thanks, > > M. >
next prev parent reply other threads:[~2021-01-13 17:20 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-12 18:50 [PATCH 0/9] KVM/ARM: Some vgic fixes and init sequence KVM selftests Eric Auger 2020-12-12 18:50 ` [PATCH 1/9] KVM: arm64: vgic-v3: Fix some error codes when setting RDIST base Eric Auger 2021-01-06 16:32 ` Alexandru Elisei 2021-01-14 10:02 ` Auger Eric 2020-12-12 18:50 ` [PATCH 2/9] KVM: arm64: Fix KVM_VGIC_V3_ADDR_TYPE_REDIST_REGION read Eric Auger 2021-01-06 17:12 ` Alexandru Elisei 2021-01-13 17:18 ` Auger Eric 2020-12-12 18:50 ` [PATCH 3/9] KVM: arm64: vgic-v3: Fix error handling in vgic_v3_set_redist_base() Eric Auger 2020-12-28 15:35 ` Marc Zyngier 2021-01-13 17:18 ` Auger Eric [this message] 2020-12-12 18:50 ` [PATCH 4/9] KVM: arm/arm64: vgic: Reset base address on kvm_vgic_dist_destroy() Eric Auger 2020-12-28 15:41 ` Marc Zyngier 2021-01-13 17:18 ` Auger Eric 2020-12-12 18:50 ` [PATCH 5/9] KVM: arm: move has_run_once after the map_resources Eric Auger 2021-01-12 14:55 ` Alexandru Elisei 2021-01-14 10:02 ` Auger Eric 2021-01-20 15:56 ` Alexandru Elisei 2021-03-12 17:27 ` Auger Eric 2020-12-12 18:50 ` [PATCH 6/9] docs: kvm: devices/arm-vgic-v3: enhance KVM_DEV_ARM_VGIC_CTRL_INIT doc Eric Auger 2021-01-12 15:39 ` Alexandru Elisei 2021-01-13 17:18 ` Auger Eric 2020-12-12 18:50 ` [PATCH 7/9] KVM: arm64: Simplify argument passing to vgic_uaccess_[read|write] Eric Auger 2021-01-12 16:04 ` Alexandru Elisei 2021-01-12 16:16 ` Alexandru Elisei 2021-01-13 17:18 ` Auger Eric 2020-12-12 18:50 ` [PATCH 8/9] KVM: arm64: vgic-v3: Expose GICR_TYPER.Last for userspace Eric Auger 2021-01-12 17:02 ` Alexandru Elisei 2021-01-14 10:16 ` Auger Eric 2021-01-20 16:13 ` Alexandru Elisei 2021-03-12 17:26 ` Auger Eric 2021-01-12 17:28 ` Alexandru Elisei 2021-01-12 17:48 ` Marc Zyngier 2020-12-12 18:50 ` [PATCH 9/9] KVM: selftests: aarch64/vgic-v3 init sequence tests Eric Auger
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3b073d69-dd4a-3f82-3a96-5361dabbce80@redhat.com \ --to=eric.auger@redhat.com \ --cc=alexandru.elisei@arm.com \ --cc=drjones@redhat.com \ --cc=eric.auger.pro@gmail.com \ --cc=james.morse@arm.com \ --cc=julien.thierry.kdev@gmail.com \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-kernel@vger.kernel.org \ --cc=maz@kernel.org \ --cc=pbonzini@redhat.com \ --cc=shuah@kernel.org \ --cc=suzuki.poulose@arm.com \ --subject='Re: [PATCH 3/9] KVM: arm64: vgic-v3: Fix error handling in vgic_v3_set_redist_base()' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).