From: Paolo Bonzini <firstname.lastname@example.org> To: Thomas Huth <email@example.com>, firstname.lastname@example.org Cc: Drew Jones <email@example.com> Subject: Re: [kvm-unit-tests PATCH] scripts: Fix the check whether testname is in the only_tests list Date: Wed, 1 Jul 2020 11:43:03 +0200 Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> On 01/07/20 10:57, Thomas Huth wrote: >>> >> >> Simpler: grep -q " $testname " <<< " $only_tests " > > That doesn't work: > > $ ./run_tests.sh ioapic-split > PASS apic-split (53 tests) > PASS ioapic-split (19 tests) > PASS apic (53 tests) > PASS ioapic (26 tests) > > ... because the $testname comes from unittests.cfg and $only_tests is > the list that has been given on the command line. It would maybe work if > the check was the other way round ... but that would require to rewrite > quite a bit of the script logic... It works here. I'll send a patch. Paolo > By the way, you can currently also run "./run_test.sh badname" and it > does *not* complain that "badname" is an illegal test name...
next prev parent reply index Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-01 8:37 Thomas Huth 2020-07-01 8:51 ` Paolo Bonzini 2020-07-01 8:57 ` Thomas Huth 2020-07-01 9:43 ` Paolo Bonzini [this message] 2020-07-01 9:55 ` Thomas Huth
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
KVM Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/kvm/0 kvm/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 kvm kvm/ https://lore.kernel.org/kvm \ email@example.com public-inbox-index kvm Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.kvm AGPL code for this site: git clone https://public-inbox.org/public-inbox.git