From: Janosch Frank <frankja@linux.ibm.com>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>,
Nico Boehr <nrb@linux.ibm.com>
Cc: kvm@vger.kernel.org, borntraeger@linux.ibm.com
Subject: Re: [PATCH v3 2/2] KVM: s390: remove now unused function kvm_s390_set_tod_clock
Date: Mon, 10 Oct 2022 17:23:17 +0200 [thread overview]
Message-ID: <3baa95fd-4ac4-e853-ad3b-2589265f910e@linux.ibm.com> (raw)
In-Reply-To: <20221005190127.49f7ab6e@p-imbrenda>
On 10/5/22 19:01, Claudio Imbrenda wrote:
> On Wed, 5 Oct 2022 18:32:58 +0200
> Nico Boehr <nrb@linux.ibm.com> wrote:
>
>> The function kvm_s390_set_tod_clock is now unused, hence let's remove
>> it.
>>
>> Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
>
> Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Hrm only the first patch has the fixes tag but leaving an unused
function around in a stable kernel feels weird to me.
Let's discuss that tomorrow.
>
>> ---
>> arch/s390/kvm/kvm-s390.c | 7 -------
>> arch/s390/kvm/kvm-s390.h | 1 -
>> 2 files changed, 8 deletions(-)
>>
>> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
>> index 0a8019b14c8f..9ec8870832e7 100644
>> --- a/arch/s390/kvm/kvm-s390.c
>> +++ b/arch/s390/kvm/kvm-s390.c
>> @@ -4390,13 +4390,6 @@ static void __kvm_s390_set_tod_clock(struct kvm *kvm, const struct kvm_s390_vm_t
>> preempt_enable();
>> }
>>
>> -void kvm_s390_set_tod_clock(struct kvm *kvm, const struct kvm_s390_vm_tod_clock *gtod)
>> -{
>> - mutex_lock(&kvm->lock);
>> - __kvm_s390_set_tod_clock(kvm, gtod);
>> - mutex_unlock(&kvm->lock);
>> -}
>> -
>> int kvm_s390_try_set_tod_clock(struct kvm *kvm, const struct kvm_s390_vm_tod_clock *gtod)
>> {
>> if (!mutex_trylock(&kvm->lock))
>> diff --git a/arch/s390/kvm/kvm-s390.h b/arch/s390/kvm/kvm-s390.h
>> index f6fd668f887e..4755492dfabc 100644
>> --- a/arch/s390/kvm/kvm-s390.h
>> +++ b/arch/s390/kvm/kvm-s390.h
>> @@ -363,7 +363,6 @@ int kvm_s390_handle_sigp(struct kvm_vcpu *vcpu);
>> int kvm_s390_handle_sigp_pei(struct kvm_vcpu *vcpu);
>>
>> /* implemented in kvm-s390.c */
>> -void kvm_s390_set_tod_clock(struct kvm *kvm, const struct kvm_s390_vm_tod_clock *gtod);
>> int kvm_s390_try_set_tod_clock(struct kvm *kvm, const struct kvm_s390_vm_tod_clock *gtod);
>> long kvm_arch_fault_in_page(struct kvm_vcpu *vcpu, gpa_t gpa, int writable);
>> int kvm_s390_store_status_unloaded(struct kvm_vcpu *vcpu, unsigned long addr);
>
prev parent reply other threads:[~2022-10-10 15:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 16:32 [PATCH v3 0/2] KVM: s390: pv: fix clock comparator late after suspend/resume Nico Boehr
2022-10-05 16:32 ` [PATCH v3 1/2] KVM: s390: pv: don't allow userspace to set the clock under PV Nico Boehr
2022-10-05 17:01 ` Claudio Imbrenda
2022-10-10 15:20 ` Janosch Frank
2022-10-11 8:41 ` Nico Boehr
2022-10-05 16:32 ` [PATCH v3 2/2] KVM: s390: remove now unused function kvm_s390_set_tod_clock Nico Boehr
2022-10-05 17:01 ` Claudio Imbrenda
2022-10-10 15:23 ` Janosch Frank [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3baa95fd-4ac4-e853-ad3b-2589265f910e@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=nrb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).