From: Paolo Bonzini <pbonzini@redhat.com>
To: Like Xu <like.xu@linux.intel.com>, Avi Kivity <avi@scylladb.com>
Cc: Joe Perches <joe@perches.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] KVM: x86/vPMU: refine kvm_pmu err msg when event creation failed
Date: Thu, 18 Jul 2019 15:52:53 +0200 [thread overview]
Message-ID: <3d1d84a0-7c63-e470-a1d1-b32f56e52f74@redhat.com> (raw)
In-Reply-To: <20190718053514.59742-1-like.xu@linux.intel.com>
On 18/07/19 07:35, Like Xu wrote:
> If a perf_event creation fails due to any reason of the host perf
> subsystem, it has no chance to log the corresponding event for guest
> which may cause abnormal sampling data in guest result. In debug mode,
> this message helps to understand the state of vPMC and we may not
> limit the number of occurrences but not in a spamming style.
>
> Suggested-by: Joe Perches <joe@perches.com>
> Signed-off-by: Like Xu <like.xu@linux.intel.com>
> ---
> arch/x86/kvm/pmu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kvm/pmu.c b/arch/x86/kvm/pmu.c
> index aa5a2597305a..cedaa01ceb6f 100644
> --- a/arch/x86/kvm/pmu.c
> +++ b/arch/x86/kvm/pmu.c
> @@ -131,8 +131,8 @@ static void pmc_reprogram_counter(struct kvm_pmc *pmc, u32 type,
> intr ? kvm_perf_overflow_intr :
> kvm_perf_overflow, pmc);
> if (IS_ERR(event)) {
> - printk_once("kvm_pmu: event creation failed %ld\n",
> - PTR_ERR(event));
> + pr_debug_ratelimited("kvm_pmu: event creation failed %ld for pmc->idx = %d\n",
> + PTR_ERR(event), pmc->idx);
> return;
> }
>
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2019-07-18 13:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 5:35 [PATCH v2] KVM: x86/vPMU: refine kvm_pmu err msg when event creation failed Like Xu
2019-07-18 13:52 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d1d84a0-7c63-e470-a1d1-b32f56e52f74@redhat.com \
--to=pbonzini@redhat.com \
--cc=avi@scylladb.com \
--cc=joe@perches.com \
--cc=kvm@vger.kernel.org \
--cc=like.xu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).