Re: [PATCH v2 1/6] KVM: x86: SVM: add module param to control LBR virtualization

[Maxim Levitsky <mlevitsk@redhat.com>]

On Mon, 2021-11-01 at 17:21 +0100, Vitaly Kuznetsov wrote:
> Maxim Levitsky <mlevitsk@redhat.com> writes:
> 
> > This is useful for debug and also makes it consistent with
> > the rest of the SVM optional features.
> > 
> > Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
> > ---
> >  arch/x86/kvm/svm/svm.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
> > index 21bb81710e0f6..2b5f8e10d686d 100644
> > --- a/arch/x86/kvm/svm/svm.c
> > +++ b/arch/x86/kvm/svm/svm.c
> > @@ -186,12 +186,13 @@ module_param(vls, int, 0444);
> >  static int vgif = true;
> >  module_param(vgif, int, 0444);
> >  
> > +static int tsc_scaling = true;
> > +module_param(tsc_scaling, int, 0444);
> > +
> >  /* enable/disable LBR virtualization */
> >  static int lbrv = true;
> >  module_param(lbrv, int, 0444);
> >  
> > -static int tsc_scaling = true;
> > -module_param(tsc_scaling, int, 0444);
> 
> Subject line says "KVM: x86: SVM: add module param to control LBR
> virtualization" but the patch just moves 'tsc_scaling' param a couple
> lines up. Was this intended or is this a rebase artifact and the patch
> just needs to be dropped?

Yes, I didn't notice when I rebased the series last time, that this patch was accepted
already.

Sorry for the noise.

Best regards,
	Maxim Levitsky

> 
> >  
> >  /*
> >   * enable / disable AVIC.  Because the defaults differ for APICv