From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0D33C3F68F for ; Thu, 30 Jan 2020 05:44:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C827E20CC7 for ; Thu, 30 Jan 2020 05:44:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Y6R00qTG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726469AbgA3FoQ (ORCPT ); Thu, 30 Jan 2020 00:44:16 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:57398 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725873AbgA3FoP (ORCPT ); Thu, 30 Jan 2020 00:44:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580363054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b8PEF8AVAWODPDupJea+4sWEJHHfwQkjaA/7qcZmag4=; b=Y6R00qTGMkNZUDTi9Bjzix9BllX0aNbcel38FTI/KrI0Gy8ohOqOO1Bo+f8ANxQ1udmsI+ 9gc93iPBE/sR02iBoU12Jc/3Qc6eX62uUl1dMn9j+vUyG+JNRIzIuJRkCkDUz+nQ7AQlt3 2i8of8hMPtwPYKMTBmpP5X7h+dsdlcs= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-368-47UrOtCqP9u-T_G9MYz_gg-1; Thu, 30 Jan 2020 00:44:12 -0500 X-MC-Unique: 47UrOtCqP9u-T_G9MYz_gg-1 Received: by mail-wr1-f70.google.com with SMTP id v17so1204228wrm.17 for ; Wed, 29 Jan 2020 21:44:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=b8PEF8AVAWODPDupJea+4sWEJHHfwQkjaA/7qcZmag4=; b=tAiNFMPHWP88vE1R4vSltsIOQ+a4rjmBIIREEC9JN/LHUy5Gd8uisHaRGe692G970f qqUcdjBUnygFstnvX8kazfTj+7PLcuNWsoADWsHK3olYBEGQRu8wObJUv1voUJPYNndJ gzLrgTRYe1xA7ezD6Jou5yHMhCWrqOhJuI479GSEalsRk8qZnV+xgJqHiKwq0ueAClTE PCxLsxtJtxJuIb4kfTpNOOFtLbY8xwtattjwRwJKV5o5PwuEdiNoKvpnyk2UQDcDducf 2y7yTE3QlZKfxjUIjZiuiT+x/x3LqeNaVZuU2evZRE5EC4bSINTSvwWOAAVRZNZsVnQh JaGA== X-Gm-Message-State: APjAAAVH3rD177FnF+6Mae7XGvsJwqbHthHdjPa6BL9Txop41jwstnkf LToZM1t/mLdhHo3PmoRuWmy3czM4Lj9DY1UNFnwM0eLTVM+AR8vXB7X8qsF3RP+4y0Q1tAb+Inh auj73PHMiSovL X-Received: by 2002:a7b:cbcf:: with SMTP id n15mr3175365wmi.21.1580363051209; Wed, 29 Jan 2020 21:44:11 -0800 (PST) X-Google-Smtp-Source: APXvYqxvrtUyXEqgq8iYKVpAB/LAj4fC31bOc+VOTWRDvsFWxjJ6sWsl8qJGadVTcya+7iE6vbimVA== X-Received: by 2002:a7b:cbcf:: with SMTP id n15mr3175335wmi.21.1580363050959; Wed, 29 Jan 2020 21:44:10 -0800 (PST) Received: from [10.1.251.141] ([80.188.125.198]) by smtp.gmail.com with ESMTPSA id 4sm4795049wmg.22.2020.01.29.21.44.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jan 2020 21:44:10 -0800 (PST) Subject: Re: [PATCH 5/5] KVM: x86: Set kvm_x86_ops only after ->hardware_setup() completes To: Sean Christopherson Cc: Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org References: <20200130001023.24339-1-sean.j.christopherson@intel.com> <20200130001023.24339-6-sean.j.christopherson@intel.com> From: Paolo Bonzini Message-ID: <44e0c550-7dcc-bfed-07c4-907e61d476a1@redhat.com> Date: Thu, 30 Jan 2020 06:44:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20200130001023.24339-6-sean.j.christopherson@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 30/01/20 01:10, Sean Christopherson wrote: > Set kvm_x86_ops with the vendor's ops only after ->hardware_setup() > completes to "prevent" using kvm_x86_ops before they are ready, i.e. to > generate a null pointer fault instead of silently consuming unconfigured > state. What about even copying kvm_x86_ops by value, so that they can be accessed with "kvm_x86_ops.callback()" and save one memory access? Paolo