kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Janosch Frank <frankja@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: thuth@redhat.com, david@redhat.com, borntraeger@de.ibm.com,
	imbrenda@linux.ibm.com, cohuck@redhat.com,
	linux-s390@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH v4 0/9] s390x: Add SIE library and simple tests
Date: Mon, 18 Jan 2021 10:43:52 +0100	[thread overview]
Message-ID: <45420c5f-cf5f-a3bc-d555-6093d88a0c59@linux.ibm.com> (raw)
In-Reply-To: <20210112132054.49756-1-frankja@linux.ibm.com>

On 1/12/21 2:20 PM, Janosch Frank wrote:
> This is the absolute minimum needed to run VMs inside the KVM Unit
> Tests. It's more of a base for other tests that I can't (yet) publish
> than an addition of tests that check KVM functionality. However, I
> wanted to decrease the number of WIP patches in my private
> branch. Once the library is available maybe others will come and
> extend the SIE test itself.
> 
> Yes, I have added VM management functionality like VM create/destroy,
> etc but as it is not needed right now, I'd like to exclude it from
> this patch set for now.

I've picked patches 1-8.
Patch 9 is dropped for now, it's only a comment anyway.

Thanks for all of your review comments!

> 
> v4:
> 	* Removed asm directory and moved all asm files into s390x/ (I changed my view)
> 	* Review fixes
> 	* Removed a stray newline in the asm offsets file
> 
> v3:
> 	* Rebased on re-license patches
> 	* Split assembly
> 	* Now using ICPT_* constants
> 	* Added read_info asserts
> 	* Fixed missing spin_lock() in smp.c lib
> 	* Replaced duplicated code in sie test with generic intercept test
> 	* Replaced uv-guest.x bit testing with test_bit_inv()
> 	* Some other minor cleanups
> 
> Gitlab:
> https://gitlab.com/frankja/kvm-unit-tests/-/tree/sie
> 
> CI:
> https://gitlab.com/frankja/kvm-unit-tests/-/pipelines/240506525
> 
> 
> Janosch Frank (9):
>   s390x: Add test_bit to library
>   s390x: Consolidate sclp read info
>   s390x: SCLP feature checking
>   s390x: Split assembly into multiple files
>   s390x: sie: Add SIE to lib
>   s390x: sie: Add first SIE test
>   s390x: Add diag318 intercept test
>   s390x: Fix sclp.h style issues
>   s390x: sclp: Add CPU entry offset comment
> 
>  lib/s390x/asm-offsets.c  |  11 +++
>  lib/s390x/asm/arch_def.h |   9 ++
>  lib/s390x/asm/bitops.h   |  26 ++++++
>  lib/s390x/asm/facility.h |   3 +-
>  lib/s390x/interrupt.c    |   7 ++
>  lib/s390x/io.c           |   2 +
>  lib/s390x/sclp.c         |  57 +++++++++--
>  lib/s390x/sclp.h         | 181 +++++++++++++++++++----------------
>  lib/s390x/sie.h          | 197 +++++++++++++++++++++++++++++++++++++++
>  lib/s390x/smp.c          |  27 +++---
>  s390x/Makefile           |   7 +-
>  s390x/cstart64.S         | 119 +----------------------
>  s390x/intercept.c        |  19 ++++
>  s390x/lib.S              | 121 ++++++++++++++++++++++++
>  s390x/macros.S           |  77 +++++++++++++++
>  s390x/sie.c              | 113 ++++++++++++++++++++++
>  s390x/unittests.cfg      |   3 +
>  s390x/uv-guest.c         |   6 +-
>  18 files changed, 761 insertions(+), 224 deletions(-)
>  create mode 100644 lib/s390x/sie.h
>  create mode 100644 s390x/lib.S
>  create mode 100644 s390x/macros.S
>  create mode 100644 s390x/sie.c
> 


      parent reply	other threads:[~2021-01-18 10:07 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-12 13:20 Janosch Frank
2021-01-12 13:20 ` [kvm-unit-tests PATCH v4 1/9] s390x: Add test_bit to library Janosch Frank
2021-01-14 13:55   ` Claudio Imbrenda
2021-01-12 13:20 ` [kvm-unit-tests PATCH v4 2/9] s390x: Consolidate sclp read info Janosch Frank
2021-01-14 13:57   ` Claudio Imbrenda
2021-01-12 13:20 ` [kvm-unit-tests PATCH v4 3/9] s390x: SCLP feature checking Janosch Frank
2021-01-13 11:02   ` Cornelia Huck
2021-01-14 13:47   ` Claudio Imbrenda
2021-01-12 13:20 ` [kvm-unit-tests PATCH v4 4/9] s390x: Split assembly into multiple files Janosch Frank
2021-01-13 11:04   ` Cornelia Huck
2021-01-13 12:04   ` Thomas Huth
2021-01-13 12:15     ` Janosch Frank
2021-01-14  8:54       ` Thomas Huth
2021-01-12 13:20 ` [kvm-unit-tests PATCH v4 5/9] s390x: sie: Add SIE to lib Janosch Frank
2021-01-13 12:44   ` Thomas Huth
2021-01-13 13:34     ` Janosch Frank
2021-01-14 14:43   ` Claudio Imbrenda
2021-01-14 15:03     ` Janosch Frank
2021-01-12 13:20 ` [kvm-unit-tests PATCH v4 6/9] s390x: sie: Add first SIE test Janosch Frank
2021-01-12 13:20 ` [kvm-unit-tests PATCH v4 7/9] s390x: Add diag318 intercept test Janosch Frank
2021-01-13 11:12   ` Cornelia Huck
2021-01-12 13:20 ` [kvm-unit-tests PATCH v4 8/9] s390x: Fix sclp.h style issues Janosch Frank
2021-01-12 13:20 ` [kvm-unit-tests PATCH v4 9/9] s390x: sclp: Add CPU entry offset comment Janosch Frank
2021-01-12 15:51   ` Thomas Huth
2021-01-13 10:25   ` David Hildenbrand
2021-01-13 11:06     ` Janosch Frank
2021-01-13 11:09     ` Cornelia Huck
2021-01-13 13:16     ` Thomas Huth
2021-01-14 14:45   ` Claudio Imbrenda
2021-01-18  9:43 ` Janosch Frank [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45420c5f-cf5f-a3bc-d555-6093d88a0c59@linux.ibm.com \
    --to=frankja@linux.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=thuth@redhat.com \
    --subject='Re: [kvm-unit-tests PATCH v4 0/9] s390x: Add SIE library and simple tests' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).