From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FEA3C49EA5 for ; Thu, 24 Jun 2021 09:43:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4AF2E613C3 for ; Thu, 24 Jun 2021 09:43:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232041AbhFXJp5 (ORCPT ); Thu, 24 Jun 2021 05:45:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:30783 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232003AbhFXJp4 (ORCPT ); Thu, 24 Jun 2021 05:45:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624527817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qkxHw284a/HcUQKczqJcr3hZxs0a/eNZzaMIqcieCR4=; b=N2dmpoXd8h1tJ/1jVQ8EadWoXvdJ00hsKd76ingRURI7ArP7YM3OVAqgd5iCcGtLbxK3C7 J0rwSiQGm1W62yubsHJcsSZWAiwG+R6YTX3bMtLXDw+7oAc+B11Z/3FqYtBXdPD45Pcc9x UB6haCnVbw5AnTQduuhTYeNyrGJRGKk= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-63-7enqFs0UMDuHnp73X09IRw-1; Thu, 24 Jun 2021 05:43:36 -0400 X-MC-Unique: 7enqFs0UMDuHnp73X09IRw-1 Received: by mail-ed1-f72.google.com with SMTP id g13-20020a056402090db02903935a4cb74fso3050241edz.1 for ; Thu, 24 Jun 2021 02:43:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qkxHw284a/HcUQKczqJcr3hZxs0a/eNZzaMIqcieCR4=; b=huMFhdruAjdhTShfx+cL/U8mIzgCzi8wfDDOFTSDPkeRRTlLUgP8bzUB12j2vq+J7/ Czn4C/KFb+j8eOuzsI0cBs2yJ4Zwf+Cc0+RFc+c1EapFvwreiUb0yRWvcDs7Z//pRy4k w5CGez5DTYiJ4zfM4yD/+I3uu0uYtUQgmR+kUbtZ+PpTJLM3kmmrks1FhyYtxg2hSNdT ++lkmwwx/3APCE4qXHynHEAqJzZA2Q4nbcHJ2qs/v4w2U+Zrn5bvPT8t0VC4dlxws4mk eQK0z8sTr0mmrBVOqWTeH9MPtJ8SdPu7aq1u1WSeSinBYOw/Udc7p0O/7TnRWZNCY6Q1 D/Ig== X-Gm-Message-State: AOAM533kEtStbVc7CcnVzNSnGp9sCO6N0hQeQkLmh+ZpjTENQK6SVhpU 1LPBSr75FcoiTH2vaiW6hypiEP8H5Xefq0Bd70Jwog9MsbXrDa+UrTv4s+/lmpARaAaKSRJLOO8 z60D1qbyPmPmu X-Received: by 2002:a05:6402:944:: with SMTP id h4mr5798145edz.76.1624527815210; Thu, 24 Jun 2021 02:43:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwD6cFFU4Uspcy5dTYBfn7A0VR+4loxnlaoo/QjHY9IN1nmjQ4mSQ+4egclMkG5+RC1oGdqOg== X-Received: by 2002:a05:6402:944:: with SMTP id h4mr5798117edz.76.1624527814999; Thu, 24 Jun 2021 02:43:34 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id t17sm1544705edv.75.2021.06.24.02.43.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jun 2021 02:43:34 -0700 (PDT) Subject: Re: [PATCH 1/6] KVM: x86/mmu: release audited pfns To: Nicholas Piggin , Aleksandar Markovic , Huacai Chen , Marc Zyngier , Paul Mackerras , David Stevens , Zhenyu Wang , Zhi Wang Cc: Alexandru Elisei , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, James Morse , Jim Mattson , Joerg Roedel , kvmarm@lists.cs.columbia.edu, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Sean Christopherson , Suzuki K Poulose , Vitaly Kuznetsov , Wanpeng Li , Will Deacon References: <20210624035749.4054934-1-stevensd@google.com> <20210624035749.4054934-2-stevensd@google.com> <1624524156.04etgk7zmz.astroid@bobo.none> From: Paolo Bonzini Message-ID: <4816287a-b9a9-d3f4-f844-06922d696e06@redhat.com> Date: Thu, 24 Jun 2021 11:43:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <1624524156.04etgk7zmz.astroid@bobo.none> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 24/06/21 10:43, Nicholas Piggin wrote: > Excerpts from David Stevens's message of June 24, 2021 1:57 pm: >> From: David Stevens > > Changelog? This looks like a bug, should it have a Fixes: tag? Probably has been there forever... The best way to fix the bug would be to nuke mmu_audit.c, which I've threatened to do many times but never followed up on. Paolo > Thanks, > Nick > >> >> Signed-off-by: David Stevens >> --- >> arch/x86/kvm/mmu/mmu_audit.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/x86/kvm/mmu/mmu_audit.c b/arch/x86/kvm/mmu/mmu_audit.c >> index cedc17b2f60e..97ff184084b4 100644 >> --- a/arch/x86/kvm/mmu/mmu_audit.c >> +++ b/arch/x86/kvm/mmu/mmu_audit.c >> @@ -121,6 +121,8 @@ static void audit_mappings(struct kvm_vcpu *vcpu, u64 *sptep, int level) >> audit_printk(vcpu->kvm, "levels %d pfn %llx hpa %llx " >> "ent %llxn", vcpu->arch.mmu->root_level, pfn, >> hpa, *sptep); >> + >> + kvm_release_pfn_clean(pfn); >> } >> >> static void inspect_spte_has_rmap(struct kvm *kvm, u64 *sptep) >> -- >> 2.32.0.93.g670b81a890-goog >> >> >